Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1518788 > unrolled thread

[PATCH v3 23/28] staging: iio: tsl2583: clarified comment about clearing interrupts

Started byBrian Masney <masneyb@onstation.org>
First post2016-11-10 10:30 +0100
Last post2016-11-10 10:30 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v3 23/28] staging: iio: tsl2583: clarified comment about clearing interrupts Brian Masney <masneyb@onstation.org> - 2016-11-10 10:30 +0100

#1518788 — [PATCH v3 23/28] staging: iio: tsl2583: clarified comment about clearing interrupts

FromBrian Masney <masneyb@onstation.org>
Date2016-11-10 10:30 +0100
Subject[PATCH v3 23/28] staging: iio: tsl2583: clarified comment about clearing interrupts
Message-ID<sBTQf-3Ic-53@gated-at.bofh.it>
The comment that describes the code that clears the interrupt bit was
vague and didn't provide much value. This patch adds more detail about
why that bit needs to be cleared.

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 drivers/staging/iio/light/tsl2583.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
index d3fe9f7..68b77b8 100644
--- a/drivers/staging/iio/light/tsl2583.c
+++ b/drivers/staging/iio/light/tsl2583.c
@@ -205,8 +205,9 @@ static int tsl2583_get_lux(struct iio_dev *indio_dev)
 	}
 
 	/*
-	 * clear status, really interrupt status (interrupts are off), but
-	 * we use the bit anyway - don't forget 0x80 - this is a command
+	 * Clear the pending interrupt status bit on the chip to allow the next
+	 * integration cycle to start. This has to be done even though this
+	 * driver currently does not support interrupts.
 	 */
 	ret = i2c_smbus_write_byte(chip->client,
 				   (TSL2583_CMD_REG | TSL2583_CMD_SPL_FN |
-- 
2.7.4

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web