Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1517746 > unrolled thread
| Started by | Ricky Liang <jcliang@chromium.org> |
|---|---|
| First post | 2016-11-09 04:40 +0100 |
| Last post | 2016-11-10 00:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels() Ricky Liang <jcliang@chromium.org> - 2016-11-09 04:40 +0100
RE: [PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels() Amitkumar Karwar <akarwar@marvell.com> - 2016-11-09 10:00 +0100
Re: [PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels() Brian Norris <briannorris@chromium.org> - 2016-11-10 00:30 +0100
| From | Ricky Liang <jcliang@chromium.org> |
|---|---|
| Date | 2016-11-09 04:40 +0100 |
| Subject | [PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels() |
| Message-ID | <sBrTX-1PK-1@gated-at.bofh.it> |
kmemleak reports memory leak in mwifiex_save_hidden_ssid_channels():
unreferenced object 0xffffffc0a2914780 (size 192):
comm "ksdioirqd/mmc2", pid 2004, jiffies 4307182506 (age 820.684s)
hex dump (first 32 bytes):
00 06 47 49 4e 2d 32 67 01 03 c8 60 6c 03 01 40 ..GIN-2g...`l..@
07 10 54 57 20 34 04 1e 64 05 24 84 03 24 95 04 ..TW 4..d.$..$..
backtrace:
[<ffffffc0003375f4>] create_object+0x164/0x2b4
[<ffffffc0008e3530>] kmemleak_alloc+0x50/0x88
[<ffffffc000335120>] __kmalloc_track_caller+0x1bc/0x264
[<ffffffc00030899c>] kmemdup+0x38/0x64
[<ffffffbffc2311cc>] mwifiex_fill_new_bss_desc+0x3c/0x130 [mwifiex]
[<ffffffbffc22ee9c>] mwifiex_save_curr_bcn+0x4ec/0x640 [mwifiex]
[<ffffffbffc22f45c>] mwifiex_handle_event_ext_scan_report+0x1d4/0x268 [mwifiex]
[<ffffffbffc2375d0>] mwifiex_process_sta_event+0x378/0x898 [mwifiex]
[<ffffffbffc224dc8>] mwifiex_process_event+0x1a8/0x1e8 [mwifiex]
[<ffffffbffc2228f0>] mwifiex_main_process+0x258/0x534 [mwifiex]
[<ffffffbffc258858>] 0xffffffbffc258858
[<ffffffc00071ee90>] process_sdio_pending_irqs+0xf8/0x160
[<ffffffc00071efdc>] sdio_irq_thread+0x9c/0x1a4
[<ffffffc000240d08>] kthread+0xf4/0x100
[<ffffffc0002043fc>] ret_from_fork+0xc/0x50
[<ffffffffffffffff>] 0xffffffffffffffff
Signed-off-by: Ricky Liang <jcliang@chromium.org>
---
drivers/net/wireless/marvell/mwifiex/scan.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c b/drivers/net/wireless/marvell/mwifiex/scan.c
index 97c9765..98ce072 100644
--- a/drivers/net/wireless/marvell/mwifiex/scan.c
+++ b/drivers/net/wireless/marvell/mwifiex/scan.c
@@ -1671,6 +1671,10 @@ static int mwifiex_save_hidden_ssid_channels(struct mwifiex_private *priv,
}
done:
+ /* beacon_ie buffer was allocated in function
+ * mwifiex_fill_new_bss_desc(). Free it now.
+ */
+ kfree(bss_desc->beacon_buf);
kfree(bss_desc);
return 0;
}
--
2.6.6
[toc] | [next] | [standalone]
| From | Amitkumar Karwar <akarwar@marvell.com> |
|---|---|
| Date | 2016-11-09 10:00 +0100 |
| Subject | RE: [PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels() |
| Message-ID | <sBwTE-50d-35@gated-at.bofh.it> |
| In reply to | #1517746 |
> From: Ricky Liang [mailto:jcliang@chromium.org] > Sent: Wednesday, November 09, 2016 9:07 AM > Cc: Ricky Liang; Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo; open > list:MARVELL MWIFIEX WIRELESS DRIVER; open list:NETWORKING DRIVERS; open > list > Subject: [PATCH] mwifiex: fix memory leak in > mwifiex_save_hidden_ssid_channels() > > kmemleak reports memory leak in mwifiex_save_hidden_ssid_channels(): > > unreferenced object 0xffffffc0a2914780 (size 192): > comm "ksdioirqd/mmc2", pid 2004, jiffies 4307182506 (age 820.684s) > hex dump (first 32 bytes): > 00 06 47 49 4e 2d 32 67 01 03 c8 60 6c 03 01 40 ..GIN-2g...`l..@ > 07 10 54 57 20 34 04 1e 64 05 24 84 03 24 95 04 ..TW 4..d.$..$.. > backtrace: > [<ffffffc0003375f4>] create_object+0x164/0x2b4 > [<ffffffc0008e3530>] kmemleak_alloc+0x50/0x88 > [<ffffffc000335120>] __kmalloc_track_caller+0x1bc/0x264 > [<ffffffc00030899c>] kmemdup+0x38/0x64 > [<ffffffbffc2311cc>] mwifiex_fill_new_bss_desc+0x3c/0x130 [mwifiex] > [<ffffffbffc22ee9c>] mwifiex_save_curr_bcn+0x4ec/0x640 [mwifiex] > [<ffffffbffc22f45c>] > mwifiex_handle_event_ext_scan_report+0x1d4/0x268 [mwifiex] > [<ffffffbffc2375d0>] mwifiex_process_sta_event+0x378/0x898 [mwifiex] > [<ffffffbffc224dc8>] mwifiex_process_event+0x1a8/0x1e8 [mwifiex] > [<ffffffbffc2228f0>] mwifiex_main_process+0x258/0x534 [mwifiex] > [<ffffffbffc258858>] 0xffffffbffc258858 > [<ffffffc00071ee90>] process_sdio_pending_irqs+0xf8/0x160 > [<ffffffc00071efdc>] sdio_irq_thread+0x9c/0x1a4 > [<ffffffc000240d08>] kthread+0xf4/0x100 > [<ffffffc0002043fc>] ret_from_fork+0xc/0x50 > [<ffffffffffffffff>] 0xffffffffffffffff > > Signed-off-by: Ricky Liang <jcliang@chromium.org> > --- > drivers/net/wireless/marvell/mwifiex/scan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c > b/drivers/net/wireless/marvell/mwifiex/scan.c > index 97c9765..98ce072 100644 > --- a/drivers/net/wireless/marvell/mwifiex/scan.c > +++ b/drivers/net/wireless/marvell/mwifiex/scan.c > @@ -1671,6 +1671,10 @@ static int > mwifiex_save_hidden_ssid_channels(struct mwifiex_private *priv, > } > > done: > + /* beacon_ie buffer was allocated in function > + * mwifiex_fill_new_bss_desc(). Free it now. > + */ > + kfree(bss_desc->beacon_buf); > kfree(bss_desc); > return 0; > } Acked-by: Amitkumar Karwar <akarwar@marvell.com> Regards, Amitkumar
[toc] | [prev] | [next] | [standalone]
| From | Brian Norris <briannorris@chromium.org> |
|---|---|
| Date | 2016-11-10 00:30 +0100 |
| Subject | Re: [PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels() |
| Message-ID | <sBKtz-5LS-5@gated-at.bofh.it> |
| In reply to | #1517746 |
On Wed, Nov 09, 2016 at 11:37:28AM +0800, Ricky Liang wrote: > kmemleak reports memory leak in mwifiex_save_hidden_ssid_channels(): > > unreferenced object 0xffffffc0a2914780 (size 192): > comm "ksdioirqd/mmc2", pid 2004, jiffies 4307182506 (age 820.684s) > hex dump (first 32 bytes): > 00 06 47 49 4e 2d 32 67 01 03 c8 60 6c 03 01 40 ..GIN-2g...`l..@ > 07 10 54 57 20 34 04 1e 64 05 24 84 03 24 95 04 ..TW 4..d.$..$.. > backtrace: > [<ffffffc0003375f4>] create_object+0x164/0x2b4 > [<ffffffc0008e3530>] kmemleak_alloc+0x50/0x88 > [<ffffffc000335120>] __kmalloc_track_caller+0x1bc/0x264 > [<ffffffc00030899c>] kmemdup+0x38/0x64 > [<ffffffbffc2311cc>] mwifiex_fill_new_bss_desc+0x3c/0x130 [mwifiex] > [<ffffffbffc22ee9c>] mwifiex_save_curr_bcn+0x4ec/0x640 [mwifiex] > [<ffffffbffc22f45c>] mwifiex_handle_event_ext_scan_report+0x1d4/0x268 [mwifiex] > [<ffffffbffc2375d0>] mwifiex_process_sta_event+0x378/0x898 [mwifiex] > [<ffffffbffc224dc8>] mwifiex_process_event+0x1a8/0x1e8 [mwifiex] > [<ffffffbffc2228f0>] mwifiex_main_process+0x258/0x534 [mwifiex] > [<ffffffbffc258858>] 0xffffffbffc258858 > [<ffffffc00071ee90>] process_sdio_pending_irqs+0xf8/0x160 > [<ffffffc00071efdc>] sdio_irq_thread+0x9c/0x1a4 > [<ffffffc000240d08>] kthread+0xf4/0x100 > [<ffffffc0002043fc>] ret_from_fork+0xc/0x50 > [<ffffffffffffffff>] 0xffffffffffffffff > > Signed-off-by: Ricky Liang <jcliang@chromium.org> > --- > drivers/net/wireless/marvell/mwifiex/scan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c b/drivers/net/wireless/marvell/mwifiex/scan.c > index 97c9765..98ce072 100644 > --- a/drivers/net/wireless/marvell/mwifiex/scan.c > +++ b/drivers/net/wireless/marvell/mwifiex/scan.c > @@ -1671,6 +1671,10 @@ static int mwifiex_save_hidden_ssid_channels(struct mwifiex_private *priv, > } > > done: > + /* beacon_ie buffer was allocated in function > + * mwifiex_fill_new_bss_desc(). Free it now. > + */ > + kfree(bss_desc->beacon_buf); For a bit, I thought this was possibly a sort of double-free, since mwifiex_fill_new_bss_desc() might actually fail to allocate ->beacon_buf, but kfree(NULL) is safe, so: Reviewed-by: Brian Norris <briannorris@chromium.org> > kfree(bss_desc); > return 0; > } > -- > 2.6.6 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web