Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1513977 > unrolled thread

[PATCH] coding-style: fix mismatch of jump label name

Back to article view | Back to linux.kernel

Contents

  [PATCH] coding-style: fix mismatch of jump label name Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-02 18:00 +0100
    Re: [PATCH] coding-style: fix mismatch of jump label name Jean Delvare <jdelvare@suse.de> - 2016-11-02 20:30 +0100
    Re: [PATCH] coding-style: fix mismatch of jump label name Jonathan Corbet <corbet@lwn.net> - 2016-11-08 03:10 +0100

#1513977 — [PATCH] coding-style: fix mismatch of jump label name

Commit 865a1caa4b6b ("CodingStyle: Clarify and complete chapter 7")
renamed the label "out_buffer" to "out_free_buffer", but missed to
change this line.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Note:
This patch is based on linux-next.
The Documentation/CodingStyle was moved to
Documentation/process/coding-style.rst

 Documentation/process/coding-style.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
index 968808be..3e79051 100644
--- a/Documentation/process/coding-style.rst
+++ b/Documentation/process/coding-style.rst
@@ -475,7 +475,7 @@ The rationale for using gotos is:
 				...
 			}
 			result = 1;
-			goto out_buffer;
+			goto out_free_buffer;
 		}
 		...
 	out_free_buffer:
-- 
1.9.1

[toc] | [next] | [standalone]

#1514093

Hi Masahiro-san,

On Thu,  3 Nov 2016 01:57:34 +0900, Masahiro Yamada wrote:
> Commit 865a1caa4b6b ("CodingStyle: Clarify and complete chapter 7")
> renamed the label "out_buffer" to "out_free_buffer", but missed to
> change this line.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
> Note:
> This patch is based on linux-next.
> The Documentation/CodingStyle was moved to
> Documentation/process/coding-style.rst
> 
>  Documentation/process/coding-style.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index 968808be..3e79051 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -475,7 +475,7 @@ The rationale for using gotos is:
>  				...
>  			}
>  			result = 1;
> -			goto out_buffer;
> +			goto out_free_buffer;
>  		}
>  		...
>  	out_free_buffer:

Oops, my bad. Good catch.

Reviewed-by: Jean Delvare <jdelvare@suse.de>

Feel free to add a Fixes: tag, although I doubt this kind of
documentation patch is often backported, so it probably doesn't really
matter.

Thanks,
-- 
Jean Delvare
SUSE L3 Support

[toc] | [prev] | [next] | [standalone]

#1516730

On Thu,  3 Nov 2016 01:57:34 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> Commit 865a1caa4b6b ("CodingStyle: Clarify and complete chapter 7")
> renamed the label "out_buffer" to "out_free_buffer", but missed to
> change this line.

Applied to the docs tree, thanks.

jon

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web