Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1516729 > unrolled thread

[PATCH] s390: remove unneeded dependency for gen_facilities

Started byMasahiro Yamada <yamada.masahiro@socionext.com>
First post2016-11-08 03:00 +0100
Last post2016-11-08 10:00 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] s390: remove unneeded dependency for gen_facilities Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-08 03:00 +0100
    Re: [PATCH] s390: remove unneeded dependency for gen_facilities Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-11-08 08:50 +0100
      Re: [PATCH] s390: remove unneeded dependency for gen_facilities Martin Schwidefsky <schwidefsky@de.ibm.com> - 2016-11-08 10:00 +0100

#1516729 — [PATCH] s390: remove unneeded dependency for gen_facilities

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-11-08 03:00 +0100
Subject[PATCH] s390: remove unneeded dependency for gen_facilities
Message-ID<sB3RE-2NH-13@gated-at.bofh.it>
The dependency between the object and the source is handled by
scripts/Makefile.host, so only "hostprogs-y += gen_facilities"
is fine.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/s390/tools/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
index 6d9814c..4b5e1e4 100644
--- a/arch/s390/tools/Makefile
+++ b/arch/s390/tools/Makefile
@@ -9,7 +9,5 @@ define filechk_facilities.h
 	$(obj)/gen_facilities
 endef
 
-$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c
-
 include/generated/facilities.h: $(obj)/gen_facilities FORCE
 	$(call filechk,facilities.h)
-- 
1.9.1

[toc] | [next] | [standalone]


#1516908

FromHeiko Carstens <heiko.carstens@de.ibm.com>
Date2016-11-08 08:50 +0100
Message-ID<sB9km-6qe-5@gated-at.bofh.it>
In reply to#1516729
On Tue, Nov 08, 2016 at 10:55:47AM +0900, Masahiro Yamada wrote:
> The dependency between the object and the source is handled by
> scripts/Makefile.host, so only "hostprogs-y += gen_facilities"
> is fine.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  arch/s390/tools/Makefile | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
> index 6d9814c..4b5e1e4 100644
> --- a/arch/s390/tools/Makefile
> +++ b/arch/s390/tools/Makefile
> @@ -9,7 +9,5 @@ define filechk_facilities.h
>  	$(obj)/gen_facilities
>  endef
>  
> -$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c
> -
>  include/generated/facilities.h: $(obj)/gen_facilities FORCE
>  	$(call filechk,facilities.h)

Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>

Martin, can you pick this one up too, please?

[toc] | [prev] | [next] | [standalone]


#1516969

FromMartin Schwidefsky <schwidefsky@de.ibm.com>
Date2016-11-08 10:00 +0100
Message-ID<sBaq6-76t-41@gated-at.bofh.it>
In reply to#1516908
On Tue, 8 Nov 2016 08:45:28 +0100
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> On Tue, Nov 08, 2016 at 10:55:47AM +0900, Masahiro Yamada wrote:
> > The dependency between the object and the source is handled by
> > scripts/Makefile.host, so only "hostprogs-y += gen_facilities"
> > is fine.
> > 
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> > 
> >  arch/s390/tools/Makefile | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
> > index 6d9814c..4b5e1e4 100644
> > --- a/arch/s390/tools/Makefile
> > +++ b/arch/s390/tools/Makefile
> > @@ -9,7 +9,5 @@ define filechk_facilities.h
> >  	$(obj)/gen_facilities
> >  endef
> >  
> > -$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c
> > -
> >  include/generated/facilities.h: $(obj)/gen_facilities FORCE
> >  	$(call filechk,facilities.h)
> 
> Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> 
> Martin, can you pick this one up too, please?

Done.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web