Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1515567 > unrolled thread

Re: [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk is NULL

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk  is NULL Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-05 16:50 +0100

#1515567 — Re: [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk is NULL

Hi Eric Miao, Haojian Zhuang,

Could you pick up this patch, please?


2016-09-19 2:58 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> In many of clk_disable() implementations, it is a no-op for a NULL
> pointer input, but this is one of the exceptions.
>
> Making it treewide consistent will allow clock consumers to call
> clk_disable() without NULL pointer check.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v4:
>   - Split into per-arch patches
>
> Changes in v3:
>   - Return only when clk is NULL.  Do not take care of error pointer.
>
> Changes in v2:
>   - Rebase on Linux 4.6-rc1
>
>  arch/arm/mach-mmp/clock.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-mmp/clock.c b/arch/arm/mach-mmp/clock.c
> index ac6633d..28fe64c 100644
> --- a/arch/arm/mach-mmp/clock.c
> +++ b/arch/arm/mach-mmp/clock.c
> @@ -67,6 +67,9 @@ void clk_disable(struct clk *clk)
>  {
>         unsigned long flags;
>
> +       if (!clk)
> +               return;
> +
>         WARN_ON(clk->enabled == 0);
>
>         spin_lock_irqsave(&clocks_lock, flags);
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



-- 
Best Regards
Masahiro Yamada

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web