Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1516278 > unrolled thread

[PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h>

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h> Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-07 17:10 +0100
    Re: [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of  <linux/types.h> Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-07 17:20 +0100

#1516278 — [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h>

Nothing in this header file depends on <linux/types.h>.
Rather, <linux/errno.h> should be included for -ENODEV.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

KernelVersion: 4.9-rc1


 arch/arm/include/asm/hardware/cache-uniphier.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/include/asm/hardware/cache-uniphier.h b/arch/arm/include/asm/hardware/cache-uniphier.h
index eaa60da..0ef42ae 100644
--- a/arch/arm/include/asm/hardware/cache-uniphier.h
+++ b/arch/arm/include/asm/hardware/cache-uniphier.h
@@ -16,7 +16,7 @@
 #ifndef __CACHE_UNIPHIER_H
 #define __CACHE_UNIPHIER_H
 
-#include <linux/types.h>
+#include <linux/errno.h>
 
 #ifdef CONFIG_CACHE_UNIPHIER
 int uniphier_cache_init(void);
-- 
1.9.1

[toc] | [next] | [standalone]

#1516284 — Re: [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h>

On Tue, Nov 08, 2016 at 12:58:54AM +0900, Masahiro Yamada wrote:
> Nothing in this header file depends on <linux/types.h>.
> Rather, <linux/errno.h> should be included for -ENODEV.

So how do we end up with a definition for u32?

I think you need both these include files.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web