Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1468619 > unrolled thread

[PATCH -next] staging: comedi: dt2811: fix non static symbol warnings

Back to article view | Back to linux.kernel

Contents

  [PATCH -next] staging: comedi: dt2811: fix non static symbol warnings Wei Yongjun <weiyj.lk@gmail.com> - 2016-08-23 17:10 +0200
    Re: [PATCH -next] staging: comedi: dt2811: fix non static symbol  warnings Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-08-23 19:10 +0200

#1468619 — [PATCH -next] staging: comedi: dt2811: fix non static symbol warnings

From: Wei Yongjun <weiyongjun1@huawei.com>

Fixes the following sparse warnings:

drivers/staging/comedi/drivers/dt2811.c:99:20: warning:
 symbol 'dt2811_clk_dividers' was not declared. Should it be static?
drivers/staging/comedi/drivers/dt2811.c:103:20: warning:
 symbol 'dt2811_clk_multipliers' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/staging/comedi/drivers/dt2811.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c
index 8bbd938..fcd8547 100644
--- a/drivers/staging/comedi/drivers/dt2811.c
+++ b/drivers/staging/comedi/drivers/dt2811.c
@@ -96,11 +96,11 @@
  *    6      6      100 kHz	 6   1000000
  *    7     12       50 kHz	 7   10000000
  */
-const unsigned int dt2811_clk_dividers[] = {
+static const unsigned int dt2811_clk_dividers[] = {
 	1, 10, 2, 3, 4, 5, 6, 12
 };
 
-const unsigned int dt2811_clk_multipliers[] = {
+static const unsigned int dt2811_clk_multipliers[] = {
 	1, 10, 100, 1000, 10000, 100000, 1000000, 10000000
 };
 

[toc] | [next] | [standalone]

#1468719 — Re: [PATCH -next] staging: comedi: dt2811: fix non static symbol warnings

On Tue, Aug 23, 2016 at 03:02:21PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
<snip>
>  drivers/staging/comedi/drivers/dt2811.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c
> index 8bbd938..fcd8547 100644
> --- a/drivers/staging/comedi/drivers/dt2811.c
> +++ b/drivers/staging/comedi/drivers/dt2811.c
> @@ -96,11 +96,11 @@
>   *    6      6      100 kHz	 6   1000000
>   *    7     12       50 kHz	 7   10000000
>   */
> -const unsigned int dt2811_clk_dividers[] = {
> +static const unsigned int dt2811_clk_dividers[] = {
>  	1, 10, 2, 3, 4, 5, 6, 12
>  };
>  
> -const unsigned int dt2811_clk_multipliers[] = {
> +static const unsigned int dt2811_clk_multipliers[] = {
>  	1, 10, 100, 1000, 10000, 100000, 1000000, 10000000
>  };

This has already been done by:
49c9d6ad68ae ("staging: comedi/drivers: Fixed sparse warnings")

regards
sudip
>  
> 
> 
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web