Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1468426 > unrolled thread
| Started by | Milo Kim <woogyom.kim@gmail.com> |
|---|---|
| First post | 2016-08-23 11:20 +0200 |
| Last post | 2016-08-24 04:40 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/4] ARM: dts: exynos: Enable HDMI in Arndale Octa board Milo Kim <woogyom.kim@gmail.com> - 2016-08-23 11:20 +0200
[PATCH 4/4] gpu: drm: exynos_hdmi: Use consolidated function on binding PHY DT property Milo Kim <woogyom.kim@gmail.com> - 2016-08-23 11:20 +0200
Re: [PATCH 0/4] ARM: dts: exynos: Enable HDMI in Arndale Octa board Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-23 22:00 +0200
Re: [PATCH 0/4] ARM: dts: exynos: Enable HDMI in Arndale Octa board Milo Kim <woogyom.kim@gmail.com> - 2016-08-24 04:40 +0200
| From | Milo Kim <woogyom.kim@gmail.com> |
|---|---|
| Date | 2016-08-23 11:20 +0200 |
| Subject | [PATCH 0/4] ARM: dts: exynos: Enable HDMI in Arndale Octa board |
| Message-ID | <s9g2e-1UK-3@gated-at.bofh.it> |
This patch-set enables HDMI in Arndale Octa board and fixes HPD DT property.
It also includes code refactoring on ddc and phy.
Milo Kim (4):
ARM: dts: exynos: Enable HDMI for Arndale Octa board
ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio'
gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT
property
gpu: drm: exynos_hdmi: Use consolidated function on binding PHY DT
property
.../bindings/display/exynos/exynos_hdmi.txt | 4 +--
arch/arm/boot/dts/exynos4210-universal_c210.dts | 2 +-
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 +-
arch/arm/boot/dts/exynos5250-arndale.dts | 2 +-
arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 +-
arch/arm/boot/dts/exynos5250-snow-common.dtsi | 2 +-
arch/arm/boot/dts/exynos5250-spring.dts | 2 +-
arch/arm/boot/dts/exynos5420-arndale-octa.dts | 17 +++++++++
arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +-
arch/arm/boot/dts/exynos5420-smdk5420.dts | 2 +-
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +-
arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 41 ++++++++++++----------
13 files changed, 52 insertions(+), 30 deletions(-)
--
1.9.1
[toc] | [next] | [standalone]
| From | Milo Kim <woogyom.kim@gmail.com> |
|---|---|
| Date | 2016-08-23 11:20 +0200 |
| Subject | [PATCH 4/4] gpu: drm: exynos_hdmi: Use consolidated function on binding PHY DT property |
| Message-ID | <s9g2e-1UK-35@gated-at.bofh.it> |
| In reply to | #1468426 |
Handle legacy and raw 'phy' parsing in single function.
And it also removes goto condition.
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 6a636f2..bb2d6d4 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -1778,11 +1778,22 @@ static struct device_node *hdmi_ddc_dt_binding(struct device *dev)
return np;
}
-static struct device_node *hdmi_legacy_phy_dt_binding(struct device *dev)
+static struct device_node *hdmi_phy_dt_binding(struct device *dev)
{
const char *compatible_str = "samsung,exynos4212-hdmiphy";
+ struct device_node *np;
+
+ np = of_find_compatible_node(NULL, NULL, compatible_str);
+ if (np)
+ return np;
+
+ np = of_parse_phandle(dev->of_node, "phy", 0);
+ if (!np)
+ return NULL;
+
+ of_node_put(dev->of_node);
- return of_find_compatible_node(NULL, NULL, compatible_str);
+ return np;
}
static int hdmi_probe(struct platform_device *pdev)
@@ -1829,19 +1840,13 @@ static int hdmi_probe(struct platform_device *pdev)
return -EPROBE_DEFER;
}
- phy_node = hdmi_legacy_phy_dt_binding(dev);
- if (phy_node)
- goto out_get_phy_port;
-
- phy_node = of_parse_phandle(dev->of_node, "phy", 0);
+ phy_node = hdmi_phy_dt_binding(dev);
if (!phy_node) {
DRM_ERROR("Failed to find hdmiphy node in device tree\n");
ret = -ENODEV;
goto err_ddc;
}
- of_node_put(dev->of_node);
-out_get_phy_port:
if (hdata->drv_data->is_apb_phy) {
hdata->regs_hdmiphy = of_iomap(phy_node, 0);
if (!hdata->regs_hdmiphy) {
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2016-08-23 22:00 +0200 |
| Message-ID | <s9q1A-8u4-35@gated-at.bofh.it> |
| In reply to | #1468426 |
On Tue, Aug 23, 2016 at 11:13 AM, Milo Kim <woogyom.kim@gmail.com> wrote: > This patch-set enables HDMI in Arndale Octa board and fixes HPD DT property. > It also includes code refactoring on ddc and phy. > > Milo Kim (4): > ARM: dts: exynos: Enable HDMI for Arndale Octa board > ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio' > gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT > property > gpu: drm: exynos_hdmi: Use consolidated function on binding PHY DT > property I saw DTS patches on linux-samsung-soc patchwork but still I would appreciate if you send them to appropriate maintainers pointed by get_maintainers.pl script. DTS stuff goes through samsung-soc tree. Best regards, Krzysztof
[toc] | [prev] | [next] | [standalone]
| From | Milo Kim <woogyom.kim@gmail.com> |
|---|---|
| Date | 2016-08-24 04:40 +0200 |
| Message-ID | <s9wgF-4mF-1@gated-at.bofh.it> |
| In reply to | #1468804 |
On 08/24/2016 04:55 AM, Krzysztof Kozlowski wrote: > I saw DTS patches on linux-samsung-soc patchwork but still I would > appreciate if you send them to appropriate maintainers pointed by > get_maintainers.pl script. DTS stuff goes through samsung-soc tree. Thanks for your tip. I've just sent out the v2. Best regards, Milo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web