Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467923 > unrolled thread

[PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h

Started byMikko Rapeli <mikko.rapeli@iki.fi>
First post2016-08-22 20:50 +0200
Last post2016-08-23 11:00 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2016-08-22 20:50 +0200
    Re: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include  linux/time.h kbuild test robot <lkp@intel.com> - 2016-08-22 23:40 +0200
    Re: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include  linux/time.h kbuild test robot <lkp@intel.com> - 2016-08-23 00:10 +0200
    Re: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include  linux/time.h kbuild test robot <lkp@intel.com> - 2016-08-23 01:30 +0200
      Re: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include  linux/time.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2016-08-23 11:00 +0200

#1467923 — [PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h

FromMikko Rapeli <mikko.rapeli@iki.fi>
Date2016-08-22 20:50 +0200
Subject[PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h
Message-ID<s92sh-1v9-13@gated-at.bofh.it>
Fixes userspace compilation error:

error: array type has incomplete element type
 struct timespec ts[3];

Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi>
---
 include/uapi/linux/errqueue.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/errqueue.h b/include/uapi/linux/errqueue.h
index 07bdce1..6b1cdc6 100644
--- a/include/uapi/linux/errqueue.h
+++ b/include/uapi/linux/errqueue.h
@@ -2,6 +2,7 @@
 #define _UAPI_LINUX_ERRQUEUE_H
 
 #include <linux/types.h>
+#include <linux/time.h>
 
 struct sock_extended_err {
 	__u32	ee_errno;	
-- 
2.8.1

[toc] | [next] | [standalone]

#1468078 — Re: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h

Fromkbuild test robot <lkp@intel.com>
Date2016-08-22 23:40 +0200
SubjectRe: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h
Message-ID<s956O-3hg-17@gated-at.bofh.it>
In reply to#1467923

[Multipart message — attachments visible in raw view] — view raw

Hi Mikko,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.8-rc3 next-20160822]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Mikko-Rapeli/Userspace-compile-test-and-fixes-for-exported-uapi-header-files/20160823-034928
config: i386-tinyconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the linux-review/Mikko-Rapeli/Userspace-compile-test-and-fixes-for-exported-uapi-header-files/20160823-034928 HEAD ab90ab906304d4f306e440f4dbfa334720093b4f builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/timestamping.c:46:
>> ./usr/include/linux/time.h:9:8: error: redefinition of 'struct timespec'
    struct timespec {
           ^~~~~~~~
   In file included from /usr/include/x86_64-linux-gnu/sys/select.h:43:0,
                    from /usr/include/x86_64-linux-gnu/sys/types.h:219,
                    from /usr/include/stdlib.h:314,
                    from Documentation/networking/timestamping/timestamping.c:33:
   /usr/include/time.h:120:8: note: originally defined here
    struct timespec
           ^~~~~~~~
   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/timestamping.c:46:
>> ./usr/include/linux/time.h:15:8: error: redefinition of 'struct timeval'
    struct timeval {
           ^~~~~~~
   In file included from /usr/include/x86_64-linux-gnu/sys/select.h:45:0,
                    from /usr/include/x86_64-linux-gnu/sys/types.h:219,
                    from /usr/include/stdlib.h:314,
                    from Documentation/networking/timestamping/timestamping.c:33:
   /usr/include/x86_64-linux-gnu/bits/time.h:30:8: note: originally defined here
    struct timeval
           ^~~~~~~
   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/timestamping.c:46:
>> ./usr/include/linux/time.h:20:8: error: redefinition of 'struct timezone'
    struct timezone {
           ^~~~~~~~
   In file included from Documentation/networking/timestamping/timestamping.c:37:0:
   /usr/include/x86_64-linux-gnu/sys/time.h:55:8: note: originally defined here
    struct timezone
           ^~~~~~~~
   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/timestamping.c:46:
>> ./usr/include/linux/time.h:30:0: warning: "ITIMER_REAL" redefined
    #define ITIMER_REAL  0
    
   In file included from Documentation/networking/timestamping/timestamping.c:37:0:
   /usr/include/x86_64-linux-gnu/sys/time.h:95:0: note: this is the location of the previous definition
    #define ITIMER_REAL ITIMER_REAL
    
   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/timestamping.c:46:
>> ./usr/include/linux/time.h:31:0: warning: "ITIMER_VIRTUAL" redefined
    #define ITIMER_VIRTUAL  1
    
   In file included from Documentation/networking/timestamping/timestamping.c:37:0:
   /usr/include/x86_64-linux-gnu/sys/time.h:98:0: note: this is the location of the previous definition
    #define ITIMER_VIRTUAL ITIMER_VIRTUAL
    
   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/timestamping.c:46:
>> ./usr/include/linux/time.h:32:0: warning: "ITIMER_PROF" redefined
    #define ITIMER_PROF  2
    
   In file included from Documentation/networking/timestamping/timestamping.c:37:0:
   /usr/include/x86_64-linux-gnu/sys/time.h:102:0: note: this is the location of the previous definition
    #define ITIMER_PROF ITIMER_PROF
    
   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/timestamping.c:46:
>> ./usr/include/linux/time.h:39:8: error: redefinition of 'struct itimerval'
    struct itimerval {
           ^~~~~~~~~
   In file included from Documentation/networking/timestamping/timestamping.c:37:0:
   /usr/include/x86_64-linux-gnu/sys/time.h:107:8: note: originally defined here
    struct itimerval
           ^~~~~~~~~
   Documentation/networking/timestamping/timestamping.c: In function 'sendpacket':
>> Documentation/networking/timestamping/timestamping.c:144:15: warning: passing argument 1 of 'gettimeofday' from incompatible pointer type [-Wincompatible-pointer-types]
     gettimeofday(&now, 0);
                  ^
   In file included from Documentation/networking/timestamping/timestamping.c:37:0:
   /usr/include/x86_64-linux-gnu/sys/time.h:71:12: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
    extern int gettimeofday (struct timeval *__restrict __tv,
               ^~~~~~~~~~~~
   Documentation/networking/timestamping/timestamping.c: In function 'printpacket':
   Documentation/networking/timestamping/timestamping.c:164:15: warning: passing argument 1 of 'gettimeofday' from incompatible pointer type [-Wincompatible-pointer-types]
     gettimeofday(&now, 0);
                  ^
   In file included from Documentation/networking/timestamping/timestamping.c:37:0:
   /usr/include/x86_64-linux-gnu/sys/time.h:71:12: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
    extern int gettimeofday (struct timeval *__restrict __tv,
               ^~~~~~~~~~~~
   Documentation/networking/timestamping/timestamping.c: In function 'main':
   Documentation/networking/timestamping/timestamping.c:474:15: warning: passing argument 1 of 'gettimeofday' from incompatible pointer type [-Wincompatible-pointer-types]
     gettimeofday(&next, 0);
                  ^
   In file included from Documentation/networking/timestamping/timestamping.c:37:0:
   /usr/include/x86_64-linux-gnu/sys/time.h:71:12: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
    extern int gettimeofday (struct timeval *__restrict __tv,
               ^~~~~~~~~~~~
   Documentation/networking/timestamping/timestamping.c:484:16: warning: passing argument 1 of 'gettimeofday' from incompatible pointer type [-Wincompatible-pointer-types]
      gettimeofday(&now, 0);
                   ^
   In file included from Documentation/networking/timestamping/timestamping.c:37:0:
   /usr/include/x86_64-linux-gnu/sys/time.h:71:12: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
    extern int gettimeofday (struct timeval *__restrict __tv,
               ^~~~~~~~~~~~
>> Documentation/networking/timestamping/timestamping.c:499:49: warning: passing argument 5 of 'select' from incompatible pointer type [-Wincompatible-pointer-types]
       res = select(sock + 1, &readfs, 0, &errorfs, &delta);
                                                    ^
   In file included from /usr/include/x86_64-linux-gnu/sys/types.h:219:0,
                    from /usr/include/stdlib.h:314,
                    from Documentation/networking/timestamping/timestamping.c:33:
   /usr/include/x86_64-linux-gnu/sys/select.h:106:12: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
    extern int select (int __nfds, fd_set *__restrict __readfds,
               ^~~~~~
   Documentation/networking/timestamping/timestamping.c:500:17: warning: passing argument 1 of 'gettimeofday' from incompatible pointer type [-Wincompatible-pointer-types]
       gettimeofday(&now, 0);
                    ^
   In file included from Documentation/networking/timestamping/timestamping.c:37:0:
   /usr/include/x86_64-linux-gnu/sys/time.h:71:12: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
    extern int gettimeofday (struct timeval *__restrict __tv,
               ^~~~~~~~~~~~

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1468100 — Re: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h

Fromkbuild test robot <lkp@intel.com>
Date2016-08-23 00:10 +0200
SubjectRe: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h
Message-ID<s95zQ-3HK-69@gated-at.bofh.it>
In reply to#1467923

[Multipart message — attachments visible in raw view] — view raw

Hi Mikko,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.8-rc3 next-20160822]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Mikko-Rapeli/Userspace-compile-test-and-fixes-for-exported-uapi-header-files/20160823-034928
config: i386-tinyconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the linux-review/Mikko-Rapeli/Userspace-compile-test-and-fixes-for-exported-uapi-header-files/20160823-034928 HEAD ab90ab906304d4f306e440f4dbfa334720093b4f builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/txtimestamp.c:40:
   ./usr/include/linux/time.h:9:8: error: redefinition of 'struct timespec'
    struct timespec {
           ^~~~~~~~
   In file included from /usr/include/x86_64-linux-gnu/sys/select.h:43:0,
                    from /usr/include/x86_64-linux-gnu/sys/types.h:219,
                    from /usr/include/x86_64-linux-gnu/sys/uio.h:23,
                    from /usr/include/x86_64-linux-gnu/sys/socket.h:26,
                    from /usr/include/netinet/in.h:23,
                    from /usr/include/arpa/inet.h:22,
                    from Documentation/networking/timestamping/txtimestamp.c:35:
   /usr/include/time.h:120:8: note: originally defined here
    struct timespec
           ^~~~~~~~
   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/txtimestamp.c:40:
   ./usr/include/linux/time.h:15:8: error: redefinition of 'struct timeval'
    struct timeval {
           ^~~~~~~
   In file included from /usr/include/x86_64-linux-gnu/sys/select.h:45:0,
                    from /usr/include/x86_64-linux-gnu/sys/types.h:219,
                    from /usr/include/x86_64-linux-gnu/sys/uio.h:23,
                    from /usr/include/x86_64-linux-gnu/sys/socket.h:26,
                    from /usr/include/netinet/in.h:23,
                    from /usr/include/arpa/inet.h:22,
                    from Documentation/networking/timestamping/txtimestamp.c:35:
   /usr/include/x86_64-linux-gnu/bits/time.h:30:8: note: originally defined here
    struct timeval
           ^~~~~~~
   In file included from Documentation/networking/timestamping/txtimestamp.c:59:0:
>> /usr/include/x86_64-linux-gnu/sys/time.h:55:8: error: redefinition of 'struct timezone'
    struct timezone
           ^~~~~~~~
   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/txtimestamp.c:40:
   ./usr/include/linux/time.h:20:8: note: originally defined here
    struct timezone {
           ^~~~~~~~
>> ./usr/include/linux/time.h:30:22: error: expected identifier before numeric constant
    #define ITIMER_REAL  0
                         ^
   In file included from Documentation/networking/timestamping/txtimestamp.c:59:0:
>> /usr/include/x86_64-linux-gnu/sys/time.h:107:8: error: redefinition of 'struct itimerval'
    struct itimerval
           ^~~~~~~~~
   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/txtimestamp.c:40:
   ./usr/include/linux/time.h:39:8: note: originally defined here
    struct itimerval {
           ^~~~~~~~~
   In file included from Documentation/networking/timestamping/txtimestamp.c:61:0:
>> /usr/include/time.h:161:8: error: redefinition of 'struct itimerspec'
    struct itimerspec
           ^~~~~~~~~~
   In file included from ./usr/include/linux/errqueue.h:5:0,
                    from Documentation/networking/timestamping/txtimestamp.c:40:
   ./usr/include/linux/time.h:34:8: note: originally defined here
    struct itimerspec {
           ^~~~~~~~~~

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1468152 — Re: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h

Fromkbuild test robot <lkp@intel.com>
Date2016-08-23 01:30 +0200
SubjectRe: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h
Message-ID<s96Pf-4qY-3@gated-at.bofh.it>
In reply to#1467923

[Multipart message — attachments visible in raw view] — view raw

Hi Mikko,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.8-rc3 next-20160822]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Mikko-Rapeli/Userspace-compile-test-and-fixes-for-exported-uapi-header-files/20160823-034928
config: x86_64-randconfig-s2-08230509 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/Mikko-Rapeli/Userspace-compile-test-and-fixes-for-exported-uapi-header-files/20160823-034928 HEAD ab90ab906304d4f306e440f4dbfa334720093b4f builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

   In file included from ./usr/include/linux/errqueue.h:5,
                    from Documentation/networking/timestamping/timestamping.c:46:
   ./usr/include/linux/time.h:9: error: redefinition of 'struct timespec'
   ./usr/include/linux/time.h:15: error: redefinition of 'struct timeval'
   ./usr/include/linux/time.h:20: error: redefinition of 'struct timezone'
   In file included from ./usr/include/linux/errqueue.h:5,
                    from Documentation/networking/timestamping/timestamping.c:46:
   ./usr/include/linux/time.h:30:1: warning: "ITIMER_REAL" redefined
   In file included from Documentation/networking/timestamping/timestamping.c:37:
>> /usr/include/x86_64-linux-gnu/sys/time.h:95:1: warning: this is the location of the previous definition
   In file included from ./usr/include/linux/errqueue.h:5,
                    from Documentation/networking/timestamping/timestamping.c:46:
   ./usr/include/linux/time.h:31:1: warning: "ITIMER_VIRTUAL" redefined
   In file included from Documentation/networking/timestamping/timestamping.c:37:
   /usr/include/x86_64-linux-gnu/sys/time.h:98:1: warning: this is the location of the previous definition
   In file included from ./usr/include/linux/errqueue.h:5,
                    from Documentation/networking/timestamping/timestamping.c:46:
   ./usr/include/linux/time.h:32:1: warning: "ITIMER_PROF" redefined
   In file included from Documentation/networking/timestamping/timestamping.c:37:
   /usr/include/x86_64-linux-gnu/sys/time.h:102:1: warning: this is the location of the previous definition
   ./usr/include/linux/time.h:39: error: redefinition of 'struct itimerval'
   Documentation/networking/timestamping/timestamping.c: In function 'sendpacket':
   Documentation/networking/timestamping/timestamping.c:144: warning: passing argument 1 of 'gettimeofday' from incompatible pointer type
   /usr/include/x86_64-linux-gnu/sys/time.h:71: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
   Documentation/networking/timestamping/timestamping.c: In function 'printpacket':
   Documentation/networking/timestamping/timestamping.c:164: warning: passing argument 1 of 'gettimeofday' from incompatible pointer type
   /usr/include/x86_64-linux-gnu/sys/time.h:71: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
   Documentation/networking/timestamping/timestamping.c: In function 'main':
   Documentation/networking/timestamping/timestamping.c:474: warning: passing argument 1 of 'gettimeofday' from incompatible pointer type
   /usr/include/x86_64-linux-gnu/sys/time.h:71: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
   Documentation/networking/timestamping/timestamping.c:484: warning: passing argument 1 of 'gettimeofday' from incompatible pointer type
   /usr/include/x86_64-linux-gnu/sys/time.h:71: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
   Documentation/networking/timestamping/timestamping.c:499: warning: passing argument 5 of 'select' from incompatible pointer type
   /usr/include/x86_64-linux-gnu/sys/select.h:106: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
   Documentation/networking/timestamping/timestamping.c:500: warning: passing argument 1 of 'gettimeofday' from incompatible pointer type
   /usr/include/x86_64-linux-gnu/sys/time.h:71: note: expected 'struct timeval * __restrict__' but argument is of type 'struct timeval *'
--
   In file included from ./usr/include/linux/errqueue.h:5,
                    from Documentation/networking/timestamping/txtimestamp.c:40:
   ./usr/include/linux/time.h:9: error: redefinition of 'struct timespec'
   ./usr/include/linux/time.h:15: error: redefinition of 'struct timeval'
   In file included from Documentation/networking/timestamping/txtimestamp.c:59:
   /usr/include/x86_64-linux-gnu/sys/time.h:56: error: redefinition of 'struct timezone'
>> /usr/include/x86_64-linux-gnu/sys/time.h:94: error: expected identifier before numeric constant
   /usr/include/x86_64-linux-gnu/sys/time.h:108: error: redefinition of 'struct itimerval'
   In file included from Documentation/networking/timestamping/txtimestamp.c:61:
   /usr/include/time.h:162: error: redefinition of 'struct itimerspec'

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1468405 — Re: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h

FromMikko Rapeli <mikko.rapeli@iki.fi>
Date2016-08-23 11:00 +0200
SubjectRe: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h
Message-ID<s9fIS-1yv-55@gated-at.bofh.it>
In reply to#1468152
Thanks! It never occurred to me to test kernel documentation builds.
I will have a look now.

-Mikko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web