Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1468339 > unrolled thread
| Started by | dingxiang <dingxiang@huawei.com> |
|---|---|
| First post | 2016-08-23 09:30 +0200 |
| Last post | 2016-08-23 10:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] staging:xgifb:remove unused code dingxiang <dingxiang@huawei.com> - 2016-08-23 09:30 +0200
Re: [PATCH] staging:xgifb:remove unused code Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-08-23 10:10 +0200
| From | dingxiang <dingxiang@huawei.com> |
|---|---|
| Date | 2016-08-23 09:30 +0200 |
| Subject | [PATCH] staging:xgifb:remove unused code |
| Message-ID | <s9ejL-M9-5@gated-at.bofh.it> |
The variable data is assigned but never used in rest code. Signed-off-by: Ding Xiang <dingxiang@huawei.com> --- drivers/staging/xgifb/vb_setmode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index 50c8ea4..71bb9ca 100644 --- a/drivers/staging/xgifb/vb_setmode.c +++ b/drivers/staging/xgifb/vb_setmode.c @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex, tempax |= 0x40; xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax); - data = xgifb_reg_get(pVBInfo->P3d4, 0x07); tempax = 0; if (tempbx & 0x04) -- 2.5.0 .
[toc] | [next] | [standalone]
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2016-08-23 10:10 +0200 |
| Message-ID | <s9eWu-1gG-9@gated-at.bofh.it> |
| In reply to | #1468339 |
On Tue, Aug 23, 2016 at 03:26:50PM +0800, dingxiang wrote: > The variable data is assigned but never used in rest code. > > Signed-off-by: Ding Xiang <dingxiang@huawei.com> > --- Your name in Signed-off-by: and From: doesnot match. > drivers/staging/xgifb/vb_setmode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c > index 50c8ea4..71bb9ca 100644 > --- a/drivers/staging/xgifb/vb_setmode.c > +++ b/drivers/staging/xgifb/vb_setmode.c > @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex, > tempax |= 0x40; > xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax); > - data = xgifb_reg_get(pVBInfo->P3d4, 0x07); > tempax = 0; > if (tempbx & 0x04) The patch will not apply. Its missing two blank lines which the original code has. regards sudip
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web