Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1469615 > unrolled thread

[PATCH] phy: request shared IRQ

Back to article view | Back to linux.kernel

Contents

  [PATCH] phy: request shared IRQ Xander Huff <xander.huff@ni.com> - 2016-08-24 20:00 +0200
    Re: [PATCH] phy: request shared IRQ Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-24 20:50 +0200
      Re: [PATCH] phy: request shared IRQ Xander Huff <xander.huff@ni.com> - 2016-08-25 00:10 +0200
      [PATCH v2] Revert "phy: IRQ cannot be shared" Xander Huff <xander.huff@ni.com> - 2016-08-25 00:10 +0200
        Re: [PATCH v2] Revert "phy: IRQ cannot be shared" David Miller <davem@redhat.com> - 2016-08-26 02:20 +0200

#1469615 — [PATCH] phy: request shared IRQ

From: Nathan Sullivan <nathan.sullivan@ni.com>

On hardware with multiple PHY devices hooked up to the same IRQ line, allow
them to share it.

Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
Signed-off-by: Xander Huff <xander.huff@ni.com>
Acked-by: Ben Shelton <ben.shelton@ni.com>
Acked-by: Jaeden Amero <jaeden.amero@ni.com>
---
 drivers/net/phy/phy.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index c5dc2c36..0050531 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -722,8 +722,8 @@ phy_err:
 int phy_start_interrupts(struct phy_device *phydev)
 {
 	atomic_set(&phydev->irq_disable, 0);
-	if (request_irq(phydev->irq, phy_interrupt, 0, "phy_interrupt",
-			phydev) < 0) {
+	if (request_irq(phydev->irq, phy_interrupt, IRQF_SHARED,
+			"phy_interrupt", phydev) < 0) {
 		pr_warn("%s: Can't get IRQ %d (PHY)\n",
 			phydev->mdio.bus->name, phydev->irq);
 		phydev->irq = PHY_POLL;
-- 
1.9.1

[toc] | [next] | [standalone]

#1469643

Hello.

On 08/24/2016 08:53 PM, Xander Huff wrote:

> From: Nathan Sullivan <nathan.sullivan@ni.com>
>
> On hardware with multiple PHY devices hooked up to the same IRQ line, allow
> them to share it.

    Note that it had been allowed until my (erroneous?) commit 
33c133cc7598e60976a069344910d63e56cc4401 ("phy: IRQ cannot be shared"), so I'd 
like this commit just reverted instead...
    I'm not sure now what was the reason I concluded that the IRQ sharing was 
impossible... most probably I thought that the kernel IRQ handling code exited 
the loop over the IRQ actions once IRQ_HANDLED was returned -- which is 
obviously not so in reality...

> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> Signed-off-by: Xander Huff <xander.huff@ni.com>
> Acked-by: Ben Shelton <ben.shelton@ni.com>
> Acked-by: Jaeden Amero <jaeden.amero@ni.com>
[...]

MBR, Sergei

[toc] | [prev] | [next] | [standalone]

#1469758

On 8/24/2016 1:41 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 08/24/2016 08:53 PM, Xander Huff wrote:
>
>> From: Nathan Sullivan <nathan.sullivan@ni.com>
>>
>> On hardware with multiple PHY devices hooked up to the same IRQ line, allow
>> them to share it.
>
>     Note that it had been allowed until my (erroneous?) commit
> 33c133cc7598e60976a069344910d63e56cc4401 ("phy: IRQ cannot be shared"), so I'd
> like this commit just reverted instead...
>     I'm not sure now what was the reason I concluded that the IRQ sharing was
> impossible... most probably I thought that the kernel IRQ handling code exited
> the loop over the IRQ actions once IRQ_HANDLED was returned -- which is
> obviously not so in reality...
>
> MBR, Sergei
>
Thanks for the suggestion, Sergei. I'll do just that.

-- 
Xander Huff
Staff Software Engineer
National Instruments

[toc] | [prev] | [next] | [standalone]

#1469760 — [PATCH v2] Revert "phy: IRQ cannot be shared"

This reverts:
  commit 33c133cc7598 ("phy: IRQ cannot be shared")

On hardware with multiple PHY devices hooked up to the same IRQ line, allow
them to share it.

Sergei Shtylyov says:
  "I'm not sure now what was the reason I concluded that the IRQ sharing
  was impossible... most probably I thought that the kernel IRQ handling
  code exited the loop over the IRQ actions once IRQ_HANDLED was returned
  -- which is obviously not so in reality..."

Signed-off-by: Xander Huff <xander.huff@ni.com>
Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
---
Note: this reverted code fails "CHECK: Alignment should match open
parentesis"
---
 drivers/net/phy/phy.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index c5dc2c36..c6f6683 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -722,8 +722,10 @@ phy_err:
 int phy_start_interrupts(struct phy_device *phydev)
 {
 	atomic_set(&phydev->irq_disable, 0);
-	if (request_irq(phydev->irq, phy_interrupt, 0, "phy_interrupt",
-			phydev) < 0) {
+	if (request_irq(phydev->irq, phy_interrupt,
+				IRQF_SHARED,
+				"phy_interrupt",
+				phydev) < 0) {
 		pr_warn("%s: Can't get IRQ %d (PHY)\n",
 			phydev->mdio.bus->name, phydev->irq);
 		phydev->irq = PHY_POLL;
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1470490 — Re: [PATCH v2] Revert "phy: IRQ cannot be shared"

From: Xander Huff <xander.huff@ni.com>
Date: Wed, 24 Aug 2016 16:47:53 -0500

> This reverts:
>   commit 33c133cc7598 ("phy: IRQ cannot be shared")
> 
> On hardware with multiple PHY devices hooked up to the same IRQ line, allow
> them to share it.
> 
> Sergei Shtylyov says:
>   "I'm not sure now what was the reason I concluded that the IRQ sharing
>   was impossible... most probably I thought that the kernel IRQ handling
>   code exited the loop over the IRQ actions once IRQ_HANDLED was returned
>   -- which is obviously not so in reality..."
> 
> Signed-off-by: Xander Huff <xander.huff@ni.com>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> ---
> Note: this reverted code fails "CHECK: Alignment should match open
> parentesis"

That's fine, we can fix up the indentation later.

Applied and queued up for -stable, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web