Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1469560 > unrolled thread

Re: [PATCH v2 0/6] Intel Integrated Sensor Hub Support (ISH)

Started byGrant Likely <glikely@secretlab.ca>
First post2016-08-24 18:20 +0200
Last post2016-08-31 16:40 +0200
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 0/6] Intel Integrated Sensor Hub Support (ISH) Grant Likely <glikely@secretlab.ca> - 2016-08-24 18:20 +0200
    Re: [PATCH v2 0/6] Intel Integrated Sensor Hub Support (ISH) Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-08-24 20:50 +0200
    Re: [PATCH v2 0/6] Intel Integrated Sensor Hub Support (ISH) Jiri Kosina <jikos@kernel.org> - 2016-08-24 23:20 +0200
      Re: [PATCH v2 0/6] Intel Integrated Sensor Hub Support (ISH) Jonathan Cameron <jic23@kernel.org> - 2016-08-24 23:30 +0200
        Re: [PATCH v2 0/6] Intel Integrated Sensor Hub Support (ISH) Grant Likely <glikely@secretlab.ca> - 2016-08-31 16:30 +0200
          Re: [PATCH v2 0/6] Intel Integrated Sensor Hub Support (ISH) Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-08-31 16:40 +0200

#1469560 — Re: [PATCH v2 0/6] Intel Integrated Sensor Hub Support (ISH)

FromGrant Likely <glikely@secretlab.ca>
Date2016-08-24 18:20 +0200
SubjectRe: [PATCH v2 0/6] Intel Integrated Sensor Hub Support (ISH)
Message-ID<s9J4d-4GN-7@gated-at.bofh.it>
On Tue, Jul 5, 2016 at 8:42 AM, Grant Likely <glikely@secretlab.ca> wrote:
>
> On 22/06/16 06:40, Srinivas Pandruvada wrote:
>>
>> Change log
>> v2:
>> - Overview in documentation show analogy with usbhid implementation
>> - sparse errors for statics. Also pointed by Jiri
>> - Clearly marking exported function header file. Clean up all exports
>> unused inteface functions
>> - Changed to tristate from boolean as pointed by Jiri:
>> this required remove/unload functions
>> - Prevent crash when ISH enabled on non supported platform
>> - Break client.c to smaller part by seprating buffer allocations
>> - move bus register/unregister to ishtp module
>> - There is only one config symbol INTEL_ISH_HID, removed silent
>> config for TRANSPORT and IPC
>
> Tested-by: Grant Likely <grant.likely@secretlab.ca>
>
> On an HP Spectre x360 laptop using v4.7-rc5.

Hey Srinivas. Any progress on this patch series?

g.

[toc] | [next] | [standalone]

#1469639

FromSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date2016-08-24 20:50 +0200
Message-ID<s9Lpn-69M-3@gated-at.bofh.it>
In reply to#1469560
On Wed, 2016-08-24 at 12:16 -0400, Grant Likely wrote:
> On Tue, Jul 5, 2016 at 8:42 AM, Grant Likely <glikely@secretlab.ca>
> wrote:
> > 
> > 
> > On 22/06/16 06:40, Srinivas Pandruvada wrote:
> > > 
> > > 
> > > Change log
> > > v2:
> > > - Overview in documentation show analogy with usbhid
> > > implementation
> > > - sparse errors for statics. Also pointed by Jiri
> > > - Clearly marking exported function header file. Clean up all
> > > exports
> > > unused inteface functions
> > > - Changed to tristate from boolean as pointed by Jiri:
> > > this required remove/unload functions
> > > - Prevent crash when ISH enabled on non supported platform
> > > - Break client.c to smaller part by seprating buffer allocations
> > > - move bus register/unregister to ishtp module
> > > - There is only one config symbol INTEL_ISH_HID, removed silent
> > > config for TRANSPORT and IPC
> > 
> > Tested-by: Grant Likely <grant.likely@secretlab.ca>
> > 
> > On an HP Spectre x360 laptop using v4.7-rc5.
> 
> Hey Srinivas. Any progress on this patch series?
Unless someone has major objection, they can land up in 4.9.
They will go through two different trees, I can ping you once I see all
patches in linux-next.

Thanks,
Srinivas


> 
> g.

[toc] | [prev] | [next] | [standalone]

#1469724

FromJiri Kosina <jikos@kernel.org>
Date2016-08-24 23:20 +0200
Message-ID<s9NKx-7XX-3@gated-at.bofh.it>
In reply to#1469560
On Wed, 24 Aug 2016, Grant Likely wrote:

> >> v2:
> >> - Overview in documentation show analogy with usbhid implementation
> >> - sparse errors for statics. Also pointed by Jiri
> >> - Clearly marking exported function header file. Clean up all exports
> >> unused inteface functions
> >> - Changed to tristate from boolean as pointed by Jiri:
> >> this required remove/unload functions
> >> - Prevent crash when ISH enabled on non supported platform
> >> - Break client.c to smaller part by seprating buffer allocations
> >> - move bus register/unregister to ishtp module
> >> - There is only one config symbol INTEL_ISH_HID, removed silent
> >> config for TRANSPORT and IPC
> >
> > Tested-by: Grant Likely <grant.likely@secretlab.ca>
> >
> > On an HP Spectre x360 laptop using v4.7-rc5.
> 
> Hey Srinivas. Any progress on this patch series?

The HID part (with patch #5 omitted) should be in linux-next through 
hid.git already.

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1469733

FromJonathan Cameron <jic23@kernel.org>
Date2016-08-24 23:30 +0200
Message-ID<s9NUe-81K-5@gated-at.bofh.it>
In reply to#1469724
On 24/08/16 22:14, Jiri Kosina wrote:
> On Wed, 24 Aug 2016, Grant Likely wrote:
> 
>>>> v2:
>>>> - Overview in documentation show analogy with usbhid implementation
>>>> - sparse errors for statics. Also pointed by Jiri
>>>> - Clearly marking exported function header file. Clean up all exports
>>>> unused inteface functions
>>>> - Changed to tristate from boolean as pointed by Jiri:
>>>> this required remove/unload functions
>>>> - Prevent crash when ISH enabled on non supported platform
>>>> - Break client.c to smaller part by seprating buffer allocations
>>>> - move bus register/unregister to ishtp module
>>>> - There is only one config symbol INTEL_ISH_HID, removed silent
>>>> config for TRANSPORT and IPC
>>>
>>> Tested-by: Grant Likely <grant.likely@secretlab.ca>
>>>
>>> On an HP Spectre x360 laptop using v4.7-rc5.
>>
>> Hey Srinivas. Any progress on this patch series?
> 
> The HID part (with patch #5 omitted) should be in linux-next through 
> hid.git already.
> 
The one IIO patch was pulled by Greg KH last night so hit linux next
today.  Hence all on it's way by the sound of it!

Jonathan

[toc] | [prev] | [next] | [standalone]

#1473532

FromGrant Likely <glikely@secretlab.ca>
Date2016-08-31 16:30 +0200
Message-ID<sceGC-3xO-39@gated-at.bofh.it>
In reply to#1469733
On Wed, Aug 24, 2016 at 10:23 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 24/08/16 22:14, Jiri Kosina wrote:
>> On Wed, 24 Aug 2016, Grant Likely wrote:
>>
>>>>> v2:
>>>>> - Overview in documentation show analogy with usbhid implementation
>>>>> - sparse errors for statics. Also pointed by Jiri
>>>>> - Clearly marking exported function header file. Clean up all exports
>>>>> unused inteface functions
>>>>> - Changed to tristate from boolean as pointed by Jiri:
>>>>> this required remove/unload functions
>>>>> - Prevent crash when ISH enabled on non supported platform
>>>>> - Break client.c to smaller part by seprating buffer allocations
>>>>> - move bus register/unregister to ishtp module
>>>>> - There is only one config symbol INTEL_ISH_HID, removed silent
>>>>> config for TRANSPORT and IPC
>>>>
>>>> Tested-by: Grant Likely <grant.likely@secretlab.ca>
>>>>
>>>> On an HP Spectre x360 laptop using v4.7-rc5.
>>>
>>> Hey Srinivas. Any progress on this patch series?
>>
>> The HID part (with patch #5 omitted) should be in linux-next through
>> hid.git already.
>>
> The one IIO patch was pulled by Greg KH last night so hit linux next
> today.  Hence all on it's way by the sound of it!

Nice!

Unfortunately, I've just hit a new bug after updating to v4.8-rc4.
4.7.0-rc6 works fine.

The kernel boots, and the driver loads, but the orientations are
wrong. It appears that the X/Y is getting swapped:

Normal orientation: display rotated 90 degrees CW
Rotated 90 degrees CW: display normal orientation
Rotated 180 degrees (upside down): display rotated 90 degrees CCW
Rotated 90 degrees CCW: display rotated 180 degrees

Cheers,
g.

[toc] | [prev] | [next] | [standalone]

#1473556

FromSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date2016-08-31 16:40 +0200
Message-ID<sceQi-3B0-41@gated-at.bofh.it>
In reply to#1473532
On Wed, 2016-08-31 at 15:19 +0100, Grant Likely wrote:
> On Wed, Aug 24, 2016 at 10:23 PM, Jonathan Cameron <jic23@kernel.org>
> wrote:
> > 
> > On 24/08/16 22:14, Jiri Kosina wrote:
> > > 
> > > On Wed, 24 Aug 2016, Grant Likely wrote:
> > > 
> > > > 
> > > > > 
> > > > > > 
> > > > > > v2:
> > > > > > - Overview in documentation show analogy with usbhid
> > > > > > implementation
> > > > > > - sparse errors for statics. Also pointed by Jiri
> > > > > > - Clearly marking exported function header file. Clean up
> > > > > > all exports
> > > > > > unused inteface functions
> > > > > > - Changed to tristate from boolean as pointed by Jiri:
> > > > > > this required remove/unload functions
> > > > > > - Prevent crash when ISH enabled on non supported platform
> > > > > > - Break client.c to smaller part by seprating buffer
> > > > > > allocations
> > > > > > - move bus register/unregister to ishtp module
> > > > > > - There is only one config symbol INTEL_ISH_HID, removed
> > > > > > silent
> > > > > > config for TRANSPORT and IPC
> > > > > Tested-by: Grant Likely <grant.likely@secretlab.ca>
> > > > > 
> > > > > On an HP Spectre x360 laptop using v4.7-rc5.
> > > > Hey Srinivas. Any progress on this patch series?
> > > The HID part (with patch #5 omitted) should be in linux-next
> > > through
> > > hid.git already.
> > > 
> > The one IIO patch was pulled by Greg KH last night so hit linux
> > next
> > today.  Hence all on it's way by the sound of it!
> Nice!
> 
> Unfortunately, I've just hit a new bug after updating to v4.8-rc4.
> 4.7.0-rc6 works fine.
> 
> The kernel boots, and the driver loads, but the orientations are
> wrong. It appears that the X/Y is getting swapped:
> 
> Normal orientation: display rotated 90 degrees CW
> Rotated 90 degrees CW: display normal orientation
> Rotated 180 degrees (upside down): display rotated 90 degrees CCW
> Rotated 90 degrees CCW: display rotated 180 degrees
> 
This is  also observed in all non ISH platforms too. I bisected it to
some commit, which I don't know how this impacts. Yesterday I sent
email to the list. Try reverting this, you should be fine.

 commit 703b5faf22fbddf984a361e6555f3a03fdba63d9
> Author: George Spelvin <linux@sciencehorizons.net>
> Date:   Fri Jun 10 00:22:12 2016 -0400
>
>     fs/dcache.c: Save one 32-bit multiply in dcache lookup
>
>     Noe that we're mixing in the parent pointer earlier, we
>     don't need to use hash_32() to mix its bits.  Instead, we can
>     just take the msbits of the hash value directly.
>
>     For those applications which use the partial_name_hash(),
>     move the multiply to end_name_hash.
>
>     Signed-off-by: George Spelvin <linux@sciencehorizons.net>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>


Thanks,
Srinivas


> Cheers,
> g.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web