Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1469451 > unrolled thread

[PATCH] arm64: dts: hikey: extend default cma size to 128MB

Started byGuodong Xu <guodong.xu@linaro.org>
First post2016-08-24 15:40 +0200
Last post2016-08-25 07:10 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] arm64: dts: hikey: extend default cma size to 128MB Guodong Xu <guodong.xu@linaro.org> - 2016-08-24 15:40 +0200
    Re: [PATCH] arm64: dts: hikey: extend default cma size to 128MB Rob Herring <robh+dt@kernel.org> - 2016-08-24 17:30 +0200
      Re: [PATCH] arm64: dts: hikey: extend default cma size to 128MB Guodong Xu <guodong.xu@linaro.org> - 2016-08-25 07:10 +0200

#1469451 — [PATCH] arm64: dts: hikey: extend default cma size to 128MB

FromGuodong Xu <guodong.xu@linaro.org>
Date2016-08-24 15:40 +0200
Subject[PATCH] arm64: dts: hikey: extend default cma size to 128MB
Message-ID<s9Gzo-2Q5-39@gated-at.bofh.it>
To support display in Debian on HiKey, cma heap is used to allocate
graphic buffers. The default size of CMA is 16 MB which is not enought.

Increase the default CMA size to 128 MB.

cc: Rob Herring <rob.herring@linaro.org>
cc: Fathi Boudra <fathi.boudra@linaro.org>
cc: John Stultz <john.stultz@linaro.org>
cc: Xinliang Liu <xinliang.liu@linaro.org>
Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
---
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index 4a51058..abb3434 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -45,6 +45,20 @@
 		      <0x00000000 0x22000000 0x00000000 0x1c000000>;
 	};
 
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		/* global autoconfigured region for contiguous allocations */
+		linux,cma {
+			compatible = "shared-dma-pool";
+			reusable;
+			size = <0x00000000 0x08000000>;
+			linux,cma-default;
+		};
+	};
+
 	pstore: pstore@0x21f00000 {
 		no-map;
 		reg = <0x0 0x21f00000 0x0 0x00100000>;  /* pstore/ramoops buffer */
-- 
1.9.1

[toc] | [next] | [standalone]


#1469540

FromRob Herring <robh+dt@kernel.org>
Date2016-08-24 17:30 +0200
Message-ID<s9IhP-46G-15@gated-at.bofh.it>
In reply to#1469451
On Wed, Aug 24, 2016 at 8:35 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
> To support display in Debian on HiKey, cma heap is used to allocate
> graphic buffers. The default size of CMA is 16 MB which is not enought.

s/enought/enough/

>
> Increase the default CMA size to 128 MB.
>
> cc: Rob Herring <rob.herring@linaro.org>
> cc: Fathi Boudra <fathi.boudra@linaro.org>
> cc: John Stultz <john.stultz@linaro.org>
> cc: Xinliang Liu <xinliang.liu@linaro.org>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index 4a51058..abb3434 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -45,6 +45,20 @@
>                       <0x00000000 0x22000000 0x00000000 0x1c000000>;
>         };
>
> +       reserved-memory {
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +               ranges;
> +
> +               /* global autoconfigured region for contiguous allocations */
> +               linux,cma {
> +                       compatible = "shared-dma-pool";
> +                       reusable;
> +                       size = <0x00000000 0x08000000>;
> +                       linux,cma-default;
> +               };
> +       };
> +
>         pstore: pstore@0x21f00000 {

So what is upstream (as of 4.8) for ramoops also uses reserved-memory,
so you should separately fix this.

Acked-by: Rob Herring <robh@kernel.org>

Rob

[toc] | [prev] | [next] | [standalone]


#1469830

FromGuodong Xu <guodong.xu@linaro.org>
Date2016-08-25 07:10 +0200
Message-ID<s9V5o-50Y-5@gated-at.bofh.it>
In reply to#1469540
On 24 August 2016 at 23:10, Rob Herring <robh+dt@kernel.org> wrote:
> On Wed, Aug 24, 2016 at 8:35 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
>> To support display in Debian on HiKey, cma heap is used to allocate
>> graphic buffers. The default size of CMA is 16 MB which is not enought.
>
> s/enought/enough/
>
>>
>> Increase the default CMA size to 128 MB.
>>
>> cc: Rob Herring <rob.herring@linaro.org>
>> cc: Fathi Boudra <fathi.boudra@linaro.org>
>> cc: John Stultz <john.stultz@linaro.org>
>> cc: Xinliang Liu <xinliang.liu@linaro.org>
>> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> index 4a51058..abb3434 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> @@ -45,6 +45,20 @@
>>                       <0x00000000 0x22000000 0x00000000 0x1c000000>;
>>         };
>>
>> +       reserved-memory {
>> +               #address-cells = <2>;
>> +               #size-cells = <2>;
>> +               ranges;
>> +
>> +               /* global autoconfigured region for contiguous allocations */
>> +               linux,cma {
>> +                       compatible = "shared-dma-pool";
>> +                       reusable;
>> +                       size = <0x00000000 0x08000000>;
>> +                       linux,cma-default;
>> +               };
>> +       };
>> +
>>         pstore: pstore@0x21f00000 {
>
> So what is upstream (as of 4.8) for ramoops also uses reserved-memory,
> so you should separately fix this.
>

Got it. I will fix and resend.

> Acked-by: Rob Herring <robh@kernel.org>
>

Thanks.
-Guodong


> Rob

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web