Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1469106 > unrolled thread

[PATCH 0/2] reset: uniphier: follow-up fix, clean-up

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] reset: uniphier: follow-up fix, clean-up Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-24 08:40 +0200
    [PATCH 1/2] reset: uniphier: add static qualifier to probe function Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-24 08:50 +0200
      Re: [PATCH 1/2] reset: uniphier: add static qualifier to probe  function Philipp Zabel <p.zabel@pengutronix.de> - 2016-08-24 14:30 +0200

#1469106 — [PATCH 0/2] reset: uniphier: follow-up fix, clean-up

Hi Philipp,

Here is two follow-up patches.
  - add missing static
  - use of_device_get_match_data() rather than of_match_node()
    for the probe clean-up

The initial commit of the driver is still on the top of
"reset/next" branch.

If possible, could you squash these two into the initial one?
Nobody would be bothered with this.



Masahiro Yamada (2):
  reset: uniphier: add static qualifier to probe function
  reset: uniphier: use of_device_get_match_data() to get matched data

 drivers/reset/reset-uniphier.c | 81 +++++++++++++++++++++---------------------
 1 file changed, 40 insertions(+), 41 deletions(-)

-- 
1.9.1

[toc] | [next] | [standalone]

#1469113 — [PATCH 1/2] reset: uniphier: add static qualifier to probe function

I missed this in the initial commit.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/reset/reset-uniphier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
index 9de071f..41c62af 100644
--- a/drivers/reset/reset-uniphier.c
+++ b/drivers/reset/reset-uniphier.c
@@ -385,7 +385,7 @@ static const struct of_device_id uniphier_reset_match[] = {
 };
 MODULE_DEVICE_TABLE(of, uniphier_reset_match);
 
-int uniphier_reset_probe(struct platform_device *pdev)
+static int uniphier_reset_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	const struct of_device_id *match;
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1469380 — Re: [PATCH 1/2] reset: uniphier: add static qualifier to probe function

Am Mittwoch, den 24.08.2016, 15:40 +0900 schrieb Masahiro Yamada:
> I missed this in the initial commit.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/reset/reset-uniphier.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
> index 9de071f..41c62af 100644
> --- a/drivers/reset/reset-uniphier.c
> +++ b/drivers/reset/reset-uniphier.c
> @@ -385,7 +385,7 @@ static const struct of_device_id uniphier_reset_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, uniphier_reset_match);
>  
> -int uniphier_reset_probe(struct platform_device *pdev)
> +static int uniphier_reset_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	const struct of_device_id *match;

Thanks, I've squashed this into the original commit.

regards
Philipp

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web