Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1469110 > unrolled thread

Re: [PATCH V5, 0/5] Add MediaTek USB3 DRD Driver

Started bychunfeng yun <chunfeng.yun@mediatek.com>
First post2016-08-24 08:50 +0200
Last post2016-08-25 06:40 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V5, 0/5] Add MediaTek USB3 DRD Driver chunfeng yun <chunfeng.yun@mediatek.com> - 2016-08-24 08:50 +0200
    Re: [PATCH V5, 0/5] Add MediaTek USB3 DRD Driver Oliver Neukum <oneukum@suse.com> - 2016-08-24 13:40 +0200
      Re: [PATCH V5, 0/5] Add MediaTek USB3 DRD Driver chunfeng yun <chunfeng.yun@mediatek.com> - 2016-08-25 06:40 +0200

#1469110 — Re: [PATCH V5, 0/5] Add MediaTek USB3 DRD Driver

Fromchunfeng yun <chunfeng.yun@mediatek.com>
Date2016-08-24 08:50 +0200
SubjectRe: [PATCH V5, 0/5] Add MediaTek USB3 DRD Driver
Message-ID<s9AaC-6X5-7@gated-at.bofh.it>
Dear all,

    Could you please help me to review the code? 

    Thank you very much.

     
On Tue, 2016-08-09 at 16:23 +0800, Chunfeng Yun wrote:
> These patches introduce the MediaTek USB3 dual-role controller
> driver.
> 
> The driver can be configured as Dual-Role Device (DRD),
> Peripheral Only and Host Only (xHCI) modes. It works well
> with Mass Storage, RNDIS and g_zero on FS/HS and SS. And it is
> tested on MT8173 platform which only contains USB2.0 device IP,
> and on MT6290 platform which contains USB3.0 device IP.
> 
> Change in v5:
> 1. modify some comments
> 2. rename some unsuitable variables
> 3. add reg-names property for host node
> 4. add USB_MTU3_DEBUG to control debug messages
> 
> Change in v4:
> 1. fix build errors on non-mediatek platforms
> 2. provide manual dual-role switch via debugfs instead of sysfs
> 
> Change in v3:
> 1. fix some typo error
> 2. rename mtu3.txt to mt8173-mtu3.txt
> 
> Change in v2:
> 1. modify binding docs according to suggestions
> 2. modify some comments and remove some dummy blank lines
> 3. fix memory leakage
> 
> 
> Chunfeng Yun (5):
>   dt-bindings: mt8173-xhci: support host side of dual-role mode
>   dt-bindings: mt8173-mtu3: add devicetree bindings
>   usb: xhci-mtk: make IPPC register optional
>   usb: Add MediaTek USB3 DRD Driver
>   arm64: dts: mediatek: add USB3 DRD driver
> 
>  .../devicetree/bindings/usb/mt8173-mtu3.txt        |   87 ++
>  .../devicetree/bindings/usb/mt8173-xhci.txt        |   54 +-
>  arch/arm64/boot/dts/mediatek/mt8173-evb.dts        |   46 +-
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi           |   29 +-
>  drivers/usb/Kconfig                                |    2 +
>  drivers/usb/Makefile                               |    1 +
>  drivers/usb/host/xhci-mtk.c                        |   36 +-
>  drivers/usb/mtu3/Kconfig                           |   54 ++
>  drivers/usb/mtu3/Makefile                          |   19 +
>  drivers/usb/mtu3/mtu3.h                            |  422 ++++++++++
>  drivers/usb/mtu3/mtu3_core.c                       |  874 +++++++++++++++++++
>  drivers/usb/mtu3/mtu3_dr.c                         |  375 +++++++++
>  drivers/usb/mtu3/mtu3_dr.h                         |  108 +++
>  drivers/usb/mtu3/mtu3_gadget.c                     |  731 ++++++++++++++++
>  drivers/usb/mtu3/mtu3_gadget_ep0.c                 |  879 ++++++++++++++++++++
>  drivers/usb/mtu3/mtu3_host.c                       |  294 +++++++
>  drivers/usb/mtu3/mtu3_hw_regs.h                    |  473 +++++++++++
>  drivers/usb/mtu3/mtu3_plat.c                       |  490 +++++++++++
>  drivers/usb/mtu3/mtu3_qmu.c                        |  599 +++++++++++++
>  drivers/usb/mtu3/mtu3_qmu.h                        |   43 +
>  20 files changed, 5598 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
>  create mode 100644 drivers/usb/mtu3/Kconfig
>  create mode 100644 drivers/usb/mtu3/Makefile
>  create mode 100644 drivers/usb/mtu3/mtu3.h
>  create mode 100644 drivers/usb/mtu3/mtu3_core.c
>  create mode 100644 drivers/usb/mtu3/mtu3_dr.c
>  create mode 100644 drivers/usb/mtu3/mtu3_dr.h
>  create mode 100644 drivers/usb/mtu3/mtu3_gadget.c
>  create mode 100644 drivers/usb/mtu3/mtu3_gadget_ep0.c
>  create mode 100644 drivers/usb/mtu3/mtu3_host.c
>  create mode 100644 drivers/usb/mtu3/mtu3_hw_regs.h
>  create mode 100644 drivers/usb/mtu3/mtu3_plat.c
>  create mode 100644 drivers/usb/mtu3/mtu3_qmu.c
>  create mode 100644 drivers/usb/mtu3/mtu3_qmu.h
>

[toc] | [next] | [standalone]

#1469354

FromOliver Neukum <oneukum@suse.com>
Date2016-08-24 13:40 +0200
Message-ID<s9EHf-1CE-7@gated-at.bofh.it>
In reply to#1469110
On Wed, 2016-08-24 at 14:42 +0800, chunfeng yun wrote:
> Dear all,
> 
>     Could you please help me to review the code? 

Is the structure

struct qmu_gpd

shared with the hardware? Do I read this correctly that
you do PIO to endpoint 0 but DMA to the others?

Could you resend the series?

	Regards
		Oliver

[toc] | [prev] | [next] | [standalone]

#1469813

Fromchunfeng yun <chunfeng.yun@mediatek.com>
Date2016-08-25 06:40 +0200
Message-ID<s9UCm-4wb-27@gated-at.bofh.it>
In reply to#1469354
Hi,

On Wed, 2016-08-24 at 13:29 +0200, Oliver Neukum wrote:
> On Wed, 2016-08-24 at 14:42 +0800, chunfeng yun wrote:
> > Dear all,
> > 
> >     Could you please help me to review the code? 
> 
> Is the structure
> 
> struct qmu_gpd
> 
> shared with the hardware? Do I read this correctly that
> you do PIO to endpoint 0 but DMA to the others?
> 
Yes, you are right.

> Could you resend the series?
> 
I will do it soon

Thank you.

> 	Regards
> 		Oliver
> 
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web