Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1466821 > unrolled thread
| Started by | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| First post | 2016-08-20 17:40 +0200 |
| Last post | 2016-08-23 01:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH -next] irqchip/irq-jcore-aic: fix non static symbol warning Wei Yongjun <weiyj.lk@gmail.com> - 2016-08-20 17:40 +0200
Re: [PATCH -next] irqchip/irq-jcore-aic: fix non static symbol warning Jason Cooper <jason@lakedaemon.net> - 2016-08-23 01:20 +0200
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2016-08-20 17:40 +0200 |
| Subject | [PATCH -next] irqchip/irq-jcore-aic: fix non static symbol warning |
| Message-ID | <s8gxk-4NU-15@gated-at.bofh.it> |
Fixes the following sparse warning:
drivers/irqchip/irq-jcore-aic.c:47:12: warning:
symbol 'aic_irq_of_init' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/irqchip/irq-jcore-aic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-jcore-aic.c b/drivers/irqchip/irq-jcore-aic.c
index 5e5e3bb..84b01de 100644
--- a/drivers/irqchip/irq-jcore-aic.c
+++ b/drivers/irqchip/irq-jcore-aic.c
@@ -44,7 +44,8 @@ static void noop(struct irq_data *data)
{
}
-int __init aic_irq_of_init(struct device_node *node, struct device_node *parent)
+static int __init aic_irq_of_init(struct device_node *node,
+ struct device_node *parent)
{
unsigned min_irq = JCORE_AIC2_MIN_HWIRQ;
unsigned dom_sz = JCORE_AIC_MAX_HWIRQ+1;
[toc] | [next] | [standalone]
| From | Jason Cooper <jason@lakedaemon.net> |
|---|---|
| Date | 2016-08-23 01:20 +0200 |
| Subject | Re: [PATCH -next] irqchip/irq-jcore-aic: fix non static symbol warning |
| Message-ID | <s96FA-4mL-13@gated-at.bofh.it> |
| In reply to | #1466821 |
Hi Wei Yongjun, On Sat, Aug 20, 2016 at 03:26:28PM +0000, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/irqchip/irq-jcore-aic.c:47:12: warning: > symbol 'aic_irq_of_init' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> > --- > drivers/irqchip/irq-jcore-aic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to irqchip/jcore, thx, Jason.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web