Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1468005 > unrolled thread

Re: [PATCH -next] PCI/PCIe: make DPC explicitly non-modular

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH -next] PCI/PCIe: make DPC explicitly non-modular Bjorn Helgaas <helgaas@kernel.org> - 2016-08-22 21:50 +0200
    Re: [PATCH -next] PCI/PCIe: make DPC explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-08-23 00:20 +0200

#1468005 — Re: [PATCH -next] PCI/PCIe: make DPC explicitly non-modular

Hi Paul,

On Thu, Jul 28, 2016 at 05:28:02PM -0400, Paul Gortmaker wrote:
> [Re: [PATCH -next] PCI/PCIe: make DPC explicitly non-modular] On 28/07/2016 (Thu 16:29) Keith Busch wrote:
> 
> > On Thu, Jul 28, 2016 at 03:33:03PM -0400, Paul Gortmaker wrote:
> > > The Kconfig currently controlling compilation of this code is:
> > > 
> > > drivers/pci/pcie/Kconfig:config PCIE_DPC
> > > drivers/pci/pcie/Kconfig:       bool "PCIe Downstream Port Containment support"
> > > 
> > > ...meaning that it currently is not being built as a module by anyone.
> > > 
> > > Lets remove the modular code that is essentially orphaned, so that
> > > when reading the driver there is no doubt it is builtin-only.
> > > 
> > > Since module_init translates to device_initcall in the non-modular
> > > case, the init ordering remains unchanged with this commit.
> > > 
> > > We also delete the MODULE_LICENSE tag etc. since all that information
> > > was (or is now) contained at the top of the file in the comments.
> > 
> > Thanks for cleaning this up.
> > 
> > FWIW, all of the other pcie service drivers look like they could use
> > the same cleanup.
> 
> Yep, not to worry, I've still got the following patches pending for-4.9:
> 
> $ grep PCI series 
> # PCI
> PCI-aerdrv-make-it-explicitly-non-modular.patch
> PCI-altera-make-it-explicitly-non-modular.patch
> PCI-dra7xx-make-it-explicitly-non-modular.patch
> PCI-imx6-make-it-explicitly-non-modular.patch
> PCI-pme-make-it-explicitly-non-modular.patch
> PCI-qcom-make-it-explicitly-non-modular.patch
> PCI-spear13xx-make-it-explicitly-non-modular.patch
> PCI-xilinx-make-it-explicitly-non-modular.patch
> PCI-xilinx-nwl-make-it-eplicitly-non-modular.patch
> PCI-portdrv-make-it-explicitly-non-modular.patch
> PCI-PCIe-make-dpc-explicitly-non-modular.patch
> PCI-generic-make-host-common-explicitly-non-modular.patch
> PCI-hotplug_core-make-it-explicitly-non-modular.patch
> PCI-hotplug-make-core-code-explicitly-non-modular.patch

Were you planning to post the patches above?  If so, I'll bundle them
all up along with this DPC one.

Bjorn

[toc] | [next] | [standalone]

#1468102

[Re: [PATCH -next] PCI/PCIe: make DPC explicitly non-modular] On 22/08/2016 (Mon 14:44) Bjorn Helgaas wrote:

> Hi Paul,
> 
> On Thu, Jul 28, 2016 at 05:28:02PM -0400, Paul Gortmaker wrote:

[...]

> > 
> > Yep, not to worry, I've still got the following patches pending for-4.9:
> > 
> > $ grep PCI series 
> > # PCI
> > PCI-aerdrv-make-it-explicitly-non-modular.patch
> > PCI-altera-make-it-explicitly-non-modular.patch
> > PCI-dra7xx-make-it-explicitly-non-modular.patch
> > PCI-imx6-make-it-explicitly-non-modular.patch
> > PCI-pme-make-it-explicitly-non-modular.patch
> > PCI-qcom-make-it-explicitly-non-modular.patch
> > PCI-spear13xx-make-it-explicitly-non-modular.patch
> > PCI-xilinx-make-it-explicitly-non-modular.patch
> > PCI-xilinx-nwl-make-it-eplicitly-non-modular.patch
> > PCI-portdrv-make-it-explicitly-non-modular.patch
> > PCI-PCIe-make-dpc-explicitly-non-modular.patch
> > PCI-generic-make-host-common-explicitly-non-modular.patch
> > PCI-hotplug_core-make-it-explicitly-non-modular.patch
> > PCI-hotplug-make-core-code-explicitly-non-modular.patch
> 
> Were you planning to post the patches above?  If so, I'll bundle them
> all up along with this DPC one.

Ha, too funny; I'd just split the remaining patches into two lots and
sent lot #1 (the binary equivalent ones) before seeing this.

The DPC one got put in lot #2 since it had __exit and/or .remove
functions, so the change isn't strictly binary equivalent anymore.

I'll send along lot #2 once you've had a chance to digest lot #1.
So feel free to ignore the earlier copy of the DPC one.

Thanks,
Paul.
--

> 
> Bjorn

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web