Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1466896 > unrolled thread
| Started by | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| First post | 2016-08-21 04:50 +0200 |
| Last post | 2016-08-21 05:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: lustre: llite: don't clean in_data again Shawn Lin <shawn.lin@rock-chips.com> - 2016-08-21 04:50 +0200
Re: [PATCH] staging: lustre: llite: don't clean in_data again Oleg Drokin <oleg.drokin@intel.com> - 2016-08-21 05:40 +0200
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2016-08-21 04:50 +0200 |
| Subject | [PATCH] staging: lustre: llite: don't clean in_data again |
| Message-ID | <s8qZH-2Xg-1@gated-at.bofh.it> |
We have got a zero buffer for in_data as we use kzalloc here. So let's remove it anyway. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- drivers/staging/lustre/lustre/llite/file.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c index 50938bd..ec6b7ce 100644 --- a/drivers/staging/lustre/lustre/llite/file.c +++ b/drivers/staging/lustre/lustre/llite/file.c @@ -3251,7 +3251,6 @@ void *ll_iocontrol_register(llioc_callback_t cb, int count, unsigned int *cmd) if (!in_data) return NULL; - memset(in_data, 0, sizeof(*in_data)); in_data->iocd_size = size; in_data->iocd_cb = cb; in_data->iocd_count = count; -- 2.3.7
[toc] | [next] | [standalone]
| From | Oleg Drokin <oleg.drokin@intel.com> |
|---|---|
| Date | 2016-08-21 05:40 +0200 |
| Message-ID | <s8rM5-3tf-1@gated-at.bofh.it> |
| In reply to | #1466896 |
Acked-by: Oleg Drokin <oleg.drokin@intel.com> On Aug 20, 2016, at 10:44 PM, Shawn Lin wrote: > We have got a zero buffer for in_data as we use > kzalloc here. So let's remove it anyway. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > > drivers/staging/lustre/lustre/llite/file.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c > index 50938bd..ec6b7ce 100644 > --- a/drivers/staging/lustre/lustre/llite/file.c > +++ b/drivers/staging/lustre/lustre/llite/file.c > @@ -3251,7 +3251,6 @@ void *ll_iocontrol_register(llioc_callback_t cb, int count, unsigned int *cmd) > if (!in_data) > return NULL; > > - memset(in_data, 0, sizeof(*in_data)); > in_data->iocd_size = size; > in_data->iocd_cb = cb; > in_data->iocd_count = count; > -- > 2.3.7 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web