Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466723 > unrolled thread

[PATCH 0/2] minor x86 PM source file cleanup

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] minor x86 PM source file cleanup Al Stone <ahs3@redhat.com> - 2016-08-20 01:30 +0200
    [PATCH 2/2] x86: ACPI: make variable names clearer in acpi_parse_madt_lapic_entries() Al Stone <ahs3@redhat.com> - 2016-08-20 01:30 +0200
    Re: [PATCH 0/2] minor x86 PM source file cleanup Pavel Machek <pavel@ucw.cz> - 2016-08-20 13:00 +0200
      Re: [PATCH 0/2] minor x86 PM source file cleanup Al Stone <ahs3@redhat.com> - 2016-08-21 02:20 +0200

#1466723 — [PATCH 0/2] minor x86 PM source file cleanup

Really minor patches: one to cleanup whitespace, the second just makes
the code a wee bit more maintainable by correcting some variable names
without changing functionality.

Al Stone (2):
  x86: ACPI: remove extraneous white space after semicolon
  x86: ACPI: make variable names clearer in
    acpi_parse_madt_lapic_entries()

 arch/x86/kernel/acpi/boot.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1466724 — [PATCH 2/2] x86: ACPI: make variable names clearer in acpi_parse_madt_lapic_entries()

This patch has no functional change; it is purely cosmetic, though
it does make it a wee bit easier to understand the code.  Before, the
count of LAPICs was being stored in the variable 'x2count' and the
count of X2APICs was being stored in the variable 'count'.  This
patch swaps that so that the routine acpi_parse_madt_lapic_entries()
will now consistently use x2count to refer to X2APIC info, and count
to refer to LAPIC info.

Signed-off-by: Al Stone <ahs3@redhat.com>
---
 arch/x86/kernel/acpi/boot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 5fb8f05..ccd27fe 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -1031,8 +1031,8 @@ static int __init acpi_parse_madt_lapic_entries(void)
 			return ret;
 		}
 
-		x2count = madt_proc[0].count;
-		count = madt_proc[1].count;
+		count = madt_proc[0].count;
+		x2count = madt_proc[1].count;
 	}
 	if (!count && !x2count) {
 		printk(KERN_ERR PREFIX "No LAPIC entries present\n");
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1466809

On Fri 2016-08-19 17:24:00, Al Stone wrote:
> Really minor patches: one to cleanup whitespace, the second just makes
> the code a wee bit more maintainable by correcting some variable names
> without changing functionality.

Acked-by: Pavel Machek <pavel@ucw.cz>

(for both)

> Al Stone (2):
>   x86: ACPI: remove extraneous white space after semicolon
>   x86: ACPI: make variable names clearer in
>     acpi_parse_madt_lapic_entries()
> 
>  arch/x86/kernel/acpi/boot.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [prev] | [next] | [standalone]

#1466885

On 08/20/2016 04:55 AM, Pavel Machek wrote:
> On Fri 2016-08-19 17:24:00, Al Stone wrote:
>> Really minor patches: one to cleanup whitespace, the second just makes
>> the code a wee bit more maintainable by correcting some variable names
>> without changing functionality.
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>
> 
> (for both)
> 
>> Al Stone (2):
>>   x86: ACPI: remove extraneous white space after semicolon
>>   x86: ACPI: make variable names clearer in
>>     acpi_parse_madt_lapic_entries()
>>
>>  arch/x86/kernel/acpi/boot.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
> 

Thanks, Pavel.

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3@redhat.com
-----------------------------------

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web