Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1462559 > unrolled thread

[PATCH] mmc: sdhci-brcmstb: Delete owner assignment

Started bySF Markus Elfring <elfring@users.sourceforge.net>
First post2016-08-15 07:50 +0200
Last post2016-08-22 15:50 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] mmc: sdhci-brcmstb: Delete owner assignment SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-15 07:50 +0200
    Re: [PATCH] mmc: sdhci-brcmstb: Delete owner assignment Adrian Hunter <adrian.hunter@intel.com> - 2016-08-18 14:50 +0200
    Re: [PATCH] mmc: sdhci-brcmstb: Delete owner assignment Ulf Hansson <ulf.hansson@linaro.org> - 2016-08-22 15:50 +0200

#1462559 — [PATCH] mmc: sdhci-brcmstb: Delete owner assignment

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2016-08-15 07:50 +0200
Subject[PATCH] mmc: sdhci-brcmstb: Delete owner assignment
Message-ID<s6iWB-1x8-1@gated-at.bofh.it>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 15 Aug 2016 07:32:45 +0200

The field "owner" is set by core. Thus delete an extra initialisation.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/mmc/host/sdhci-brcmstb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
index cce10fe..609ba5b 100644
--- a/drivers/mmc/host/sdhci-brcmstb.c
+++ b/drivers/mmc/host/sdhci-brcmstb.c
@@ -128,7 +128,6 @@ MODULE_DEVICE_TABLE(of, sdhci_brcm_of_match);
 static struct platform_driver sdhci_brcmstb_driver = {
 	.driver		= {
 		.name	= "sdhci-brcmstb",
-		.owner	= THIS_MODULE,
 		.pm	= &sdhci_brcmstb_pmops,
 		.of_match_table = of_match_ptr(sdhci_brcm_of_match),
 	},
-- 
2.9.2

[toc] | [next] | [standalone]


#1465231

FromAdrian Hunter <adrian.hunter@intel.com>
Date2016-08-18 14:50 +0200
Message-ID<s7uVI-8hT-19@gated-at.bofh.it>
In reply to#1462559
On 15/08/16 08:40, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 15 Aug 2016 07:32:45 +0200
> 
> The field "owner" is set by core. Thus delete an extra initialisation.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Could insert a blank line here

> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Otherwise:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-brcmstb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index cce10fe..609ba5b 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -128,7 +128,6 @@ MODULE_DEVICE_TABLE(of, sdhci_brcm_of_match);
>  static struct platform_driver sdhci_brcmstb_driver = {
>  	.driver		= {
>  		.name	= "sdhci-brcmstb",
> -		.owner	= THIS_MODULE,
>  		.pm	= &sdhci_brcmstb_pmops,
>  		.of_match_table = of_match_ptr(sdhci_brcm_of_match),
>  	},
> 

[toc] | [prev] | [next] | [standalone]


#1467633

FromUlf Hansson <ulf.hansson@linaro.org>
Date2016-08-22 15:50 +0200
Message-ID<s8XLX-6Xy-3@gated-at.bofh.it>
In reply to#1462559
On 15 August 2016 at 07:40, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 15 Aug 2016 07:32:45 +0200
>
> The field "owner" is set by core. Thus delete an extra initialisation.
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Thanks, applied for next! Inserted a blank line above according to
Adrian's comment.

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-brcmstb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index cce10fe..609ba5b 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -128,7 +128,6 @@ MODULE_DEVICE_TABLE(of, sdhci_brcm_of_match);
>  static struct platform_driver sdhci_brcmstb_driver = {
>         .driver         = {
>                 .name   = "sdhci-brcmstb",
> -               .owner  = THIS_MODULE,
>                 .pm     = &sdhci_brcmstb_pmops,
>                 .of_match_table = of_match_ptr(sdhci_brcm_of_match),
>         },
> --
> 2.9.2
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web