Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466621 > unrolled thread

Re: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req()

Started byJohn Youn <John.Youn@synopsys.com>
First post2016-08-19 21:20 +0200
Last post2016-08-23 13:40 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req() John Youn <John.Youn@synopsys.com> - 2016-08-19 21:20 +0200
    Re: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req() Felipe Balbi <balbi@kernel.org> - 2016-08-22 10:00 +0200
      Re: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req() Felipe Ferreri Tonello <eu@felipetonello.com> - 2016-08-23 12:30 +0200
        Re: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req() Felipe Balbi <balbi@kernel.org> - 2016-08-23 13:10 +0200
          Re: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req() Felipe Ferreri Tonello <eu@felipetonello.com> - 2016-08-23 13:40 +0200

#1466621 — Re: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req()

FromJohn Youn <John.Youn@synopsys.com>
Date2016-08-19 21:20 +0200
SubjectRe: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req()
Message-ID<s7XuF-1cK-15@gated-at.bofh.it>
On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
> Use gadget's framework allocation function instead of directly calling
> usb_ep_alloc_request().
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>  drivers/usb/gadget/function/f_hid.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
> index a010496e4e05..89d2e9a5a04f 100644
> --- a/drivers/usb/gadget/function/f_hid.c
> +++ b/drivers/usb/gadget/function/f_hid.c
> @@ -611,14 +611,10 @@ static int hidg_bind(struct usb_configuration *c, struct usb_function *f)
>  
>  	/* preallocate request and buffer */
>  	status = -ENOMEM;
> -	hidg->req = usb_ep_alloc_request(hidg->in_ep, GFP_KERNEL);
> +	hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>  	if (!hidg->req)
>  		goto fail;
>  
> -	hidg->req->buf = kmalloc(hidg->report_length, GFP_KERNEL);
> -	if (!hidg->req->buf)
> -		goto fail;
> -
>  	/* set descriptor dynamic values */
>  	hidg_interface_desc.bInterfaceSubClass = hidg->bInterfaceSubClass;
>  	hidg_interface_desc.bInterfaceProtocol = hidg->bInterfaceProtocol;
> 

Hi Felipe,

This commit on your testing/next breaks compilation.

../drivers/usb/gadget/function/f_hid.c: In function ‘hidg_bind’:
../drivers/usb/gadget/function/f_hid.c:620:14: error: too few arguments to function ‘alloc_ep_req’
  hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
              ^
In file included from ../drivers/usb/gadget/function/f_hid.c:24:0:
../drivers/usb/gadget/u_f.h:63:21: note: declared here
 struct usb_request *alloc_ep_req(struct usb_ep *ep, size_t len, int default_len);
                     ^

Regards,
John

[toc] | [next] | [standalone]

#1467433

FromFelipe Balbi <balbi@kernel.org>
Date2016-08-22 10:00 +0200
Message-ID<s8Sjg-3ra-15@gated-at.bofh.it>
In reply to#1466621

[Multipart message — attachments visible in raw view] — view raw

Hi,

John Youn <John.Youn@synopsys.com> writes:
> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
>> Use gadget's framework allocation function instead of directly calling
>> usb_ep_alloc_request().
>> 
>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
>> ---
>>  drivers/usb/gadget/function/f_hid.c | 6 +-----
>>  1 file changed, 1 insertion(+), 5 deletions(-)
>> 
>> diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
>> index a010496e4e05..89d2e9a5a04f 100644
>> --- a/drivers/usb/gadget/function/f_hid.c
>> +++ b/drivers/usb/gadget/function/f_hid.c
>> @@ -611,14 +611,10 @@ static int hidg_bind(struct usb_configuration *c, struct usb_function *f)
>>  
>>  	/* preallocate request and buffer */
>>  	status = -ENOMEM;
>> -	hidg->req = usb_ep_alloc_request(hidg->in_ep, GFP_KERNEL);
>> +	hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>>  	if (!hidg->req)
>>  		goto fail;
>>  
>> -	hidg->req->buf = kmalloc(hidg->report_length, GFP_KERNEL);
>> -	if (!hidg->req->buf)
>> -		goto fail;
>> -
>>  	/* set descriptor dynamic values */
>>  	hidg_interface_desc.bInterfaceSubClass = hidg->bInterfaceSubClass;
>>  	hidg_interface_desc.bInterfaceProtocol = hidg->bInterfaceProtocol;
>> 
>
> Hi Felipe,
>
> This commit on your testing/next breaks compilation.
>
> ../drivers/usb/gadget/function/f_hid.c: In function ‘hidg_bind’:
> ../drivers/usb/gadget/function/f_hid.c:620:14: error: too few arguments to function ‘alloc_ep_req’
>   hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>               ^
> In file included from ../drivers/usb/gadget/function/f_hid.c:24:0:
> ../drivers/usb/gadget/u_f.h:63:21: note: declared here
>  struct usb_request *alloc_ep_req(struct usb_ep *ep, size_t len, int default_len);

true that :-) Dropping from my queue.

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1468471

FromFelipe Ferreri Tonello <eu@felipetonello.com>
Date2016-08-23 12:30 +0200
Message-ID<s9h7X-2zM-5@gated-at.bofh.it>
In reply to#1467433

[Multipart message — attachments visible in raw view] — view raw

Hi,

On 22/08/16 08:45, Felipe Balbi wrote:
> 
> Hi,
> 
> John Youn <John.Youn@synopsys.com> writes:
>> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
>>> Use gadget's framework allocation function instead of directly calling
>>> usb_ep_alloc_request().
>>>
>>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
>>> ---
>>>  drivers/usb/gadget/function/f_hid.c | 6 +-----
>>>  1 file changed, 1 insertion(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
>>> index a010496e4e05..89d2e9a5a04f 100644
>>> --- a/drivers/usb/gadget/function/f_hid.c
>>> +++ b/drivers/usb/gadget/function/f_hid.c
>>> @@ -611,14 +611,10 @@ static int hidg_bind(struct usb_configuration *c, struct usb_function *f)
>>>  
>>>  	/* preallocate request and buffer */
>>>  	status = -ENOMEM;
>>> -	hidg->req = usb_ep_alloc_request(hidg->in_ep, GFP_KERNEL);
>>> +	hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>>>  	if (!hidg->req)
>>>  		goto fail;
>>>  
>>> -	hidg->req->buf = kmalloc(hidg->report_length, GFP_KERNEL);
>>> -	if (!hidg->req->buf)
>>> -		goto fail;
>>> -
>>>  	/* set descriptor dynamic values */
>>>  	hidg_interface_desc.bInterfaceSubClass = hidg->bInterfaceSubClass;
>>>  	hidg_interface_desc.bInterfaceProtocol = hidg->bInterfaceProtocol;
>>>
>>
>> Hi Felipe,
>>
>> This commit on your testing/next breaks compilation.
>>
>> ../drivers/usb/gadget/function/f_hid.c: In function ‘hidg_bind’:
>> ../drivers/usb/gadget/function/f_hid.c:620:14: error: too few arguments to function ‘alloc_ep_req’
>>   hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>>               ^
>> In file included from ../drivers/usb/gadget/function/f_hid.c:24:0:
>> ../drivers/usb/gadget/u_f.h:63:21: note: declared here
>>  struct usb_request *alloc_ep_req(struct usb_ep *ep, size_t len, int default_len);
> 
> true that :-) Dropping from my queue.
> 

Are you applying the previous patches? Specially that this is the last
patch in the series, how can it break with you if it doesn't break here?
What should I do then?

Thanks

-- 
Felipe

[toc] | [prev] | [next] | [standalone]

#1468484

FromFelipe Balbi <balbi@kernel.org>
Date2016-08-23 13:10 +0200
Message-ID<s9hKF-3bF-23@gated-at.bofh.it>
In reply to#1468471

[Multipart message — attachments visible in raw view] — view raw

Hi,

Felipe Ferreri Tonello <eu@felipetonello.com> writes:
>> John Youn <John.Youn@synopsys.com> writes:
>>> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
>>>> Use gadget's framework allocation function instead of directly calling
>>>> usb_ep_alloc_request().
>>>>
>>>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
>>>> ---
>>>>  drivers/usb/gadget/function/f_hid.c | 6 +-----
>>>>  1 file changed, 1 insertion(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
>>>> index a010496e4e05..89d2e9a5a04f 100644
>>>> --- a/drivers/usb/gadget/function/f_hid.c
>>>> +++ b/drivers/usb/gadget/function/f_hid.c
>>>> @@ -611,14 +611,10 @@ static int hidg_bind(struct usb_configuration *c, struct usb_function *f)
>>>>  
>>>>  	/* preallocate request and buffer */
>>>>  	status = -ENOMEM;
>>>> -	hidg->req = usb_ep_alloc_request(hidg->in_ep, GFP_KERNEL);
>>>> +	hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>>>>  	if (!hidg->req)
>>>>  		goto fail;
>>>>  
>>>> -	hidg->req->buf = kmalloc(hidg->report_length, GFP_KERNEL);
>>>> -	if (!hidg->req->buf)
>>>> -		goto fail;
>>>> -
>>>>  	/* set descriptor dynamic values */
>>>>  	hidg_interface_desc.bInterfaceSubClass = hidg->bInterfaceSubClass;
>>>>  	hidg_interface_desc.bInterfaceProtocol = hidg->bInterfaceProtocol;
>>>>
>>>
>>> Hi Felipe,
>>>
>>> This commit on your testing/next breaks compilation.
>>>
>>> ../drivers/usb/gadget/function/f_hid.c: In function ‘hidg_bind’:
>>> ../drivers/usb/gadget/function/f_hid.c:620:14: error: too few arguments to function ‘alloc_ep_req’
>>>   hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>>>               ^
>>> In file included from ../drivers/usb/gadget/function/f_hid.c:24:0:
>>> ../drivers/usb/gadget/u_f.h:63:21: note: declared here
>>>  struct usb_request *alloc_ep_req(struct usb_ep *ep, size_t len, int default_len);
>> 
>> true that :-) Dropping from my queue.
>> 
>
> Are you applying the previous patches? Specially that this is the last
> patch in the series, how can it break with you if it doesn't break here?
> What should I do then?

Can you rebase your series on top of my testing/next? My HEAD is
at commit 95bbb3474f1e87c9ec7ebe2acf25006e5e94a824.

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1468493

FromFelipe Ferreri Tonello <eu@felipetonello.com>
Date2016-08-23 13:40 +0200
Message-ID<s9idI-3p3-13@gated-at.bofh.it>
In reply to#1468484

[Multipart message — attachments visible in raw view] — view raw

Hi Balbi,

On 23/08/16 12:03, Felipe Balbi wrote:
> 
> Hi,
> 
> Felipe Ferreri Tonello <eu@felipetonello.com> writes:
>>> John Youn <John.Youn@synopsys.com> writes:
>>>> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
>>>>> Use gadget's framework allocation function instead of directly calling
>>>>> usb_ep_alloc_request().
>>>>>
>>>>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
>>>>> ---
>>>>>  drivers/usb/gadget/function/f_hid.c | 6 +-----
>>>>>  1 file changed, 1 insertion(+), 5 deletions(-)
>>>>>
>>>>> diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
>>>>> index a010496e4e05..89d2e9a5a04f 100644
>>>>> --- a/drivers/usb/gadget/function/f_hid.c
>>>>> +++ b/drivers/usb/gadget/function/f_hid.c
>>>>> @@ -611,14 +611,10 @@ static int hidg_bind(struct usb_configuration *c, struct usb_function *f)
>>>>>  
>>>>>  	/* preallocate request and buffer */
>>>>>  	status = -ENOMEM;
>>>>> -	hidg->req = usb_ep_alloc_request(hidg->in_ep, GFP_KERNEL);
>>>>> +	hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>>>>>  	if (!hidg->req)
>>>>>  		goto fail;
>>>>>  
>>>>> -	hidg->req->buf = kmalloc(hidg->report_length, GFP_KERNEL);
>>>>> -	if (!hidg->req->buf)
>>>>> -		goto fail;
>>>>> -
>>>>>  	/* set descriptor dynamic values */
>>>>>  	hidg_interface_desc.bInterfaceSubClass = hidg->bInterfaceSubClass;
>>>>>  	hidg_interface_desc.bInterfaceProtocol = hidg->bInterfaceProtocol;
>>>>>
>>>>
>>>> Hi Felipe,
>>>>
>>>> This commit on your testing/next breaks compilation.
>>>>
>>>> ../drivers/usb/gadget/function/f_hid.c: In function ‘hidg_bind’:
>>>> ../drivers/usb/gadget/function/f_hid.c:620:14: error: too few arguments to function ‘alloc_ep_req’
>>>>   hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>>>>               ^
>>>> In file included from ../drivers/usb/gadget/function/f_hid.c:24:0:
>>>> ../drivers/usb/gadget/u_f.h:63:21: note: declared here
>>>>  struct usb_request *alloc_ep_req(struct usb_ep *ep, size_t len, int default_len);
>>>
>>> true that :-) Dropping from my queue.
>>>
>>
>> Are you applying the previous patches? Specially that this is the last
>> patch in the series, how can it break with you if it doesn't break here?
>> What should I do then?
> 
> Can you rebase your series on top of my testing/next? My HEAD is
> at commit 95bbb3474f1e87c9ec7ebe2acf25006e5e94a824.

It was at that time. I will rebease it then on v5. Just waiting for your
comments on the other thread.

Thanks

-- 
Felipe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web