Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466360 > unrolled thread

[PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers Andrew Jeffery <andrew@aj.id.au> - 2016-08-19 14:50 +0200
    Re: [PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed  GPIO controllers Rob Herring <robh@kernel.org> - 2016-08-19 16:40 +0200
      Re: [PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed  GPIO controllers Andrew Jeffery <andrew@aj.id.au> - 2016-08-22 02:20 +0200

#1466360 — [PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---

Since v1:

Rob: I haven't added your Acked-by here as I've made the following changes and
wanted to get your input:

* Remove interrupt-controller as an optional property
* Defer to interrupt-controller bindings document for sub-node properties

I had a discussion with Joel about whether the interrupt-controller capability
should be optional and the conclusion was that it should always be configured
by the driver. This makes an optional interrupt-controller property feel
redundant (and possibly inaccurate if left out) so I've removed it.

 .../devicetree/bindings/gpio/gpio-aspeed.txt       | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/gpio-aspeed.txt

diff --git a/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt
new file mode 100644
index 000000000000..a5ad1eb93ce0
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt
@@ -0,0 +1,34 @@
+Aspeed GPIO controller Device Tree Bindings
+-------------------------------------------
+
+Required properties:
+- #gpio-cells 		: Should be two
+			  - First cell is the GPIO line number
+			  - Second cell is used to specify optional
+			    parameters (unused)
+
+- compatible		: Either "aspeed,ast2400-gpio" or "aspeed,ast2500-gpio"
+
+- reg			: Address and length of the register set for the device
+- gpio-controller	: Marks the device node as a GPIO controller.
+- interrupts		: Interrupt specifier (see interrupt bindings for
+			  details)
+
+Optional properties:
+
+- interrupt-parent      : The parent interrupt controller, optional if inherited
+
+The gpio and interrupt properties are further described in their respective
+bindings documentation:
+
+- Documentation/devicetree/bindings/gpio/gpio.txt
+- Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
+
+  Example:
+	gpio@1e780000 {
+		#gpio-cells = <2>;
+		compatible = "aspeed,ast2400-gpio"
+		gpio-controller;
+		interrupts = <20>;
+		reg = <0x1e780000 0x1000>;
+	};
-- 
2.9.3

[toc] | [next] | [standalone]

#1466466 — Re: [PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers

On Fri, Aug 19, 2016 at 10:14:10PM +0930, Andrew Jeffery wrote:
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> 
> Since v1:
> 
> Rob: I haven't added your Acked-by here as I've made the following changes and
> wanted to get your input:
> 
> * Remove interrupt-controller as an optional property
> * Defer to interrupt-controller bindings document for sub-node properties
> 
> I had a discussion with Joel about whether the interrupt-controller capability
> should be optional and the conclusion was that it should always be configured
> by the driver. This makes an optional interrupt-controller property feel
> redundant (and possibly inaccurate if left out) so I've removed it.

I don't follow. What do you mean byt "configured by the driver". If the 
block supports interrupts, then it should be marked as an 
interrupt-controller. It never should have been optional. The OS can 
ignore the interrupt properties if it chooses. 

Rob

[toc] | [prev] | [next] | [standalone]

#1467293 — Re: [PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers

[Multipart message — attachments visible in raw view] — view raw

On Fri, 2016-08-19 at 09:36 -0500, Rob Herring wrote:
> On Fri, Aug 19, 2016 at 10:14:10PM +0930, Andrew Jeffery wrote:
> > 
> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > ---
> > 
> > Since v1:
> > 
> > Rob: I haven't added your Acked-by here as I've made the following changes and
> > wanted to get your input:
> > 
> > * Remove interrupt-controller as an optional property
> > * Defer to interrupt-controller bindings document for sub-node properties
> > 
> > I had a discussion with Joel about whether the interrupt-controller capability
> > should be optional and the conclusion was that it should always be configured
> > by the driver. This makes an optional interrupt-controller property feel
> > redundant (and possibly inaccurate if left out) so I've removed it.
> I don't follow. What do you mean byt "configured by the driver". If the 
> block supports interrupts, then it should be marked as an 
> interrupt-controller. It never should have been optional. The OS can 
> ignore the interrupt properties if it chooses. 

Right, clearly there was some confusion on my part. I will fix that up.
Thanks for clarifying.

Andrew

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web