Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467262 > unrolled thread

Re: [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-21 23:30 +0200

#1467262 — Re: [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking

On Tue, Aug 09, 2016 at 01:34:57AM -0400, Lidza Louina wrote:
> The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it.
> The code had an up() where a down() should've been. This patch fixes that.
> 
> Signed-off-by: Lidza Louina <Lidza.Louina@oracle.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> index 7748523..16f0b19 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> @@ -162,7 +162,7 @@ int rtw_cmd_thread(void *context)
>  	allow_signal(SIGTERM);
>  
>  	pcmdpriv->cmdthd_running = true;
> -	up(&pcmdpriv->terminate_cmdthread_sema);
> +	down(&pcmdpriv->terminate_cmdthread_sema);
>  
>  	RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n"));
>  
> -- 
> 2.7.4

This path is corrupted somehow and doesn't apply at all :(

Can you see what went wrong with your email client and try again?

thanks,

greg k-h

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web