Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1466866 > unrolled thread
| Started by | Oleg Drokin <green@linuxhacker.ru> |
|---|---|
| First post | 2016-08-20 23:40 +0200 |
| Last post | 2016-08-21 23:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 12/13] staging/lustre: Remove unused cp_error from struct cl_page Oleg Drokin <green@linuxhacker.ru> - 2016-08-20 23:40 +0200
Re: [PATCH 12/13] staging/lustre: Remove unused cp_error from struct cl_page Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-21 23:20 +0200
| From | Oleg Drokin <green@linuxhacker.ru> |
|---|---|
| Date | 2016-08-20 23:40 +0200 |
| Subject | [PATCH 12/13] staging/lustre: Remove unused cp_error from struct cl_page |
| Message-ID | <s8m9H-8ms-1@gated-at.bofh.it> |
cp_error member is not really set anywhere, so kill
it and the only printing user of it too.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 --
drivers/staging/lustre/lustre/obdclass/cl_page.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/cl_object.h b/drivers/staging/lustre/lustre/include/cl_object.h
index 78613a9..6d8f956 100644
--- a/drivers/staging/lustre/lustre/include/cl_object.h
+++ b/drivers/staging/lustre/lustre/include/cl_object.h
@@ -726,8 +726,6 @@ struct cl_page {
struct mutex cp_mutex;
/** Linkage of pages within cl_req. */
struct list_head cp_flight;
- /** Transfer error. */
- int cp_error;
/**
* Page type. Only CPT_TRANSIENT is used so far. Immutable after
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c
index db2dc6b..d903f71 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_page.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_page.c
@@ -989,9 +989,9 @@ void cl_page_header_print(const struct lu_env *env, void *cookie,
lu_printer_t printer, const struct cl_page *pg)
{
(*printer)(env, cookie,
- "page@%p[%d %p %d %d %d %p %p %#x]\n",
+ "page@%p[%d %p %d %d %p %p %#x]\n",
pg, atomic_read(&pg->cp_ref), pg->cp_obj,
- pg->cp_state, pg->cp_error, pg->cp_type,
+ pg->cp_state, pg->cp_type,
pg->cp_owner, pg->cp_req, pg->cp_flags);
}
EXPORT_SYMBOL(cl_page_header_print);
--
2.7.4
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-08-21 23:20 +0200 |
| Subject | Re: [PATCH 12/13] staging/lustre: Remove unused cp_error from struct cl_page |
| Message-ID | <s8IjT-5CK-1@gated-at.bofh.it> |
| In reply to | #1466866 |
On Sat, Aug 20, 2016 at 05:34:29PM -0400, Oleg Drokin wrote: > cp_error member is not really set anywhere, so kill > it and the only printing user of it too. > > Signed-off-by: Oleg Drokin <green@linuxhacker.ru> > --- > drivers/staging/lustre/lustre/include/cl_object.h | 2 -- > drivers/staging/lustre/lustre/obdclass/cl_page.c | 4 ++-- > 2 files changed, 2 insertions(+), 4 deletions(-) Doesn't apply :(
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web