Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1463490 > unrolled thread

Re: [PATCH] usb: remove redundant dependency on USB_SUPPORT

Started byFelipe Balbi <balbi@kernel.org>
First post2016-08-16 09:40 +0200
Last post2016-08-18 09:10 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] usb: remove redundant dependency on USB_SUPPORT Felipe Balbi <balbi@kernel.org> - 2016-08-16 09:40 +0200
    Re: [PATCH] usb: remove redundant dependency on USB_SUPPORT Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-16 11:30 +0200
      Re: [PATCH] usb: remove redundant dependency on USB_SUPPORT Felipe Balbi <balbi@kernel.org> - 2016-08-18 09:10 +0200

#1463490 — Re: [PATCH] usb: remove redundant dependency on USB_SUPPORT

FromFelipe Balbi <balbi@kernel.org>
Date2016-08-16 09:40 +0200
SubjectRe: [PATCH] usb: remove redundant dependency on USB_SUPPORT
Message-ID<s6H8C-7r-9@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Hi,

Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> The whole Kconfig entries of the USB subsystem are surrounded with
> "if USB_SUPPORT" ... "endif", so CONFIG_USB_SUPPORT=y is surely met
> when these two Kconfig options are visible.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/usb/core/Kconfig | 1 -
>  drivers/usb/dwc3/Kconfig | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index dd28010..253aac7 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -85,7 +85,6 @@ config USB_OTG_FSM
>  
>  config USB_ULPI_BUS
>  	tristate "USB ULPI PHY interface support"
> -	depends on USB_SUPPORT
>  	help
>  	  UTMI+ Low Pin Interface (ULPI) is specification for a commonly used
>  	  USB 2.0 PHY interface. The ULPI specification defines a standard set
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 11864e4..3c6213c 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -1,7 +1,7 @@
>  config USB_DWC3
>  	tristate "DesignWare USB3 DRD Core Support"
>  	depends on (USB || USB_GADGET) && HAS_DMA
> -	select USB_XHCI_PLATFORM if USB_SUPPORT && USB_XHCI_HCD
> +	select USB_XHCI_PLATFORM if USB_XHCI_HCD
>  	help
>  	  Say Y or M here if your system has a Dual Role SuperSpeed
>  	  USB controller based on the DesignWare USB3 IP Core.

let's split this patch in two so different maintainers can pick the
relevant pieces. Thanks

-- 
balbi

[toc] | [next] | [standalone]


#1463584

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-08-16 11:30 +0200
Message-ID<s6IR3-1hW-1@gated-at.bofh.it>
In reply to#1463490
2016-08-16 16:29 GMT+09:00 Felipe Balbi <balbi@kernel.org>:
>
> Hi,
>
> Masahiro Yamada <yamada.masahiro@socionext.com> writes:
>> The whole Kconfig entries of the USB subsystem are surrounded with
>> "if USB_SUPPORT" ... "endif", so CONFIG_USB_SUPPORT=y is surely met
>> when these two Kconfig options are visible.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>>  drivers/usb/core/Kconfig | 1 -
>>  drivers/usb/dwc3/Kconfig | 2 +-
>>  2 files changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
>> index dd28010..253aac7 100644
>> --- a/drivers/usb/core/Kconfig
>> +++ b/drivers/usb/core/Kconfig
>> @@ -85,7 +85,6 @@ config USB_OTG_FSM
>>
>>  config USB_ULPI_BUS
>>       tristate "USB ULPI PHY interface support"
>> -     depends on USB_SUPPORT
>>       help
>>         UTMI+ Low Pin Interface (ULPI) is specification for a commonly used
>>         USB 2.0 PHY interface. The ULPI specification defines a standard set
>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>> index 11864e4..3c6213c 100644
>> --- a/drivers/usb/dwc3/Kconfig
>> +++ b/drivers/usb/dwc3/Kconfig
>> @@ -1,7 +1,7 @@
>>  config USB_DWC3
>>       tristate "DesignWare USB3 DRD Core Support"
>>       depends on (USB || USB_GADGET) && HAS_DMA
>> -     select USB_XHCI_PLATFORM if USB_SUPPORT && USB_XHCI_HCD
>> +     select USB_XHCI_PLATFORM if USB_XHCI_HCD
>>       help
>>         Say Y or M here if your system has a Dual Role SuperSpeed
>>         USB controller based on the DesignWare USB3 IP Core.
>
> let's split this patch in two so different maintainers can pick the
> relevant pieces. Thanks


Greg picked up this patch already.

I see it in linux-next now.





-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]


#1464950

FromFelipe Balbi <balbi@kernel.org>
Date2016-08-18 09:10 +0200
Message-ID<s7pCG-4NL-7@gated-at.bofh.it>
In reply to#1463584

[Multipart message — attachments visible in raw view] — view raw

Hi,

Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> 2016-08-16 16:29 GMT+09:00 Felipe Balbi <balbi@kernel.org>:
>>
>> Hi,
>>
>> Masahiro Yamada <yamada.masahiro@socionext.com> writes:
>>> The whole Kconfig entries of the USB subsystem are surrounded with
>>> "if USB_SUPPORT" ... "endif", so CONFIG_USB_SUPPORT=y is surely met
>>> when these two Kconfig options are visible.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> ---
>>>
>>>  drivers/usb/core/Kconfig | 1 -
>>>  drivers/usb/dwc3/Kconfig | 2 +-
>>>  2 files changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
>>> index dd28010..253aac7 100644
>>> --- a/drivers/usb/core/Kconfig
>>> +++ b/drivers/usb/core/Kconfig
>>> @@ -85,7 +85,6 @@ config USB_OTG_FSM
>>>
>>>  config USB_ULPI_BUS
>>>       tristate "USB ULPI PHY interface support"
>>> -     depends on USB_SUPPORT
>>>       help
>>>         UTMI+ Low Pin Interface (ULPI) is specification for a commonly used
>>>         USB 2.0 PHY interface. The ULPI specification defines a standard set
>>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>>> index 11864e4..3c6213c 100644
>>> --- a/drivers/usb/dwc3/Kconfig
>>> +++ b/drivers/usb/dwc3/Kconfig
>>> @@ -1,7 +1,7 @@
>>>  config USB_DWC3
>>>       tristate "DesignWare USB3 DRD Core Support"
>>>       depends on (USB || USB_GADGET) && HAS_DMA
>>> -     select USB_XHCI_PLATFORM if USB_SUPPORT && USB_XHCI_HCD
>>> +     select USB_XHCI_PLATFORM if USB_XHCI_HCD
>>>       help
>>>         Say Y or M here if your system has a Dual Role SuperSpeed
>>>         USB controller based on the DesignWare USB3 IP Core.
>>
>> let's split this patch in two so different maintainers can pick the
>> relevant pieces. Thanks
>
>
> Greg picked up this patch already.
>
> I see it in linux-next now.

oh, okay. No problem

-- 
balbi

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web