Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1466392 > unrolled thread

[PATCH 1/2] ARM: exynos_defconfig: Don't attempt to enable schedutil governor as module

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2016-08-19 15:20 +0200
Last post2016-08-19 15:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 1/2] ARM: exynos_defconfig: Don't attempt to enable schedutil governor as module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-19 15:20 +0200
    Re: [PATCH 1/2] ARM: exynos_defconfig: Don't attempt to enable  schedutil governor as module Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-19 15:50 +0200

#1466392 — [PATCH 1/2] ARM: exynos_defconfig: Don't attempt to enable schedutil governor as module

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-08-19 15:20 +0200
Subject[PATCH 1/2] ARM: exynos_defconfig: Don't attempt to enable schedutil governor as module
Message-ID<s7RSh-65h-7@gated-at.bofh.it>
The schedutil CPUFreq governor could be built as a module but the commit
58919e83c85c ("cpufreq / sched: Pass flags to cpufreq_update_util()")
made it non-modular so attempting to enable as module leads to a warning:

warning: symbol value 'm' invalid for CPU_FREQ_GOV_SCHEDUTIL

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/configs/exynos_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 5476be3be686..4e484f406419 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -29,7 +29,7 @@ CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
 CONFIG_CPU_FREQ_GOV_POWERSAVE=m
 CONFIG_CPU_FREQ_GOV_USERSPACE=m
 CONFIG_CPU_FREQ_GOV_CONSERVATIVE=m
-CONFIG_CPU_FREQ_GOV_SCHEDUTIL=m
+CONFIG_CPU_FREQ_GOV_SCHEDUTIL=y
 CONFIG_CPUFREQ_DT=y
 CONFIG_CPU_IDLE=y
 CONFIG_ARM_EXYNOS_CPUIDLE=y
-- 
2.5.5

[toc] | [next] | [standalone]


#1466430 — Re: [PATCH 1/2] ARM: exynos_defconfig: Don't attempt to enable schedutil governor as module

FromKrzysztof Kozlowski <krzk@kernel.org>
Date2016-08-19 15:50 +0200
SubjectRe: [PATCH 1/2] ARM: exynos_defconfig: Don't attempt to enable schedutil governor as module
Message-ID<s7Slj-6gW-1@gated-at.bofh.it>
In reply to#1466392
On 08/19/2016 03:12 PM, Javier Martinez Canillas wrote:
> The schedutil CPUFreq governor could be built as a module but the commit
> 58919e83c85c ("cpufreq / sched: Pass flags to cpufreq_update_util()")
> made it non-modular so attempting to enable as module leads to a warning:
> 
> warning: symbol value 'm' invalid for CPU_FREQ_GOV_SCHEDUTIL
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  arch/arm/configs/exynos_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Same as patch 2/2, for reference:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

BR,
Krzysztof

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web