Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1464586 > unrolled thread
| Started by | Rafał Miłecki <zajec5@gmail.com> |
|---|---|
| First post | 2016-08-17 15:40 +0200 |
| Last post | 2016-08-19 08:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net] net: bgmac: fix reversed check for MII registration error Rafał Miłecki <zajec5@gmail.com> - 2016-08-17 15:40 +0200
Re: [PATCH net] net: bgmac: fix reversed check for MII registration error David Miller <davem@davemloft.net> - 2016-08-19 08:30 +0200
| From | Rafał Miłecki <zajec5@gmail.com> |
|---|---|
| Date | 2016-08-17 15:40 +0200 |
| Subject | [PATCH net] net: bgmac: fix reversed check for MII registration error |
| Message-ID | <s79ex-1DG-17@gated-at.bofh.it> |
From: Rafał Miłecki <rafal@milecki.pl>
It was failing on successful registration returning meaningless errors.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Fixes: 55954f3bfdac ("net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file")
---
This fix is intendent for net repository (4.8 release).
---
drivers/net/ethernet/broadcom/bgmac-bcma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c
index 9a9745c4..625235d 100644
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
@@ -159,7 +159,7 @@ static int bgmac_probe(struct bcma_device *core)
if (!bgmac_is_bcm4707_family(core)) {
mii_bus = bcma_mdio_mii_register(core, bgmac->phyaddr);
- if (!IS_ERR(mii_bus)) {
+ if (IS_ERR(mii_bus)) {
err = PTR_ERR(mii_bus);
goto err;
}
--
1.8.4.5
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-08-19 08:30 +0200 |
| Subject | Re: [PATCH net] net: bgmac: fix reversed check for MII registration error |
| Message-ID | <s7Ltw-202-9@gated-at.bofh.it> |
| In reply to | #1464586 |
From: Rafał Miłecki <zajec5@gmail.com>
Date: Wed, 17 Aug 2016 15:37:14 +0200
> From: Rafał Miłecki <rafal@milecki.pl>
>
> It was failing on successful registration returning meaningless errors.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> Fixes: 55954f3bfdac ("net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file")
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web