Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1464805 > unrolled thread
| Started by | Rafał Miłecki <zajec5@gmail.com> |
|---|---|
| First post | 2016-08-17 23:20 +0200 |
| Last post | 2016-08-19 08:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net-next] net: bgmac: make it clear when setting interface type to RMII Rafał Miłecki <zajec5@gmail.com> - 2016-08-17 23:20 +0200
Re: [PATCH net-next] net: bgmac: make it clear when setting interface type to RMII David Miller <davem@davemloft.net> - 2016-08-19 08:40 +0200
| From | Rafał Miłecki <zajec5@gmail.com> |
|---|---|
| Date | 2016-08-17 23:20 +0200 |
| Subject | [PATCH net-next] net: bgmac: make it clear when setting interface type to RMII |
| Message-ID | <s7gpH-6MJ-17@gated-at.bofh.it> |
From: Rafał Miłecki <rafal@milecki.pl>
It doesn't really change anything as BGMAC_CHIPCTL_1_IF_TYPE_RMII is
equal to 0. It make code a bit clener, so far when reading it one could
think we forgot to set a proper mode. It also keeps this mode code in
sync with other ones.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/net/ethernet/broadcom/bgmac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index 63ef7235..6ea0e5f 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -932,7 +932,8 @@ static void bgmac_chip_reset(struct bgmac *bgmac)
et_swtype <<= 4;
sw_type = et_swtype;
} else if (bgmac->feature_flags & BGMAC_FEAT_SW_TYPE_EPHYRMII) {
- sw_type = BGMAC_CHIPCTL_1_SW_TYPE_EPHYRMII;
+ sw_type = BGMAC_CHIPCTL_1_IF_TYPE_RMII |
+ BGMAC_CHIPCTL_1_SW_TYPE_EPHYRMII;
} else if (bgmac->feature_flags & BGMAC_FEAT_SW_TYPE_RGMII) {
sw_type = BGMAC_CHIPCTL_1_IF_TYPE_RGMII |
BGMAC_CHIPCTL_1_SW_TYPE_RGMII;
--
1.8.4.5
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-08-19 08:40 +0200 |
| Subject | Re: [PATCH net-next] net: bgmac: make it clear when setting interface type to RMII |
| Message-ID | <s7LDb-23l-1@gated-at.bofh.it> |
| In reply to | #1464805 |
From: Rafał Miłecki <zajec5@gmail.com> Date: Wed, 17 Aug 2016 23:11:52 +0200 > From: Rafał Miłecki <rafal@milecki.pl> > > It doesn't really change anything as BGMAC_CHIPCTL_1_IF_TYPE_RMII is > equal to 0. It make code a bit clener, so far when reading it one could > think we forgot to set a proper mode. It also keeps this mode code in > sync with other ones. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web