Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1463764 > unrolled thread

Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix randomly placed semi-colon

Started byLee Jones <lee.jones@linaro.org>
First post2016-08-16 15:00 +0200
Last post2016-08-17 09:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix randomly placed  semi-colon Lee Jones <lee.jones@linaro.org> - 2016-08-16 15:00 +0200
    Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix randomly placed  semi-colon Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-16 18:30 +0200
      Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix randomly placed  semi-colon Lee Jones <lee.jones@linaro.org> - 2016-08-17 09:50 +0200

#1463764 — Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix randomly placed semi-colon

FromLee Jones <lee.jones@linaro.org>
Date2016-08-16 15:00 +0200
SubjectRe: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix randomly placed semi-colon
Message-ID<s6M8h-3cC-15@gated-at.bofh.it>
On Wed, 20 Jul 2016, Lee Jones wrote:

> It should never have been there in the first place.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'm assuming this was missed.  Would you like me to send it again, or
do you have the original patch still in your inbox?

> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> index fe03b2a..9823178 100644
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -865,7 +865,7 @@ static void rpmsg_recv_done(struct virtqueue *rvq)
>  		msgs_received++;
>  
>  		msg = virtqueue_get_buf(rvq, &len);
> -	};
> +	}
>  
>  	dev_dbg(dev, "Received %u messages\n", msgs_received);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [next] | [standalone]


#1463929

FromBjorn Andersson <bjorn.andersson@linaro.org>
Date2016-08-16 18:30 +0200
Message-ID<s6Ppw-5mf-11@gated-at.bofh.it>
In reply to#1463764
On Tue 16 Aug 05:52 PDT 2016, Lee Jones wrote:

> On Wed, 20 Jul 2016, Lee Jones wrote:
> 
> > It should never have been there in the first place.
> > 
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I'm assuming this was missed.  Would you like me to send it again, or
> do you have the original patch still in your inbox?
> 

It was applied end of last week, but forgot to respond to your email,
sorry about that.

Thanks,
Bjorn

> > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> > index fe03b2a..9823178 100644
> > --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> > @@ -865,7 +865,7 @@ static void rpmsg_recv_done(struct virtqueue *rvq)
> >  		msgs_received++;
> >  
> >  		msg = virtqueue_get_buf(rvq, &len);
> > -	};
> > +	}
> >  
> >  	dev_dbg(dev, "Received %u messages\n", msgs_received);
> >  
> 
> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org ??? Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]


#1464389

FromLee Jones <lee.jones@linaro.org>
Date2016-08-17 09:50 +0200
Message-ID<s73LP-6q3-13@gated-at.bofh.it>
In reply to#1463929
On Tue, 16 Aug 2016, Bjorn Andersson wrote:

> On Tue 16 Aug 05:52 PDT 2016, Lee Jones wrote:
> 
> > On Wed, 20 Jul 2016, Lee Jones wrote:
> > 
> > > It should never have been there in the first place.
> > > 
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >  drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > I'm assuming this was missed.  Would you like me to send it again, or
> > do you have the original patch still in your inbox?
> > 
> 
> It was applied end of last week, but forgot to respond to your email,
> sorry about that.

Ah, great, thanks.

> > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> > > index fe03b2a..9823178 100644
> > > --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> > > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> > > @@ -865,7 +865,7 @@ static void rpmsg_recv_done(struct virtqueue *rvq)
> > >  		msgs_received++;
> > >  
> > >  		msg = virtqueue_get_buf(rvq, &len);
> > > -	};
> > > +	}
> > >  
> > >  	dev_dbg(dev, "Received %u messages\n", msgs_received);
> > >  
> > 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web