Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1464127 > unrolled thread

[PATCH] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"

Started bySF Markus Elfring <elfring@users.sourceforge.net>
First post2016-08-16 22:40 +0200
Last post2016-08-16 22:50 +0200
Articles 6 — 5 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] cpufreq-SCPI: Delete unnecessary assignment for the field  "owner" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-16 22:40 +0200
    Re: [PATCH] cpufreq-SCPI: Delete unnecessary assignment for the  field "owner" Julia Lawall <julia.lawall@lip6.fr> - 2016-08-16 22:50 +0200
      [PATCH v2] cpufreq-SCPI: Delete unnecessary assignment for the field  "owner" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-17 08:30 +0200
        Re: [PATCH v2] cpufreq-SCPI: Delete unnecessary assignment for the  field "owner" Viresh Kumar <viresh.kumar@linaro.org> - 2016-08-17 09:10 +0200
        Re: [PATCH v2] cpufreq-SCPI: Delete unnecessary assignment for the  field "owner" Sudeep Holla <sudeep.holla@arm.com> - 2016-08-17 11:00 +0200
    Re: [PATCH] cpufreq-SCPI: Delete unnecessary assignment for the field "owner" "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-16 22:50 +0200

#1464127 — [PATCH] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2016-08-16 22:40 +0200
Subject[PATCH] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"
Message-ID<s6Tjs-7Qi-31@gated-at.bofh.it>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 16 Aug 2016 22:30:17 +0200

The field "owner" is set by the core.
Thus delete an unneeded initialisation.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/cpufreq/scpi-cpufreq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index e8a7bf5..4a70d241 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -104,8 +104,7 @@ static int scpi_cpufreq_remove(struct platform_device *pdev)
 
 static struct platform_driver scpi_cpufreq_platdrv = {
 	.driver = {
-		.name	= "scpi-cpufreq",
-		.owner	= THIS_MODULE,
+		.name	= "scpi-cpufreq"
 	},
 	.probe		= scpi_cpufreq_probe,
 	.remove		= scpi_cpufreq_remove,
-- 
2.9.3

[toc] | [next] | [standalone]


#1464148 — Re: [PATCH] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-08-16 22:50 +0200
SubjectRe: [PATCH] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"
Message-ID<s6Tt7-7TM-9@gated-at.bofh.it>
In reply to#1464127

On Tue, 16 Aug 2016, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 16 Aug 2016 22:30:17 +0200
>
> The field "owner" is set by the core.
> Thus delete an unneeded initialisation.
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/cpufreq/scpi-cpufreq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
> index e8a7bf5..4a70d241 100644
> --- a/drivers/cpufreq/scpi-cpufreq.c
> +++ b/drivers/cpufreq/scpi-cpufreq.c
> @@ -104,8 +104,7 @@ static int scpi_cpufreq_remove(struct platform_device *pdev)
>
>  static struct platform_driver scpi_cpufreq_platdrv = {
>  	.driver = {
> -		.name	= "scpi-cpufreq",
> -		.owner	= THIS_MODULE,
> +		.name	= "scpi-cpufreq"

You don't need to remove the comma.  There was a trailing comma
originally, so you may as well leave that.

julia

>  	},
>  	.probe		= scpi_cpufreq_probe,
>  	.remove		= scpi_cpufreq_remove,
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

[toc] | [prev] | [next] | [standalone]


#1464342 — [PATCH v2] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2016-08-17 08:30 +0200
Subject[PATCH v2] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"
Message-ID<s72wq-5Fb-19@gated-at.bofh.it>
In reply to#1464148
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 16 Aug 2016 23:00:07 +0200

The field "owner" is set by the core.
Thus delete an unneeded initialisation.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---

v2: A trailing comma was preserved even for a single designated initializer.

 drivers/cpufreq/scpi-cpufreq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index e8a7bf5..ea7a4e1 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -105,7 +105,6 @@ static int scpi_cpufreq_remove(struct platform_device *pdev)
 static struct platform_driver scpi_cpufreq_platdrv = {
 	.driver = {
 		.name	= "scpi-cpufreq",
-		.owner	= THIS_MODULE,
 	},
 	.probe		= scpi_cpufreq_probe,
 	.remove		= scpi_cpufreq_remove,
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]


#1464362 — Re: [PATCH v2] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"

FromViresh Kumar <viresh.kumar@linaro.org>
Date2016-08-17 09:10 +0200
SubjectRe: [PATCH v2] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"
Message-ID<s7398-6a6-3@gated-at.bofh.it>
In reply to#1464342
On 17-08-16, 08:21, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 16 Aug 2016 23:00:07 +0200
> 
> The field "owner" is set by the core.
> Thus delete an unneeded initialisation.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> 
> v2: A trailing comma was preserved even for a single designated initializer.
> 
>  drivers/cpufreq/scpi-cpufreq.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
> index e8a7bf5..ea7a4e1 100644
> --- a/drivers/cpufreq/scpi-cpufreq.c
> +++ b/drivers/cpufreq/scpi-cpufreq.c
> @@ -105,7 +105,6 @@ static int scpi_cpufreq_remove(struct platform_device *pdev)
>  static struct platform_driver scpi_cpufreq_platdrv = {
>  	.driver = {
>  		.name	= "scpi-cpufreq",
> -		.owner	= THIS_MODULE,
>  	},
>  	.probe		= scpi_cpufreq_probe,
>  	.remove		= scpi_cpufreq_remove,

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

[toc] | [prev] | [next] | [standalone]


#1464419 — Re: [PATCH v2] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"

FromSudeep Holla <sudeep.holla@arm.com>
Date2016-08-17 11:00 +0200
SubjectRe: [PATCH v2] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"
Message-ID<s74RA-75h-19@gated-at.bofh.it>
In reply to#1464342

On 17/08/16 07:21, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 16 Aug 2016 23:00:07 +0200
>
> The field "owner" is set by the core.
> Thus delete an unneeded initialisation.
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

-- 
Regards,
Sudeep

[toc] | [prev] | [next] | [standalone]


#1464150 — Re: [PATCH] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2016-08-16 22:50 +0200
SubjectRe: [PATCH] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"
Message-ID<s6Tt7-7TM-15@gated-at.bofh.it>
In reply to#1464127
On Tuesday, August 16, 2016 10:38:02 PM SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 16 Aug 2016 22:30:17 +0200
> 
> The field "owner" is set by the core.
> Thus delete an unneeded initialisation.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/cpufreq/scpi-cpufreq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
> index e8a7bf5..4a70d241 100644
> --- a/drivers/cpufreq/scpi-cpufreq.c
> +++ b/drivers/cpufreq/scpi-cpufreq.c
> @@ -104,8 +104,7 @@ static int scpi_cpufreq_remove(struct platform_device *pdev)
>  
>  static struct platform_driver scpi_cpufreq_platdrv = {
>  	.driver = {
> -		.name	= "scpi-cpufreq",
> -		.owner	= THIS_MODULE,
> +		.name	= "scpi-cpufreq"

Comma, please.

>  	},
>  	.probe		= scpi_cpufreq_probe,
>  	.remove		= scpi_cpufreq_remove,
> 

Thanks.
Rafael

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web