Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463000 > unrolled thread

Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks in

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks  in Greg KH <gregkh@linuxfoundation.org> - 2016-08-15 19:10 +0200
    Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks in DaeSeok Youn <daeseok.youn@gmail.com> - 2016-08-17 03:10 +0200
      Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks  in Greg KH <gregkh@linuxfoundation.org> - 2016-08-17 08:30 +0200
        Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks in DaeSeok Youn <daeseok.youn@gmail.com> - 2016-08-17 13:30 +0200

#1463000 — Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks in

On Wed, Jul 06, 2016 at 03:11:13PM +0900, Daeseok Youn wrote:
> The dgnc_block_til_ready() is only used in dgnc_tty_open().
> The unit data(struct un_t) was stored into tty->driver_data in dgnc_tty_open().
> And also tty and un were tested about NULL so these variables doesn't
> need to check for NULL in dgnc_block_til_ready().
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> RESEND: This patch was not merged for a long time, if there is any reason
> why this patch could NOT be merged into staging tree, let me know.
> There were no comment for this patch.
> I cannot understand why this patch have to wait long time to merge.
> And I also sent emails to mailing-lists for reminding this patch...
> please let me know, what is the problem to merge this patch into staging tree.

Please note, staging patches are at the bottom of my priority queue.
Combined with a vacation, conferences, and a merge window and there are
a lot of pending staging patches in my to-review queue.

thanks for your patience.

greg k-h

[toc] | [next] | [standalone]

#1464270 — Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks in

2016-08-16 2:05 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
> On Wed, Jul 06, 2016 at 03:11:13PM +0900, Daeseok Youn wrote:
>> The dgnc_block_til_ready() is only used in dgnc_tty_open().
>> The unit data(struct un_t) was stored into tty->driver_data in dgnc_tty_open().
>> And also tty and un were tested about NULL so these variables doesn't
>> need to check for NULL in dgnc_block_til_ready().
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>> ---
>> RESEND: This patch was not merged for a long time, if there is any reason
>> why this patch could NOT be merged into staging tree, let me know.
>> There were no comment for this patch.
>> I cannot understand why this patch have to wait long time to merge.
>> And I also sent emails to mailing-lists for reminding this patch...
>> please let me know, what is the problem to merge this patch into staging tree.
>
> Please note, staging patches are at the bottom of my priority queue.
> Combined with a vacation, conferences, and a merge window and there are
> a lot of pending staging patches in my to-review queue.

That's Ok. but I took a long time to wait for merging my patches in
this case. :-(

>
> thanks for your patience.
>
> greg k-h
Thanks.

Regards,
Daeseok Youn.

[toc] | [prev] | [next] | [standalone]

#1464339

On Wed, Aug 17, 2016 at 10:05:03AM +0900, DaeSeok Youn wrote:
> 2016-08-16 2:05 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
> > On Wed, Jul 06, 2016 at 03:11:13PM +0900, Daeseok Youn wrote:
> >> The dgnc_block_til_ready() is only used in dgnc_tty_open().
> >> The unit data(struct un_t) was stored into tty->driver_data in dgnc_tty_open().
> >> And also tty and un were tested about NULL so these variables doesn't
> >> need to check for NULL in dgnc_block_til_ready().
> >>
> >> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> >> ---
> >> RESEND: This patch was not merged for a long time, if there is any reason
> >> why this patch could NOT be merged into staging tree, let me know.
> >> There were no comment for this patch.
> >> I cannot understand why this patch have to wait long time to merge.
> >> And I also sent emails to mailing-lists for reminding this patch...
> >> please let me know, what is the problem to merge this patch into staging tree.
> >
> > Please note, staging patches are at the bottom of my priority queue.
> > Combined with a vacation, conferences, and a merge window and there are
> > a lot of pending staging patches in my to-review queue.
> 
> That's Ok. but I took a long time to wait for merging my patches in
> this case. :-(

You are not alone.  And what's the rush?  These are just trivial staging
driver patches, it's not like you have the hardware for this device and
are needing these patches to get it to work, right?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1464522 — Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks in

2016-08-17 15:25 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
> On Wed, Aug 17, 2016 at 10:05:03AM +0900, DaeSeok Youn wrote:
>> 2016-08-16 2:05 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
>> > On Wed, Jul 06, 2016 at 03:11:13PM +0900, Daeseok Youn wrote:
>> >> The dgnc_block_til_ready() is only used in dgnc_tty_open().
>> >> The unit data(struct un_t) was stored into tty->driver_data in dgnc_tty_open().
>> >> And also tty and un were tested about NULL so these variables doesn't
>> >> need to check for NULL in dgnc_block_til_ready().
>> >>
>> >> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>> >> ---
>> >> RESEND: This patch was not merged for a long time, if there is any reason
>> >> why this patch could NOT be merged into staging tree, let me know.
>> >> There were no comment for this patch.
>> >> I cannot understand why this patch have to wait long time to merge.
>> >> And I also sent emails to mailing-lists for reminding this patch...
>> >> please let me know, what is the problem to merge this patch into staging tree.
>> >
>> > Please note, staging patches are at the bottom of my priority queue.
>> > Combined with a vacation, conferences, and a merge window and there are
>> > a lot of pending staging patches in my to-review queue.
>>
>> That's Ok. but I took a long time to wait for merging my patches in
>> this case. :-(
>
> You are not alone.  And what's the rush?  These are just trivial staging
> driver patches, it's not like you have the hardware for this device and
> are needing these patches to get it to work, right?
yes, you're right.

Thanks.

Regards,
Daeseok Youn.
>
> thanks,
>
> greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web