Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1464323 > unrolled thread
| Started by | Rajendra Nayak <rnayak@codeaurora.org> |
|---|---|
| First post | 2016-08-17 07:30 +0200 |
| Last post | 2016-08-25 07:10 +0200 |
| Articles | 8 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH v3 0/5] dts patches for qcom tsens support Rajendra Nayak <rnayak@codeaurora.org> - 2016-08-17 07:30 +0200
[PATCH v3 1/5] arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes Rajendra Nayak <rnayak@codeaurora.org> - 2016-08-17 07:30 +0200
Re: [PATCH v3 0/5] dts patches for qcom tsens support Andy Gross <andy.gross@linaro.org> - 2016-08-17 21:40 +0200
Re: [PATCH v3 0/5] dts patches for qcom tsens support Paolo Pisati <p.pisati@gmail.com> - 2016-08-24 12:30 +0200
Re: [PATCH v3 0/5] dts patches for qcom tsens support "Nayak, Rajendra" <rnayak@codeaurora.org> - 2016-08-24 14:20 +0200
Re: [PATCH v3 0/5] dts patches for qcom tsens support Andy Gross <andy.gross@linaro.org> - 2016-08-25 00:10 +0200
Re: [PATCH v3 0/5] dts patches for qcom tsens support Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-25 07:10 +0200
Re: [PATCH v3 0/5] dts patches for qcom tsens support Andy Gross <andy.gross@linaro.org> - 2016-08-25 07:10 +0200
| From | Rajendra Nayak <rnayak@codeaurora.org> |
|---|---|
| Date | 2016-08-17 07:30 +0200 |
| Subject | [PATCH v3 0/5] dts patches for qcom tsens support |
| Message-ID | <s71Al-545-5@gated-at.bofh.it> |
Hey Andy, This is a respin of v2 with some minor fixes pointed out by Rob. Please pull these in for 4.9 Thanks, Rajendra Rajendra Nayak (5): arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes arm: dts: apq8064: Add thermal zones, tsens and qfprom nodes arm: dts: apq8084: Add thermal zones, tsens and qfprom nodes arm64: dts: msm8916: Add thermal zones, tsens and qfprom nodes arm64: dts: msm8996: Add thermal zones, tsens and qfprom nodes .../devicetree/bindings/clock/qcom,gcc.txt | 16 ++++ arch/arm/boot/dts/qcom-apq8064.dtsi | 103 +++++++++++++++++++++ arch/arm/boot/dts/qcom-apq8084.dtsi | 103 +++++++++++++++++++++ arch/arm/boot/dts/qcom-msm8974.dtsi | 103 +++++++++++++++++++++ arch/arm64/boot/dts/qcom/msm8916.dtsi | 64 +++++++++++++ arch/arm64/boot/dts/qcom/msm8996.dtsi | 92 ++++++++++++++++++ 6 files changed, 481 insertions(+) -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
[toc] | [next] | [standalone]
| From | Rajendra Nayak <rnayak@codeaurora.org> |
|---|---|
| Date | 2016-08-17 07:30 +0200 |
| Subject | [PATCH v3 1/5] arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes |
| Message-ID | <s71Am-545-15@gated-at.bofh.it> |
| In reply to | #1464323 |
Add thermal zones, tsens and qfprom nodes
Acked-by: Eduardo Valentin <edubezval@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 103 ++++++++++++++++++++++++++++++++++++
1 file changed, 103 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index 561d4d1..255c61a 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -131,6 +131,88 @@
};
};
+ thermal-zones {
+ cpu-thermal0 {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+
+ thermal-sensors = <&tsens 5>;
+
+ trips {
+ cpu_alert0: trip0 {
+ temperature = <75000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+ cpu_crit0: trip1 {
+ temperature = <110000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
+
+ cpu-thermal1 {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+
+ thermal-sensors = <&tsens 6>;
+
+ trips {
+ cpu_alert1: trip0 {
+ temperature = <75000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+ cpu_crit1: trip1 {
+ temperature = <110000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
+
+ cpu-thermal2 {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+
+ thermal-sensors = <&tsens 7>;
+
+ trips {
+ cpu_alert2: trip0 {
+ temperature = <75000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+ cpu_crit2: trip1 {
+ temperature = <110000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
+
+ cpu-thermal3 {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+
+ thermal-sensors = <&tsens 8>;
+
+ trips {
+ cpu_alert3: trip0 {
+ temperature = <75000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+ cpu_crit3: trip1 {
+ temperature = <110000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
+ };
+
cpu-pmu {
compatible = "qcom,krait-pmu";
interrupts = <1 7 0xf04>;
@@ -287,6 +369,27 @@
reg = <0xf9011000 0x1000>;
};
+ qfprom: qfprom@fc4bc000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "qcom,qfprom";
+ reg = <0xfc4bc000 0x1000>;
+ tsens_calib: calib@d0 {
+ reg = <0xd0 0x18>;
+ };
+ tsens_backup: backup@440 {
+ reg = <0x440 0x10>;
+ };
+ };
+
+ tsens: thermal-sensor@fc4a8000 {
+ compatible = "qcom,msm8974-tsens";
+ reg = <0xfc4a8000 0x2000>;
+ nvmem-cells = <&tsens_calib>, <&tsens_backup>;
+ nvmem-cell-names = "calib", "calib_backup";
+ #thermal-sensor-cells = <1>;
+ };
+
timer@f9020000 {
#address-cells = <1>;
#size-cells = <1>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
[toc] | [prev] | [next] | [standalone]
| From | Andy Gross <andy.gross@linaro.org> |
|---|---|
| Date | 2016-08-17 21:40 +0200 |
| Message-ID | <s7eQW-5ow-31@gated-at.bofh.it> |
| In reply to | #1464323 |
On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote: > Hey Andy, > > This is a respin of v2 with some minor fixes pointed out by Rob. > Please pull these in for 4.9 > > Thanks, > Rajendra I pulled these in. Andy
[toc] | [prev] | [next] | [standalone]
| From | Paolo Pisati <p.pisati@gmail.com> |
|---|---|
| Date | 2016-08-24 12:30 +0200 |
| Message-ID | <s9DBx-UW-49@gated-at.bofh.it> |
| In reply to | #1464748 |
On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
> On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
> > Hey Andy,
> >
> > This is a respin of v2 with some minor fixes pointed out by Rob.
> > Please pull these in for 4.9
> >
> > Thanks,
> > Rajendra
>
> I pulled these in.
Did you try to read the content of the qfprom from userspace?
$ uname -a
Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
aarch64 aarch64 GNU/Linux
$ lsmod
Module Size Used by
nvmem_qfprom 16384 0
nvmem_core 24576 1 nvmem_qfprom
$ ls -la /sys/bus/nvmem/devices/
total 0
drwxr-xr-x 2 root root 0 Aug 24 10:17 .
drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
../../../devices/platform/soc/5c000.qfprom/qfprom0
$ cat /sys/bus/nvmem/devices/qfprom0/nvmem
[spontaneous reboot]
This using agross's for-next tree as of today ("54ba896 Merge branch
'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
--
bye,
p.
[toc] | [prev] | [next] | [standalone]
| From | "Nayak, Rajendra" <rnayak@codeaurora.org> |
|---|---|
| Date | 2016-08-24 14:20 +0200 |
| Message-ID | <s9FjX-26D-3@gated-at.bofh.it> |
| In reply to | #1469316 |
On 8/24/2016 3:52 PM, Paolo Pisati wrote:
> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
>> On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
>>> Hey Andy,
>>>
>>> This is a respin of v2 with some minor fixes pointed out by Rob.
>>> Please pull these in for 4.9
>>>
>>> Thanks,
>>> Rajendra
>>
>> I pulled these in.
>
> Did you try to read the content of the qfprom from userspace?
Hi, no I haven't tried it, I can give it a try tomorrow when I
have access to my board and see whats going wrong, but I did
look at Andys for-next and the defconfig still does not have
either nvmem or qcom-qfprom drivers enabled.
Did you manually enable them? or are you seeing this with the drivers
still disabled?
>
> $ uname -a
> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
> aarch64 aarch64 GNU/Linux
> $ lsmod
> Module Size Used by
> nvmem_qfprom 16384 0
> nvmem_core 24576 1 nvmem_qfprom
> $ ls -la /sys/bus/nvmem/devices/
> total 0
> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
> ../../../devices/platform/soc/5c000.qfprom/qfprom0
> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem
>
> [spontaneous reboot]
>
> This using agross's for-next tree as of today ("54ba896 Merge branch
> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
>
[toc] | [prev] | [next] | [standalone]
| From | Andy Gross <andy.gross@linaro.org> |
|---|---|
| Date | 2016-08-25 00:10 +0200 |
| Message-ID | <s9OwV-dA-5@gated-at.bofh.it> |
| In reply to | #1469373 |
On 24 August 2016 at 07:18, Nayak, Rajendra <rnayak@codeaurora.org> wrote:
>
> On 8/24/2016 3:52 PM, Paolo Pisati wrote:
>>
>> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
>>>
>>> On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
>>>>
>>>> Hey Andy,
>>>>
>>>> This is a respin of v2 with some minor fixes pointed out by Rob.
>>>> Please pull these in for 4.9
>>>>
>>>> Thanks,
>>>> Rajendra
>>>
>>>
>>> I pulled these in.
>>
>>
>> Did you try to read the content of the qfprom from userspace?
>
>
> Hi, no I haven't tried it, I can give it a try tomorrow when I
> have access to my board and see whats going wrong, but I did
> look at Andys for-next and the defconfig still does not have
> either nvmem or qcom-qfprom drivers enabled.
> Did you manually enable them? or are you seeing this with the drivers still
> disabled?
I merged my for-next with the current next and enabled the options. I
reproduced Paolo's problem. It feels like either an access issue,
alignment issue (i tried ioread32 which didnt work). It fails
regardless of the TSENS being enabled.
>
>
>>
>> $ uname -a
>> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016
>> aarch64
>> aarch64 aarch64 GNU/Linux
>> $ lsmod
>> Module Size Used by
>> nvmem_qfprom 16384 0
>> nvmem_core 24576 1 nvmem_qfprom
>> $ ls -la /sys/bus/nvmem/devices/
>> total 0
>> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
>> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
>> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
>> ../../../devices/platform/soc/5c000.qfprom/qfprom0
>> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem
>>
>> [spontaneous reboot]
>>
>> This using agross's for-next tree as of today ("54ba896 Merge branch
>> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
>>
>
[toc] | [prev] | [next] | [standalone]
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Date | 2016-08-25 07:10 +0200 |
| Message-ID | <s9V5o-50Y-29@gated-at.bofh.it> |
| In reply to | #1469316 |
On Wed 24 Aug 03:22 PDT 2016, Paolo Pisati wrote:
> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
> > On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
> > > Hey Andy,
> > >
> > > This is a respin of v2 with some minor fixes pointed out by Rob.
> > > Please pull these in for 4.9
> > >
> > > Thanks,
> > > Rajendra
> >
> > I pulled these in.
>
> Did you try to read the content of the qfprom from userspace?
>
> $ uname -a
> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
> aarch64 aarch64 GNU/Linux
> $ lsmod
> Module Size Used by
> nvmem_qfprom 16384 0
> nvmem_core 24576 1 nvmem_qfprom
> $ ls -la /sys/bus/nvmem/devices/
> total 0
> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
> ../../../devices/platform/soc/5c000.qfprom/qfprom0
> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem
>
> [spontaneous reboot]
>
> This using agross's for-next tree as of today ("54ba896 Merge branch
> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
This was reported in some other forum as well, after some investigation
we concluded that it looks like one of the entries are locked down -
probably from some security reason.
I'm not aware of any way to query this configuration. But the main use
case for the qfprom is in-kernel access to certain elements and that we
do get from the driver as is...
Regards,
Bjorn
[toc] | [prev] | [next] | [standalone]
| From | Andy Gross <andy.gross@linaro.org> |
|---|---|
| Date | 2016-08-25 07:10 +0200 |
| Message-ID | <s9V5o-50Y-27@gated-at.bofh.it> |
| In reply to | #1469837 |
On 24 August 2016 at 22:13, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> On Wed 24 Aug 03:22 PDT 2016, Paolo Pisati wrote:
>
>> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
>> > On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
>> > > Hey Andy,
>> > >
>> > > This is a respin of v2 with some minor fixes pointed out by Rob.
>> > > Please pull these in for 4.9
>> > >
>> > > Thanks,
>> > > Rajendra
>> >
>> > I pulled these in.
>>
>> Did you try to read the content of the qfprom from userspace?
>>
>> $ uname -a
>> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
>> aarch64 aarch64 GNU/Linux
>> $ lsmod
>> Module Size Used by
>> nvmem_qfprom 16384 0
>> nvmem_core 24576 1 nvmem_qfprom
>> $ ls -la /sys/bus/nvmem/devices/
>> total 0
>> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
>> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
>> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
>> ../../../devices/platform/soc/5c000.qfprom/qfprom0
>> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem
>>
>> [spontaneous reboot]
>>
>> This using agross's for-next tree as of today ("54ba896 Merge branch
>> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
>
> This was reported in some other forum as well, after some investigation
> we concluded that it looks like one of the entries are locked down -
> probably from some security reason.
>
> I'm not aware of any way to query this configuration. But the main use
> case for the qfprom is in-kernel access to certain elements and that we
> do get from the driver as is...
Yeah this appears to be the case. So I guess the response is 'don't
do that'. At least don't cat or od the file. You need to seek and
read.
Andy
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web