Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462897 > unrolled thread

Re: [PATCH] iio: light: us5182d: Add missing error code assignment before test

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] iio: light: us5182d: Add missing error code assignment  before test Jonathan Cameron <jic23@kernel.org> - 2016-08-15 17:20 +0200

#1462897 — Re: [PATCH] iio: light: us5182d: Add missing error code assignment before test

On 10/08/16 06:18, Christophe JAILLET wrote:
> It is likely that checking the result of 'pm_runtime_set_active' is
> expected here.
> 
> Fixes: f0e5f57d3ac2 ("iio: light: us8152d: Add power management support")
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied to the togreg branch of iio.git. Initially pushed out as testing
for the autobuilders to play with it.

Whilst the fix is obviously correct, the missing assignment just results in
a particular error not being handled rather than a 'bug' as such. Hence
I'm sending this the slow route and it'll hit in the next merge window.

Thanks,

Jonathan
> ---
>  drivers/iio/light/us5182d.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c
> index 20c40f780964..18cf2e29e4d5 100644
> --- a/drivers/iio/light/us5182d.c
> +++ b/drivers/iio/light/us5182d.c
> @@ -894,7 +894,7 @@ static int us5182d_probe(struct i2c_client *client,
>  		goto out_err;
>  
>  	if (data->default_continuous) {
> -		pm_runtime_set_active(&client->dev);
> +		ret = pm_runtime_set_active(&client->dev);
>  		if (ret < 0)
>  			goto out_err;
>  	}
> 

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web