Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1461732 > unrolled thread

[PATCH] x86/power/64: Use __pa() for physical address computation

Back to article view | Back to linux.kernel

Contents

  [PATCH] x86/power/64: Use __pa() for physical address computation "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-14 11:10 +0200
    Re: [PATCH] x86/power/64: Use __pa() for physical address computation Ingo Molnar <mingo@kernel.org> - 2016-08-15 07:20 +0200

#1461732 — [PATCH] x86/power/64: Use __pa() for physical address computation

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

The value of temp_level4_pgt is the physical address of the
top-level page directory, so use __pa() to compute it.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 arch/x86/power/hibernate_64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pm/arch/x86/power/hibernate_64.c
===================================================================
--- linux-pm.orig/arch/x86/power/hibernate_64.c
+++ linux-pm/arch/x86/power/hibernate_64.c
@@ -113,7 +113,7 @@ static int set_up_temporary_mappings(voi
 			return result;
 	}
 
-	temp_level4_pgt = (unsigned long)pgd - __PAGE_OFFSET;
+	temp_level4_pgt = __pa(pgd);
 	return 0;
 }
 

[toc] | [next] | [standalone]

#1462555

* Rafael J. Wysocki <rjw@rjwysocki.net> wrote:

> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The value of temp_level4_pgt is the physical address of the
> top-level page directory, so use __pa() to compute it.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  arch/x86/power/hibernate_64.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-pm/arch/x86/power/hibernate_64.c
> ===================================================================
> --- linux-pm.orig/arch/x86/power/hibernate_64.c
> +++ linux-pm/arch/x86/power/hibernate_64.c
> @@ -113,7 +113,7 @@ static int set_up_temporary_mappings(voi
>  			return result;
>  	}
>  
> -	temp_level4_pgt = (unsigned long)pgd - __PAGE_OFFSET;
> +	temp_level4_pgt = __pa(pgd);
>  	return 0;
>  }

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web