Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463045 > unrolled thread

[PATCH 00/22] Remove deprecated create_workqueue instances

Started byBhaktipriya Shridhar <bhaktipriya96@gmail.com>
First post2016-08-15 20:00 +0200
Last post2016-08-19 17:50 +0200
Articles 20 on this page of 34 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
    [PATCH 01/22] IB/sa : Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
    [PATCH 03/22] IB/multicast: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
    [PATCH 02/22] IB/mad: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:00 +0200
    [PATCH 08/22] iw_cxgb3: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
      RE: [PATCH 08/22] iw_cxgb3: Remove deprecated create_singlethread_workqueue "Steve Wise" <swise@opengridcomputing.com> - 2016-08-16 20:20 +0200
    [PATCH 11/22] IB/mthca: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
    [PATCH 09/22] IB/qib: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
      RE: [PATCH 09/22] IB/qib: Remove deprecated  create_singlethread_workqueue "Marciniszyn, Mike" <mike.marciniszyn@intel.com> - 2016-08-16 19:40 +0200
    [PATCH 06/22] IB/addr: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
    [PATCH 10/22] iw_cxgb4: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
      RE: [PATCH 10/22] iw_cxgb4: Remove deprecated create_singlethread_workqueue "Steve Wise" <swise@opengridcomputing.com> - 2016-08-16 20:20 +0200
    [PATCH 07/22] IB/iwcm: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:10 +0200
      RE: [PATCH 07/22] IB/iwcm: Remove deprecated create_singlethread_workqueue "Steve Wise" <swise@opengridcomputing.com> - 2016-08-16 20:30 +0200
    [PATCH 15/22] IB/mlx5/odp: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 15/22] IB/mlx5/odp: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
    [PATCH 19/22] IB/nes: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    [PATCH 16/22] IB/mlx4: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 16/22] IB/mlx4: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
    [PATCH 18/22] IB/mlx4/mcg: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 18/22] IB/mlx4/mcg: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 18:00 +0200
    [PATCH 12/22] i40iw_main: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    [PATCH 17/22] IB/mlx4/mad: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 17/22] IB/mlx4/mad: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 18:00 +0200
    [PATCH 20/22] IB/ipoib: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    [PATCH 13/22] i40iw_cm: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    [PATCH 21/22] IB/ipoib_verbs: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
    [PATCH 14/22] IB/mlx5: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 14/22] IB/mlx5: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
      Re: [PATCH 14/22] IB/mlx5: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200
    [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-15 20:20 +0200
      Re: [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 18:00 +0200
    Re: [PATCH 00/22] Remove deprecated create_workqueue instances Tejun Heo <tj@kernel.org> - 2016-08-16 01:20 +0200
    Re: [PATCH 00/22] Remove deprecated create_workqueue instances Leon Romanovsky <leonro@mellanox.com> - 2016-08-19 17:50 +0200

Page 1 of 2  [1] 2  Next page →

#1463045 — [PATCH 00/22] Remove deprecated create_workqueue instances

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:00 +0200
Subject[PATCH 00/22] Remove deprecated create_workqueue instances
Message-ID<s6ul3-d0-3@gated-at.bofh.it>
This patch set removes the instances of deprecated
create_singlethread_workqueue (scheduled for removal) in
drivers/infiniband by making the appropriate conversions.

Bhaktipriya Shridhar (22):
  IB/sa : Remove deprecated create_singlethread_workqueue
  IB/mad: Remove deprecated create_singlethread_workqueue
  IB/multicast: Remove deprecated create_singlethread_workqueue
  IB/ucma: Remove deprecated create_singlethread_workqueue
  IB/cma: Remove deprecated create_singlethread_workqueue
  IB/addr: Remove deprecated create_singlethread_workqueue
  IB/iwcm: Remove deprecated create_singlethread_workqueue
  iw_cxgb3: Remove deprecated create_singlethread_workqueue
  IB/qib: Remove deprecated create_singlethread_workqueue
  iw_cxgb4: Remove deprecated create_singlethread_workqueue
  IB/mthca: Remove deprecated create_singlethread_workqueue
  i40iw_main: Remove deprecated create_singlethread_workqueue
  i40iw_cm: Remove deprecated create_singlethread_workqueue
  IB/mlx5: Remove deprecated create_singlethread_workqueue
  IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
  IB/mlx4: Remove deprecated create_singlethread_workqueue
  IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
  IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
  IB/nes: Remove deprecated create_singlethread_workqueue
  IB/ipoib: Remove deprecated create_singlethread_workqueue
  IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
  IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue

 drivers/infiniband/core/addr.c             | 2 +-
 drivers/infiniband/core/cma.c              | 2 +-
 drivers/infiniband/core/iwcm.c             | 2 +-
 drivers/infiniband/core/mad.c              | 2 +-
 drivers/infiniband/core/multicast.c        | 2 +-
 drivers/infiniband/core/sa_query.c         | 2 +-
 drivers/infiniband/core/ucma.c             | 3 ++-
 drivers/infiniband/hw/cxgb3/iwch_cm.c      | 2 +-
 drivers/infiniband/hw/cxgb4/cm.c           | 2 +-
 drivers/infiniband/hw/i40iw/i40iw_cm.c     | 7 +++++--
 drivers/infiniband/hw/i40iw/i40iw_main.c   | 2 +-
 drivers/infiniband/hw/mlx4/alias_GUID.c    | 2 +-
 drivers/infiniband/hw/mlx4/mad.c           | 4 ++--
 drivers/infiniband/hw/mlx4/main.c          | 2 +-
 drivers/infiniband/hw/mlx4/mcg.c           | 4 ++--
 drivers/infiniband/hw/mlx5/mr.c            | 2 +-
 drivers/infiniband/hw/mlx5/odp.c           | 4 ++--
 drivers/infiniband/hw/mthca/mthca_catas.c  | 2 +-
 drivers/infiniband/hw/nes/nes_cm.c         | 4 ++--
 drivers/infiniband/hw/qib/qib_init.c       | 4 ++--
 drivers/infiniband/ulp/ipoib/ipoib_main.c  | 3 ++-
 drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 2 +-
 22 files changed, 33 insertions(+), 28 deletions(-)

--
2.1.4

[toc] | [next] | [standalone]

#1463047 — [PATCH 01/22] IB/sa : Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:00 +0200
Subject[PATCH 01/22] IB/sa : Remove deprecated create_singlethread_workqueue
Message-ID<s6ul4-d0-19@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "ib_nl" queues work item &ib_nl_timed_work. It has been
identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/core/sa_query.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/sa_query.c b/drivers/infiniband/core/sa_query.c
index e955386..6559199 100644
--- a/drivers/infiniband/core/sa_query.c
+++ b/drivers/infiniband/core/sa_query.c
@@ -1974,7 +1974,7 @@ int ib_sa_init(void)
 		goto err2;
 	}

-	ib_nl_wq = create_singlethread_workqueue("ib_nl_sa_wq");
+	ib_nl_wq = alloc_ordered_workqueue("ib_nl_sa_wq", WQ_MEM_RECLAIM);
 	if (!ib_nl_wq) {
 		ret = -ENOMEM;
 		goto err3;
--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1463052 — [PATCH 03/22] IB/multicast: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:00 +0200
Subject[PATCH 03/22] IB/multicast: Remove deprecated create_singlethread_workqueue
Message-ID<s6ul4-d0-35@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "mcast_wq" queues work item &group->work. It has been
identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/core/multicast.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/multicast.c b/drivers/infiniband/core/multicast.c
index a83ec28..002a85c 100644
--- a/drivers/infiniband/core/multicast.c
+++ b/drivers/infiniband/core/multicast.c
@@ -894,7 +894,7 @@ int mcast_init(void)
 {
 	int ret;

-	mcast_wq = create_singlethread_workqueue("ib_mcast");
+	mcast_wq = alloc_ordered_workqueue("ib_mcast", WQ_MEM_RECLAIM);
 	if (!mcast_wq)
 		return -ENOMEM;

--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1463054 — [PATCH 02/22] IB/mad: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:00 +0200
Subject[PATCH 02/22] IB/mad: Remove deprecated create_singlethread_workqueue
Message-ID<s6ul4-d0-37@gated-at.bofh.it>
In reply to#1463045
The workqueue "ib_nl" queues work items &ib_nl_timed_work and
&mad_agent_priv->local_work. It has been identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/core/mad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c
index 2d49228..d882868 100644
--- a/drivers/infiniband/core/mad.c
+++ b/drivers/infiniband/core/mad.c
@@ -3177,7 +3177,7 @@ static int ib_mad_port_open(struct ib_device *device,
 		goto error7;

 	snprintf(name, sizeof name, "ib_mad%d", port_num);
-	port_priv->wq = create_singlethread_workqueue(name);
+	port_priv->wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
 	if (!port_priv->wq) {
 		ret = -ENOMEM;
 		goto error8;
--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1463056 — [PATCH 08/22] iw_cxgb3: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:10 +0200
Subject[PATCH 08/22] iw_cxgb3: Remove deprecated create_singlethread_workqueue
Message-ID<s6uuJ-vA-7@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "workq" queues work item &skb_work. It has been
identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/cxgb3/iwch_cm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index 3e8431b..1ce4e6b 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -2258,7 +2258,7 @@ int __init iwch_cm_init(void)
 {
 	skb_queue_head_init(&rxq);

-	workq = create_singlethread_workqueue("iw_cxgb3");
+	workq = alloc_ordered_workqueue("iw_cxgb3", WQ_MEM_RECLAIM);
 	if (!workq)
 		return -ENOMEM;

--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1464002 — RE: [PATCH 08/22] iw_cxgb3: Remove deprecated create_singlethread_workqueue

From"Steve Wise" <swise@opengridcomputing.com>
Date2016-08-16 20:20 +0200
SubjectRE: [PATCH 08/22] iw_cxgb3: Remove deprecated create_singlethread_workqueue
Message-ID<s6R7Z-6tU-41@gated-at.bofh.it>
In reply to#1463056
> 
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "workq" queues work item &skb_work. It has been
> identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Acked-by: Steve Wise <swise@opengridcomputing.com>

[toc] | [prev] | [next] | [standalone]

#1463062 — [PATCH 11/22] IB/mthca: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:10 +0200
Subject[PATCH 11/22] IB/mthca: Remove deprecated create_singlethread_workqueue
Message-ID<s6uuK-vA-27@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "catas_wq" in triggering a device remove and causing a
device reset when a catastrophic error occurs. It has been identity
converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/mthca/mthca_catas.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mthca/mthca_catas.c b/drivers/infiniband/hw/mthca/mthca_catas.c
index 712d2a3..f6474c2 100644
--- a/drivers/infiniband/hw/mthca/mthca_catas.c
+++ b/drivers/infiniband/hw/mthca/mthca_catas.c
@@ -187,7 +187,7 @@ int __init mthca_catas_init(void)
 {
 	INIT_WORK(&catas_work, catas_reset);

-	catas_wq = create_singlethread_workqueue("mthca_catas");
+	catas_wq = alloc_ordered_workqueue("mthca_catas", WQ_MEM_RECLAIM);
 	if (!catas_wq)
 		return -ENOMEM;

--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1463063 — [PATCH 09/22] IB/qib: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:10 +0200
Subject[PATCH 09/22] IB/qib: Remove deprecated create_singlethread_workqueue
Message-ID<s6uuK-vA-45@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "qib" queues work item &priv->s_work. It has been
identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/qib/qib_init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
index f253111..1730aa8 100644
--- a/drivers/infiniband/hw/qib/qib_init.c
+++ b/drivers/infiniband/hw/qib/qib_init.c
@@ -614,8 +614,8 @@ static int qib_create_workqueues(struct qib_devdata *dd)

 			snprintf(wq_name, sizeof(wq_name), "qib%d_%d",
 				dd->unit, pidx);
-			ppd->qib_wq =
-				create_singlethread_workqueue(wq_name);
+			ppd->qib_wq = alloc_ordered_workqueue(wq_name,
+							      WQ_MEM_RECLAIM);
 			if (!ppd->qib_wq)
 				goto wq_error;
 		}
--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1463964 — RE: [PATCH 09/22] IB/qib: Remove deprecated create_singlethread_workqueue

From"Marciniszyn, Mike" <mike.marciniszyn@intel.com>
Date2016-08-16 19:40 +0200
SubjectRE: [PATCH 09/22] IB/qib: Remove deprecated create_singlethread_workqueue
Message-ID<s6Qvg-61D-19@gated-at.bofh.it>
In reply to#1463063
> Subject: [PATCH 09/22] IB/qib: Remove deprecated
> create_singlethread_workqueue
> 

Looks and tests good!

Tested-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>

[toc] | [prev] | [next] | [standalone]

#1463064 — [PATCH 06/22] IB/addr: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:10 +0200
Subject[PATCH 06/22] IB/addr: Remove deprecated create_singlethread_workqueue
Message-ID<s6uuK-vA-41@gated-at.bofh.it>
In reply to#1463045
The workqueue "addr_wq" queues a single work item &work and hence
doesn't require ordering. Also, it is being used on a memory reclaim
path. Hence, it has been converted to use alloc_workqueue with
WQ_MEM_RECLAIM set.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/core/addr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index 1374541..b136d3a 100644
--- a/drivers/infiniband/core/addr.c
+++ b/drivers/infiniband/core/addr.c
@@ -800,7 +800,7 @@ static struct notifier_block nb = {

 int addr_init(void)
 {
-	addr_wq = create_singlethread_workqueue("ib_addr");
+	addr_wq = alloc_workqueue("ib_addr", WQ_MEM_RECLAIM, 0);
 	if (!addr_wq)
 		return -ENOMEM;

--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1463065 — [PATCH 10/22] iw_cxgb4: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:10 +0200
Subject[PATCH 10/22] iw_cxgb4: Remove deprecated create_singlethread_workqueue
Message-ID<s6uuK-vA-33@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "workq" queues work item &skb_work. It has been
identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/cxgb4/cm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index a3a6721..6438b4c 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -4282,7 +4282,7 @@ int __init c4iw_cm_init(void)
 	spin_lock_init(&timeout_lock);
 	skb_queue_head_init(&rxq);

-	workq = create_singlethread_workqueue("iw_cxgb4");
+	workq = alloc_ordered_workqueue("iw_cxgb4", WQ_MEM_RECLAIM);
 	if (!workq)
 		return -ENOMEM;

--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1464000 — RE: [PATCH 10/22] iw_cxgb4: Remove deprecated create_singlethread_workqueue

From"Steve Wise" <swise@opengridcomputing.com>
Date2016-08-16 20:20 +0200
SubjectRE: [PATCH 10/22] iw_cxgb4: Remove deprecated create_singlethread_workqueue
Message-ID<s6R7Y-6tU-31@gated-at.bofh.it>
In reply to#1463065
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "workq" queues work item &skb_work. It has been
> identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Acked-by: Steve Wise <swise@opengridcomputing.com>

[toc] | [prev] | [next] | [standalone]

#1463067 — [PATCH 07/22] IB/iwcm: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:10 +0200
Subject[PATCH 07/22] IB/iwcm: Remove deprecated create_singlethread_workqueue
Message-ID<s6uuK-vA-39@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "iwcm_wq" queues work item &work(maps to cm_work_handler).
It has been identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/core/iwcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/iwcm.c b/drivers/infiniband/core/iwcm.c
index f057204..d6b5224 100644
--- a/drivers/infiniband/core/iwcm.c
+++ b/drivers/infiniband/core/iwcm.c
@@ -1180,7 +1180,7 @@ static int __init iw_cm_init(void)
 	if (ret)
 		pr_err("iw_cm: couldn't register netlink callbacks\n");

-	iwcm_wq = create_singlethread_workqueue("iw_cm_wq");
+	iwcm_wq = alloc_ordered_workqueue("iw_cm_wq", WQ_MEM_RECLAIM);
 	if (!iwcm_wq)
 		return -ENOMEM;

--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1464005 — RE: [PATCH 07/22] IB/iwcm: Remove deprecated create_singlethread_workqueue

From"Steve Wise" <swise@opengridcomputing.com>
Date2016-08-16 20:30 +0200
SubjectRE: [PATCH 07/22] IB/iwcm: Remove deprecated create_singlethread_workqueue
Message-ID<s6RhD-6xt-9@gated-at.bofh.it>
In reply to#1463067
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "iwcm_wq" queues work item &work(maps to cm_work_handler).
> It has been identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Looks fine.

Reviewed-by: Steve Wise <swise@opengridcomputing.com>

[toc] | [prev] | [next] | [standalone]

#1463069 — [PATCH 15/22] IB/mlx5/odp: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:20 +0200
Subject[PATCH 15/22] IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
Message-ID<s6uEp-z8-1@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "mlx5_ib_page_fault_wq" queues work item &qp_pfault->work.
It has been identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/mlx5/odp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/odp.c b/drivers/infiniband/hw/mlx5/odp.c
index 34e79e7..cacb631 100644
--- a/drivers/infiniband/hw/mlx5/odp.c
+++ b/drivers/infiniband/hw/mlx5/odp.c
@@ -782,8 +782,8 @@ void mlx5_ib_odp_remove_one(struct mlx5_ib_dev *ibdev)

 int __init mlx5_ib_odp_init(void)
 {
-	mlx5_ib_page_fault_wq =
-		create_singlethread_workqueue("mlx5_ib_page_faults");
+	mlx5_ib_page_fault_wq = alloc_ordered_workqueue("mlx5_ib_page_faults",
+							WQ_MEM_RECLAIM);
 	if (!mlx5_ib_page_fault_wq)
 		return -ENOMEM;

--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1466514 — Re: [PATCH 15/22] IB/mlx5/odp: Remove deprecated create_singlethread_workqueue

FromLeon Romanovsky <leonro@mellanox.com>
Date2016-08-19 17:50 +0200
SubjectRe: [PATCH 15/22] IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
Message-ID<s7Uds-7rO-33@gated-at.bofh.it>
In reply to#1463069

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 15, 2016 at 11:42:19PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "mlx5_ib_page_fault_wq" queues work item &qp_pfault->work.
> It has been identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>

> ---
>  drivers/infiniband/hw/mlx5/odp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx5/odp.c b/drivers/infiniband/hw/mlx5/odp.c
> index 34e79e7..cacb631 100644
> --- a/drivers/infiniband/hw/mlx5/odp.c
> +++ b/drivers/infiniband/hw/mlx5/odp.c
> @@ -782,8 +782,8 @@ void mlx5_ib_odp_remove_one(struct mlx5_ib_dev *ibdev)
> 
>  int __init mlx5_ib_odp_init(void)
>  {
> -	mlx5_ib_page_fault_wq =
> -		create_singlethread_workqueue("mlx5_ib_page_faults");
> +	mlx5_ib_page_fault_wq = alloc_ordered_workqueue("mlx5_ib_page_faults",
> +							WQ_MEM_RECLAIM);
>  	if (!mlx5_ib_page_fault_wq)
>  		return -ENOMEM;
> 
> --
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1463070 — [PATCH 19/22] IB/nes: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:20 +0200
Subject[PATCH 19/22] IB/nes: Remove deprecated create_singlethread_workqueue
Message-ID<s6uEp-z8-3@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() replaces deprecated
create_singlethread_workqueue().

The workqueue "event_wq" queues work item &event->event_work and the
workqueue "disconn_wq" queues work item work (maps to
g_cm_core->disconn_wq).

WQ_MEM_RECLAIM has not been set since the workqueues are not being used
on a memory reclaim path.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/nes/nes_cm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
index 7f0aa23..57db9b3 100644
--- a/drivers/infiniband/hw/nes/nes_cm.c
+++ b/drivers/infiniband/hw/nes/nes_cm.c
@@ -2692,12 +2692,12 @@ static struct nes_cm_core *nes_cm_alloc_core(void)
 	nes_debug(NES_DBG_CM, "Init CM Core completed -- cm_core=%p\n", cm_core);

 	nes_debug(NES_DBG_CM, "Enable QUEUE EVENTS\n");
-	cm_core->event_wq = create_singlethread_workqueue("nesewq");
+	cm_core->event_wq = alloc_ordered_workqueue("nesewq", 0);
 	if (!cm_core->event_wq)
 		goto out_free_cmcore;
 	cm_core->post_event = nes_cm_post_event;
 	nes_debug(NES_DBG_CM, "Enable QUEUE DISCONNECTS\n");
-	cm_core->disconn_wq = create_singlethread_workqueue("nesdwq");
+	cm_core->disconn_wq = alloc_ordered_workqueue("nesdwq", 0);
 	if (!cm_core->disconn_wq)
 		goto out_free_wq;

--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1463072 — [PATCH 16/22] IB/mlx4: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:20 +0200
Subject[PATCH 16/22] IB/mlx4: Remove deprecated create_singlethread_workqueue
Message-ID<s6uEp-z8-5@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "wq" queues work items &dm[i]->work, &ew->work.
It has been identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/mlx4/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index 42a4607..f3876b79 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -3023,7 +3023,7 @@ static int __init mlx4_ib_init(void)
 {
 	int err;

-	wq = create_singlethread_workqueue("mlx4_ib");
+	wq = alloc_ordered_workqueue("mlx4_ib", WQ_MEM_RECLAIM);
 	if (!wq)
 		return -ENOMEM;

--
2.1.4

[toc] | [prev] | [next] | [standalone]

#1466513 — Re: [PATCH 16/22] IB/mlx4: Remove deprecated create_singlethread_workqueue

FromLeon Romanovsky <leonro@mellanox.com>
Date2016-08-19 17:50 +0200
SubjectRe: [PATCH 16/22] IB/mlx4: Remove deprecated create_singlethread_workqueue
Message-ID<s7Uds-7rO-31@gated-at.bofh.it>
In reply to#1463072

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 15, 2016 at 11:42:48PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "wq" queues work items &dm[i]->work, &ew->work.
> It has been identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
>  drivers/infiniband/hw/mlx4/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

[toc] | [prev] | [next] | [standalone]

#1463077 — [PATCH 18/22] IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue

FromBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date2016-08-15 20:20 +0200
Subject[PATCH 18/22] IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
Message-ID<s6uEq-z8-25@gated-at.bofh.it>
In reply to#1463045
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "mcg_wq" queues work items &group->work
and &group->timeout_work.

The workqueue "clean_wq" queues work item mcg_clean_task.

Both have been identity converted.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/infiniband/hw/mlx4/mcg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/mlx4/mcg.c b/drivers/infiniband/hw/mlx4/mcg.c
index 8f7ad07..7d30be0 100644
--- a/drivers/infiniband/hw/mlx4/mcg.c
+++ b/drivers/infiniband/hw/mlx4/mcg.c
@@ -1045,7 +1045,7 @@ int mlx4_ib_mcg_port_init(struct mlx4_ib_demux_ctx *ctx)

 	atomic_set(&ctx->tid, 0);
 	sprintf(name, "mlx4_ib_mcg%d", ctx->port);
-	ctx->mcg_wq = create_singlethread_workqueue(name);
+	ctx->mcg_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
 	if (!ctx->mcg_wq)
 		return -ENOMEM;

@@ -1246,7 +1246,7 @@ void clean_vf_mcast(struct mlx4_ib_demux_ctx *ctx, int slave)

 int mlx4_ib_mcg_init(void)
 {
-	clean_wq = create_singlethread_workqueue("mlx4_ib_mcg");
+	clean_wq = alloc_ordered_workqueue("mlx4_ib_mcg", WQ_MEM_RECLAIM);
 	if (!clean_wq)
 		return -ENOMEM;

--
2.1.4

[toc] | [prev] | [next] | [standalone]

Page 1 of 2  [1] 2  Next page →

Back to top | Article view | linux.kernel

csiph-web