Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1464011 > unrolled thread
| Started by | Mark Brown <broonie@kernel.org> |
|---|---|
| First post | 2016-08-16 20:50 +0200 |
| Last post | 2016-08-17 07:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5] spi: spi-ti-qspi: Add DMA support for QSPI mmap read Mark Brown <broonie@kernel.org> - 2016-08-16 20:50 +0200
Re: [PATCH v5] spi: spi-ti-qspi: Add DMA support for QSPI mmap read Vignesh R <vigneshr@ti.com> - 2016-08-17 07:20 +0200
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2016-08-16 20:50 +0200 |
| Subject | Re: [PATCH v5] spi: spi-ti-qspi: Add DMA support for QSPI mmap read |
| Message-ID | <s6RAZ-6EN-3@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Aug 09, 2016 at 06:20:01PM +0530, Vignesh R wrote: > > > According to this thread[1], converting virtual address > pointer into scatterlist which is then DMA mapped is unsafe on systems > with certain cache architecture. Hence, I added code to handle kmap > buffers inside the driver rather than updating generic spi-core code. That's saying that things that aren't covered aren't DMAable safely at all which is a more general issue... > If its okay to update the spi_map_buf() to handle kmap buffers as above > then I can submit the patch accordingly. Yes, the whole point is that this is all in generic code so drivers don't need to worry about it.
[toc] | [next] | [standalone]
| From | Vignesh R <vigneshr@ti.com> |
|---|---|
| Date | 2016-08-17 07:20 +0200 |
| Message-ID | <s71qG-4Z2-13@gated-at.bofh.it> |
| In reply to | #1464011 |
On Wednesday 17 August 2016 12:12 AM, Mark Brown wrote: > On Tue, Aug 09, 2016 at 06:20:01PM +0530, Vignesh R wrote: >> >> > >> According to this thread[1], converting virtual address >> pointer into scatterlist which is then DMA mapped is unsafe on systems >> with certain cache architecture. Hence, I added code to handle kmap >> buffers inside the driver rather than updating generic spi-core code. > > That's saying that things that aren't covered aren't DMAable safely at > all which is a more general issue... > >> If its okay to update the spi_map_buf() to handle kmap buffers as above >> then I can submit the patch accordingly. > > Yes, the whole point is that this is all in generic code so drivers > don't need to worry about it. Ok, I will send another version updating spi_map_buf() to handle kmap buffers. Thanks! -- Regards Vignesh
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web