Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463193 > unrolled thread

Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support Andrew Lunn <andrew@lunn.ch> - 2016-08-15 23:40 +0200
    Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support Andrew Lunn <andrew@lunn.ch> - 2016-08-16 18:20 +0200

#1463193 — Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
> ---
> Thanks a lot Andrew for your inputs.
> Changes for v5:
> --> Fixed return values in the probe as suggested by punnaiah.
> --> Added a mask for the converter speed as suggested by punnaiah.
> +/* Xilinx GMII2RGMII Converter driver
> + *
> + * Copyright (C) 2016 Xilinx, Inc.
> + *
> + * Author: Kedareswara rao Appana <appanad@xilinx.com>

Not cool

https://github.com/lunn/linux/commit/03d375489ceb56e171056f44d0fe9c34ca5a098e

Notice the

Not-Signed-off-by: Andrew Lunn <andrew@lunn.ch>

and the Copyright i added?

In various emails i gave you the basic idea how this should be done, a
framework of code, and then took your code which did not even compile
and made the core of it work. This is as much my code as your code, so
i expect my Copyright to be kept on this code. And since this is my
code, i need to give a Signed-off-by, which i was not yet ready to
give since the code was not complete or working.

Please put both my Copyright back and Not-Signed-Off-by back and post
the next version as RFC. Once i'm happy this code is O.K, i will give
you a Signed-off-by.

    Andrew

[toc] | [next] | [standalone]

#1463924

> > https://github.com/lunn/linux/commit/03d375489ceb56e171056f44d0fe9c34ca
> > 5a098e
> > 
> > Notice the
> > 
> > Not-Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > 
> > and the Copyright i added?
> > 
> > In various emails i gave you the basic idea how this should be done, a framework
> > of code, and then took your code which did not even compile and made the core
> > of it work. This is as much my code as your code, so i expect my Copyright to be
> > kept on this code. And since this is my code, i need to give a Signed-off-by,
> > which i was not yet ready to give since the code was not complete or working.
> > 
> > Please put both my Copyright back and Not-Signed-Off-by back and post the
> > next version as RFC. Once i'm happy this code is O.K, i will give you a Signed-off-
> > by.
> 
> Sorry I should have been included your copyright.
> 
> I missed it...
> I didn't included your SOF because.
> AFAIK without explicit permission of the other person we shouldn't include SOF.
> That's why I didn't included your SOF and thanked for your efforts after SOF.
> Sorry if my understanding is wrong.

Without a SOB you cannot submit the patch for inclusion at all. You
should however reproduce tags which have been given, i.e. you should
of kept my Not-Signed-Off-by: making it clear i have not yet given
permission for this code to go into mainline.

	   Andrew

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web