Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463681 > unrolled thread

Re: [PATCH v2 03/10] usb: ulpi: use new api functions if available

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 03/10] usb: ulpi: use new api functions if available Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-08-16 13:00 +0200

#1463681 — Re: [PATCH v2 03/10] usb: ulpi: use new api functions if available

Hi,

On Mon, Aug 01, 2016 at 09:15:51PM +0300, Tal Shorer wrote:
> If the registered has the new api callbacks {read|write}_dev, call
> these instead of the deprecated read, write functions. If the
> registered does not support the new callbacks, revert to calling the
> old ones as before.
> 
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
>  drivers/usb/common/ulpi.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
> index d1f419c..a877ddb 100644
> --- a/drivers/usb/common/ulpi.c
> +++ b/drivers/usb/common/ulpi.c
> @@ -21,13 +21,17 @@
>  
>  int ulpi_read(struct ulpi *ulpi, u8 addr)
>  {
> -	return ulpi->ops->read(ulpi->ops, addr);
> +	if (!ulpi->ops->read_dev)
> +		return ulpi->ops->read(ulpi->ops, addr);
> +	return ulpi->ops->read_dev(ulpi->dev.parent, addr);
>  }
>  EXPORT_SYMBOL_GPL(ulpi_read);
>  
>  int ulpi_write(struct ulpi *ulpi, u8 addr, u8 val)
>  {
> -	return ulpi->ops->write(ulpi->ops, addr, val);
> +	if (!ulpi->ops->write_dev)
> +		return ulpi->ops->write(ulpi->ops, addr, val);
> +	return ulpi->ops->write_dev(ulpi->dev.parent, addr, val);
>  }
>  EXPORT_SYMBOL_GPL(ulpi_write);
>  
> -- 
> 2.7.4

Squash patches 2-3 into one patch.

Thanks,

-- 
heikki

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web