Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1463372 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2016-08-16 05:10 +0200 |
| Last post | 2016-08-22 23:30 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] Input: tegra-kbc: fix inverted reset logic Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-16 05:10 +0200
Re: [PATCH] Input: tegra-kbc: fix inverted reset logic Thierry Reding <thierry.reding@gmail.com> - 2016-08-16 12:30 +0200
Re: [PATCH] Input: tegra-kbc: fix inverted reset logic Laxman Dewangan <ldewangan@nvidia.com> - 2016-08-16 13:40 +0200
Re: [PATCH] Input: tegra-kbc: fix inverted reset logic Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-22 23:30 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2016-08-16 05:10 +0200 |
| Subject | [PATCH] Input: tegra-kbc: fix inverted reset logic |
| Message-ID | <s6CVj-61Y-1@gated-at.bofh.it> |
Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
accidentally converted _deassert to _assert, so there is no code
to wake up this hardware.
Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/input/keyboard/tegra-kbc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index 7d61439..0c07e10 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc)
/* Reset the KBC controller to clear all previous status.*/
reset_control_assert(kbc->rst);
udelay(100);
- reset_control_assert(kbc->rst);
+ reset_control_deassert(kbc->rst);
udelay(100);
tegra_kbc_config_pins(kbc);
--
1.9.1
[toc] | [next] | [standalone]
| From | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| Date | 2016-08-16 12:30 +0200 |
| Message-ID | <s6JN8-1Ri-25@gated-at.bofh.it> |
| In reply to | #1463372 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Aug 16, 2016 at 11:59:23AM +0900, Masahiro Yamada wrote:
> Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> accidentally converted _deassert to _assert, so there is no code
> to wake up this hardware.
>
> Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/input/keyboard/tegra-kbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Nice catch!
Acked-by: Thierry Reding <treding@nvidia.com>
[toc] | [prev] | [next] | [standalone]
| From | Laxman Dewangan <ldewangan@nvidia.com> |
|---|---|
| Date | 2016-08-16 13:40 +0200 |
| Message-ID | <s6KSS-2v8-37@gated-at.bofh.it> |
| In reply to | #1463372 |
On Tuesday 16 August 2016 08:29 AM, Masahiro Yamada wrote:
> Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> accidentally converted _deassert to _assert, so there is no code
> to wake up this hardware.
>
> Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-08-22 23:30 +0200 |
| Message-ID | <s94X8-3dH-21@gated-at.bofh.it> |
| In reply to | #1463372 |
On Tue, Aug 16, 2016 at 11:59:23AM +0900, Masahiro Yamada wrote:
> Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> accidentally converted _deassert to _assert, so there is no code
> to wake up this hardware.
>
> Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied, thank you.
> ---
>
> drivers/input/keyboard/tegra-kbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index 7d61439..0c07e10 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc)
> /* Reset the KBC controller to clear all previous status.*/
> reset_control_assert(kbc->rst);
> udelay(100);
> - reset_control_assert(kbc->rst);
> + reset_control_deassert(kbc->rst);
> udelay(100);
>
> tegra_kbc_config_pins(kbc);
> --
> 1.9.1
>
--
Dmitry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web