Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462774 > unrolled thread

[PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property

Started byGuenter Roeck <linux@roeck-us.net>
First post2016-08-15 15:20 +0200
Last post2016-08-18 02:50 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property Guenter Roeck <linux@roeck-us.net> - 2016-08-15 15:20 +0200
    Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property Chanwoo Choi <cw00.choi@samsung.com> - 2016-08-16 03:00 +0200
      Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property Guenter Roeck <groeck@google.com> - 2016-08-16 03:50 +0200
        Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property Guenter Roeck <groeck@google.com> - 2016-08-18 02:50 +0200
          Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property Chanwoo Choi <cw00.choi@samsung.com> - 2016-08-18 03:30 +0200
        Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property Chanwoo Choi <cw00.choi@samsung.com> - 2016-08-18 02:50 +0200

#1462774 — [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property

FromGuenter Roeck <linux@roeck-us.net>
Date2016-08-15 15:20 +0200
Subject[PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property
Message-ID<s6pY6-65c-9@gated-at.bofh.it>
From: Guenter Roeck <groeck@chromium.org>

EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2
and USB3 connections on USB Type-C cables.

Cc: Chris Zhong <zyw@rock-chips.com>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
---
Applies on top of extcon-next.

 include/linux/extcon.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/include/linux/extcon.h b/include/linux/extcon.h
index ad7a1606a7f3..38d2c0dec2c1 100644
--- a/include/linux/extcon.h
+++ b/include/linux/extcon.h
@@ -107,12 +107,18 @@
  * @type:	integer (intval)
  * @value:	0 (normal) or 1 (flip)
  * @default:	0 (normal)
+ * - EXTCON_PROP_USB_SUPERSPEED
+ * @type:       integer (intval)
+ * @value:      0 (USB/USB2) or 1 (USB3)
+ * @default:    0 (USB/USB2)
+ *
  */
 #define EXTCON_PROP_USB_VBUS		0
 #define EXTCON_PROP_USB_TYPEC_POLARITY	1
+#define EXTCON_PROP_USB_SUPERSPEED	2
 
 #define EXTCON_PROP_USB_MIN		0
-#define EXTCON_PROP_USB_MAX		1
+#define EXTCON_PROP_USB_MAX		2
 #define EXTCON_PROP_USB_CNT	(EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1)
 
 /* Properties of EXTCON_TYPE_CHG. */
-- 
2.5.0

[toc] | [next] | [standalone]

#1463312

FromChanwoo Choi <cw00.choi@samsung.com>
Date2016-08-16 03:00 +0200
Message-ID<s6ATv-4sZ-3@gated-at.bofh.it>
In reply to#1462774
Hi Guenter,

Looks good to me.
I'll add the reference[1] information on patch description and applied it.
[1] https://en.wikipedia.org/wiki/USB#Overview

Thanks,
Chanwoo Choi

On 2016년 08월 15일 22:15, Guenter Roeck wrote:
> From: Guenter Roeck <groeck@chromium.org>
> 
> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2
> and USB3 connections on USB Type-C cables.
> 
> Cc: Chris Zhong <zyw@rock-chips.com>
> Signed-off-by: Guenter Roeck <groeck@chromium.org>
> ---
> Applies on top of extcon-next.
> 
>  include/linux/extcon.h | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index ad7a1606a7f3..38d2c0dec2c1 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -107,12 +107,18 @@
>   * @type:	integer (intval)
>   * @value:	0 (normal) or 1 (flip)
>   * @default:	0 (normal)
> + * - EXTCON_PROP_USB_SUPERSPEED
> + * @type:       integer (intval)
> + * @value:      0 (USB/USB2) or 1 (USB3)
> + * @default:    0 (USB/USB2)
> + *
>   */
>  #define EXTCON_PROP_USB_VBUS		0
>  #define EXTCON_PROP_USB_TYPEC_POLARITY	1
> +#define EXTCON_PROP_USB_SUPERSPEED	2
>  
>  #define EXTCON_PROP_USB_MIN		0
> -#define EXTCON_PROP_USB_MAX		1
> +#define EXTCON_PROP_USB_MAX		2
>  #define EXTCON_PROP_USB_CNT	(EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1)
>  
>  /* Properties of EXTCON_TYPE_CHG. */
>

[toc] | [prev] | [next] | [standalone]

#1463340

FromGuenter Roeck <groeck@google.com>
Date2016-08-16 03:50 +0200
Message-ID<s6BFU-52d-25@gated-at.bofh.it>
In reply to#1463312
On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi Guenter,
>
> Looks good to me.
> I'll add the reference[1] information on patch description and applied it.
> [1] https://en.wikipedia.org/wiki/USB#Overview
>

Thanks!

Guenter

> Thanks,
> Chanwoo Choi
>
> On 2016년 08월 15일 22:15, Guenter Roeck wrote:
>> From: Guenter Roeck <groeck@chromium.org>
>>
>> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2
>> and USB3 connections on USB Type-C cables.
>>
>> Cc: Chris Zhong <zyw@rock-chips.com>
>> Signed-off-by: Guenter Roeck <groeck@chromium.org>
>> ---
>> Applies on top of extcon-next.
>>
>>  include/linux/extcon.h | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
>> index ad7a1606a7f3..38d2c0dec2c1 100644
>> --- a/include/linux/extcon.h
>> +++ b/include/linux/extcon.h
>> @@ -107,12 +107,18 @@
>>   * @type:    integer (intval)
>>   * @value:   0 (normal) or 1 (flip)
>>   * @default: 0 (normal)
>> + * - EXTCON_PROP_USB_SUPERSPEED
>> + * @type:       integer (intval)
>> + * @value:      0 (USB/USB2) or 1 (USB3)
>> + * @default:    0 (USB/USB2)
>> + *
>>   */
>>  #define EXTCON_PROP_USB_VBUS         0
>>  #define EXTCON_PROP_USB_TYPEC_POLARITY       1
>> +#define EXTCON_PROP_USB_SUPERSPEED   2
>>
>>  #define EXTCON_PROP_USB_MIN          0
>> -#define EXTCON_PROP_USB_MAX          1
>> +#define EXTCON_PROP_USB_MAX          2
>>  #define EXTCON_PROP_USB_CNT  (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1)
>>
>>  /* Properties of EXTCON_TYPE_CHG. */
>>
>

[toc] | [prev] | [next] | [standalone]

#1464862

FromGuenter Roeck <groeck@google.com>
Date2016-08-18 02:50 +0200
Message-ID<s7jGW-t1-9@gated-at.bofh.it>
In reply to#1463340
On Wed, Aug 17, 2016 at 5:37 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi Guenter,
>
> How about changing the property name for SuperSpeed as following?
> It is more simple and reduce the length of property name.
> - EXTCON_PROP_USB_SUPERSPEED -> EXTCON_PROP_USB_SS
>
Whatever you prefer is fine.

Thanks,
Guenter

> Regards,
> Chanwoo Choi
>
> On 2016년 08월 16일 10:41, Guenter Roeck wrote:
>> On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>>> Hi Guenter,
>>>
>>> Looks good to me.
>>> I'll add the reference[1] information on patch description and applied it.
>>> [1] https://en.wikipedia.org/wiki/USB#Overview
>>>
>>
>> Thanks!
>>
>> Guenter
>>
>>> Thanks,
>>> Chanwoo Choi
>>>
>>> On 2016년 08월 15일 22:15, Guenter Roeck wrote:
>>>> From: Guenter Roeck <groeck@chromium.org>
>>>>
>>>> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2
>>>> and USB3 connections on USB Type-C cables.
>>>>
>>>> Cc: Chris Zhong <zyw@rock-chips.com>
>>>> Signed-off-by: Guenter Roeck <groeck@chromium.org>
>>>> ---
>>>> Applies on top of extcon-next.
>>>>
>>>>  include/linux/extcon.h | 8 +++++++-
>>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
>>>> index ad7a1606a7f3..38d2c0dec2c1 100644
>>>> --- a/include/linux/extcon.h
>>>> +++ b/include/linux/extcon.h
>>>> @@ -107,12 +107,18 @@
>>>>   * @type:    integer (intval)
>>>>   * @value:   0 (normal) or 1 (flip)
>>>>   * @default: 0 (normal)
>>>> + * - EXTCON_PROP_USB_SUPERSPEED
>>>> + * @type:       integer (intval)
>>>> + * @value:      0 (USB/USB2) or 1 (USB3)
>>>> + * @default:    0 (USB/USB2)
>>>> + *
>>>>   */
>>>>  #define EXTCON_PROP_USB_VBUS         0
>>>>  #define EXTCON_PROP_USB_TYPEC_POLARITY       1
>>>> +#define EXTCON_PROP_USB_SUPERSPEED   2
>>>>
>>>>  #define EXTCON_PROP_USB_MIN          0
>>>> -#define EXTCON_PROP_USB_MAX          1
>>>> +#define EXTCON_PROP_USB_MAX          2
>>>>  #define EXTCON_PROP_USB_CNT  (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1)
>>>>
>>>>  /* Properties of EXTCON_TYPE_CHG. */
>>>>
>>>
>>
>>
>>
>

[toc] | [prev] | [next] | [standalone]

#1464882

FromChanwoo Choi <cw00.choi@samsung.com>
Date2016-08-18 03:30 +0200
Message-ID<s7kjD-Xz-5@gated-at.bofh.it>
In reply to#1464862
On 2016년 08월 18일 09:41, Guenter Roeck wrote:
> On Wed, Aug 17, 2016 at 5:37 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> Hi Guenter,
>>
>> How about changing the property name for SuperSpeed as following?
>> It is more simple and reduce the length of property name.
>> - EXTCON_PROP_USB_SUPERSPEED -> EXTCON_PROP_USB_SS
>>
> Whatever you prefer is fine.

OK. Thanks. I'll change the property name.

Regards,
Chanwoo Choi

> 
> Thanks,
> Guenter
> 
>> Regards,
>> Chanwoo Choi
>>
>> On 2016년 08월 16일 10:41, Guenter Roeck wrote:
>>> On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>>>> Hi Guenter,
>>>>
>>>> Looks good to me.
>>>> I'll add the reference[1] information on patch description and applied it.
>>>> [1] https://en.wikipedia.org/wiki/USB#Overview
>>>>
>>>
>>> Thanks!
>>>
>>> Guenter
>>>
>>>> Thanks,
>>>> Chanwoo Choi
>>>>
>>>> On 2016년 08월 15일 22:15, Guenter Roeck wrote:
>>>>> From: Guenter Roeck <groeck@chromium.org>
>>>>>
>>>>> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2
>>>>> and USB3 connections on USB Type-C cables.
>>>>>
>>>>> Cc: Chris Zhong <zyw@rock-chips.com>
>>>>> Signed-off-by: Guenter Roeck <groeck@chromium.org>
>>>>> ---
>>>>> Applies on top of extcon-next.
>>>>>
>>>>>  include/linux/extcon.h | 8 +++++++-
>>>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
>>>>> index ad7a1606a7f3..38d2c0dec2c1 100644
>>>>> --- a/include/linux/extcon.h
>>>>> +++ b/include/linux/extcon.h
>>>>> @@ -107,12 +107,18 @@
>>>>>   * @type:    integer (intval)
>>>>>   * @value:   0 (normal) or 1 (flip)
>>>>>   * @default: 0 (normal)
>>>>> + * - EXTCON_PROP_USB_SUPERSPEED
>>>>> + * @type:       integer (intval)
>>>>> + * @value:      0 (USB/USB2) or 1 (USB3)
>>>>> + * @default:    0 (USB/USB2)
>>>>> + *
>>>>>   */
>>>>>  #define EXTCON_PROP_USB_VBUS         0
>>>>>  #define EXTCON_PROP_USB_TYPEC_POLARITY       1
>>>>> +#define EXTCON_PROP_USB_SUPERSPEED   2
>>>>>
>>>>>  #define EXTCON_PROP_USB_MIN          0
>>>>> -#define EXTCON_PROP_USB_MAX          1
>>>>> +#define EXTCON_PROP_USB_MAX          2
>>>>>  #define EXTCON_PROP_USB_CNT  (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1)
>>>>>
>>>>>  /* Properties of EXTCON_TYPE_CHG. */
>>>>>
>>>>
>>>
>>>
>>>
>>
> 
> 
>

[toc] | [prev] | [next] | [standalone]

#1464863

FromChanwoo Choi <cw00.choi@samsung.com>
Date2016-08-18 02:50 +0200
Message-ID<s7jGW-t1-11@gated-at.bofh.it>
In reply to#1463340
Hi Guenter,

How about changing the property name for SuperSpeed as following?
It is more simple and reduce the length of property name.
- EXTCON_PROP_USB_SUPERSPEED -> EXTCON_PROP_USB_SS

Regards,
Chanwoo Choi

On 2016년 08월 16일 10:41, Guenter Roeck wrote:
> On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> Hi Guenter,
>>
>> Looks good to me.
>> I'll add the reference[1] information on patch description and applied it.
>> [1] https://en.wikipedia.org/wiki/USB#Overview
>>
> 
> Thanks!
> 
> Guenter
> 
>> Thanks,
>> Chanwoo Choi
>>
>> On 2016년 08월 15일 22:15, Guenter Roeck wrote:
>>> From: Guenter Roeck <groeck@chromium.org>
>>>
>>> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2
>>> and USB3 connections on USB Type-C cables.
>>>
>>> Cc: Chris Zhong <zyw@rock-chips.com>
>>> Signed-off-by: Guenter Roeck <groeck@chromium.org>
>>> ---
>>> Applies on top of extcon-next.
>>>
>>>  include/linux/extcon.h | 8 +++++++-
>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
>>> index ad7a1606a7f3..38d2c0dec2c1 100644
>>> --- a/include/linux/extcon.h
>>> +++ b/include/linux/extcon.h
>>> @@ -107,12 +107,18 @@
>>>   * @type:    integer (intval)
>>>   * @value:   0 (normal) or 1 (flip)
>>>   * @default: 0 (normal)
>>> + * - EXTCON_PROP_USB_SUPERSPEED
>>> + * @type:       integer (intval)
>>> + * @value:      0 (USB/USB2) or 1 (USB3)
>>> + * @default:    0 (USB/USB2)
>>> + *
>>>   */
>>>  #define EXTCON_PROP_USB_VBUS         0
>>>  #define EXTCON_PROP_USB_TYPEC_POLARITY       1
>>> +#define EXTCON_PROP_USB_SUPERSPEED   2
>>>
>>>  #define EXTCON_PROP_USB_MIN          0
>>> -#define EXTCON_PROP_USB_MAX          1
>>> +#define EXTCON_PROP_USB_MAX          2
>>>  #define EXTCON_PROP_USB_CNT  (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1)
>>>
>>>  /* Properties of EXTCON_TYPE_CHG. */
>>>
>>
> 
> 
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web