Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462292 > unrolled thread

Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments"

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments" Jonathan Corbet <corbet@lwn.net> - 2016-08-14 20:40 +0200
    Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments" Joe Perches <joe@perches.com> - 2016-08-14 20:50 +0200
    Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments" Randy Dunlap <rdunlap@infradead.org> - 2016-08-14 21:10 +0200
      Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments" Joe Perches <joe@perches.com> - 2016-08-14 21:20 +0200

#1462292 — Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments"

On Thu, 04 Aug 2016 10:55:14 -0700
Joe Perches <joe@perches.com> wrote:

> > Because Linus may still be reading source code on greenbar paper
> > instead of color terminals with code syntax highlighting and
> > appropriate font decorations.
> > 
> > Link: http://lkml.kernel.org/r/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@mail.gmail.com
> > 
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> >  Documentation/CodingStyle | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
> > index 9a70ddd..19b2e9c 100644
> > --- a/Documentation/CodingStyle
> > +++ b/Documentation/CodingStyle
> > @@ -461,9 +461,6 @@ When commenting the kernel API functions, please use the kernel-doc format.
> >  See the files Documentation/kernel-doc-nano-HOWTO.txt and scripts/kernel-doc
> >  for details.
> >  
> > -Linux style for comments is the C89 "/* ... */" style.
> > -Don't use C99-style "// ..." comments.
> > -
> >  The preferred style for long (multi-line) comments is:
> >  
> >  	/*  
> 
> ping?

Sorry, I've not been ignoring this, I've just not yet worked up the
courage to apply it.  Yes, Linus said he's fine with C++-style comments,
but I still expect some pushback when people start actually sending them.
I don't quite feel a sense of community consensus on this one.

Still, what the heck, I'll go ahead and apply it.  We can always revert it
when people start screaming :)

jon

[toc] | [next] | [standalone]

#1462295

On Sun, 2016-08-14 at 12:35 -0600, Jonathan Corbet wrote:
> On Thu, 04 Aug 2016 10:55:14 -0700 Joe Perches <joe@perches.com> wrote:
> > > Because Linus may still be reading source code on greenbar paper
> > > instead of color terminals with code syntax highlighting and
> > > appropriate font decorations.
> > > 
> > > Link: http://lkml.kernel.org/r/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@mail.gmail.com
[]
> > > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
[]
> > > @@ -461,9 +461,6 @@ When commenting the kernel API functions, please use the kernel-doc format.
> > >  See the files Documentation/kernel-doc-nano-HOWTO.txt and scripts/kernel-doc
> > >  for details.
> > >  
> > > -Linux style for comments is the C89 "/* ... */" style.
> > > -Don't use C99-style "// ..." comments.
> > > -
> > >  The preferred style for long (multi-line) comments is:
> > >  
> > >  	/*  
> > ping?
> Sorry, I've not been ignoring this, I've just not yet worked up the
> courage to apply it.  Yes, Linus said he's fine with C++-style comments,
> but I still expect some pushback when people start actually sending them.
> I don't quite feel a sense of community consensus on this one.
> 
> Still, what the heck, I'll go ahead and apply it.  We can always revert it
> when people start screaming :)

;)

Yeah, that was my thought too when I sent the patch for
checkpatch to ignore // comments.

What the heck.

I just don't care that much how people comment their code.

Syntax coloring and highlighting works in every editor I use
except the email client and I should change the one I use
(evolution) one day because it's broken anyway.

cheers, Joe

[toc] | [prev] | [next] | [standalone]

#1462297

On 08/14/16 11:35, Jonathan Corbet wrote:
> On Thu, 04 Aug 2016 10:55:14 -0700
> Joe Perches <joe@perches.com> wrote:
> 
>>> Because Linus may still be reading source code on greenbar paper
>>> instead of color terminals with code syntax highlighting and
>>> appropriate font decorations.
>>>
>>> Link: http://lkml.kernel.org/r/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@mail.gmail.com
>>>
>>> Signed-off-by: Joe Perches <joe@perches.com>
>>> ---
>>>  Documentation/CodingStyle | 3 ---
>>>  1 file changed, 3 deletions(-)
>>>
>>> diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
>>> index 9a70ddd..19b2e9c 100644
>>> --- a/Documentation/CodingStyle
>>> +++ b/Documentation/CodingStyle
>>> @@ -461,9 +461,6 @@ When commenting the kernel API functions, please use the kernel-doc format.
>>>  See the files Documentation/kernel-doc-nano-HOWTO.txt and scripts/kernel-doc
>>>  for details.
>>>  
>>> -Linux style for comments is the C89 "/* ... */" style.
>>> -Don't use C99-style "// ..." comments.
>>> -
>>>  The preferred style for long (multi-line) comments is:
>>>  
>>>  	/*  
>>
>> ping?
> 
> Sorry, I've not been ignoring this, I've just not yet worked up the
> courage to apply it.  Yes, Linus said he's fine with C++-style comments,
> but I still expect some pushback when people start actually sending them.
> I don't quite feel a sense of community consensus on this one.
> 
> Still, what the heck, I'll go ahead and apply it.  We can always revert it
> when people start screaming :)

I like it, but like Linus said, we don't want people to send
patches just to "fix" the comment style.

-- 
~Randy

[toc] | [prev] | [next] | [standalone]

#1462299

On Sun, 2016-08-14 at 12:09 -0700, Randy Dunlap wrote:

> I like it, but like Linus said, we don't want people to send
> patches just to "fix" the comment style.

Just fyi, checkpatch makes no recommendation about
converting single line comments to //.

And it shouldn't in my opinion.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web