Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1461978 > unrolled thread

[PATCH 3.16 189/305] ipv6: fix endianness error in icmpv6_err

Started byBen Hutchings <ben@decadent.org.uk>
First post2016-08-14 13:40 +0200
Last post2016-08-14 13:40 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3.16 189/305] ipv6: fix endianness error in icmpv6_err Ben Hutchings <ben@decadent.org.uk> - 2016-08-14 13:40 +0200

#1461978 — [PATCH 3.16 189/305] ipv6: fix endianness error in icmpv6_err

FromBen Hutchings <ben@decadent.org.uk>
Date2016-08-14 13:40 +0200
Subject[PATCH 3.16 189/305] ipv6: fix endianness error in icmpv6_err
Message-ID<s61VM-7r3-53@gated-at.bofh.it>
3.16.37-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Hannes Frederic Sowa <hannes@stressinduktion.org>

commit dcb94b88c09ce82a80e188d49bcffdc83ba215a6 upstream.

IPv6 ping socket error handler doesn't correctly convert the new 32 bit
mtu to host endianness before using.

Cc: Lorenzo Colitti <lorenzo@google.com>
Fixes: 6d0bfe22611602f ("net: ipv6: Add IPv6 support to the ping socket.")
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Acked-by: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 net/ipv6/icmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/ipv6/icmp.c
+++ b/net/ipv6/icmp.c
@@ -97,7 +97,7 @@ static void icmpv6_err(struct sk_buff *s
 
 	if (!(type & ICMPV6_INFOMSG_MASK))
 		if (icmp6->icmp6_type == ICMPV6_ECHO_REQUEST)
-			ping_err(skb, offset, info);
+			ping_err(skb, offset, ntohl(info));
 }
 
 static int icmpv6_rcv(struct sk_buff *skb);

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web