Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1461526 > unrolled thread

[PATCH 00/13] various remoteproc/rpmsg trivial cleanups

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/13] various remoteproc/rpmsg trivial cleanups Suman Anna <s-anna@ti.com> - 2016-08-13 01:50 +0200
    [PATCH 01/13] remoteproc: use proper format-specifier for printing dma_addr_t Suman Anna <s-anna@ti.com> - 2016-08-13 01:50 +0200
    [PATCH 06/13] remoteproc: print hex numbers with a leading 0x format Suman Anna <s-anna@ti.com> - 2016-08-13 01:50 +0200
    Re: [PATCH 00/13] various remoteproc/rpmsg trivial cleanups Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-13 07:20 +0200

#1461526 — [PATCH 00/13] various remoteproc/rpmsg trivial cleanups

Hi Bjorn,

Following are a bunch of trivial cleanups in remoteproc core, rpmsg
bus core and couple of cleanups in OMAP remoteproc driver. The patches
are baselined on 4.8-rc1 + your rproc-next branch.

The only non-cleanup patches are the last two patches - the first of
which switches a hex_dump to a dynamic hex dump, and the second one is
a fix to rpmsg client sample to scale for multiple instances when you
have more than one remoteproc publishing the same rpmsg channel.

regards
Suman

Suman Anna (13):
  remoteproc: use proper format-specifier for printing dma_addr_t
  remoteproc: fix couple of minor typos
  remoteproc: use variable names for sizeof() operator
  remoteproc: fix bare unsigned type usage
  remoteproc: align code with open parenthesis
  remoteproc: print hex numbers with a leading 0x format
  remoteproc/omap: fix various code formatting issues
  remoteproc/omap: revise a minor error trace message
  rpmsg: remove pointless OOM prints
  rpmsg: use proper format-specifier for printing dma_addr_t
  rpmsg: align code with open parenthesis
  rpmsg: use dynamic_hex_dump for hex dump traces
  samples/rpmsg: add support for multiple instances

 drivers/remoteproc/da8xx_remoteproc.c         |  2 +-
 drivers/remoteproc/omap_remoteproc.c          |  5 +-
 drivers/remoteproc/remoteproc_core.c          | 51 ++++++++++-----------
 drivers/remoteproc/remoteproc_debugfs.c       | 20 ++++----
 drivers/remoteproc/remoteproc_elf_loader.c    |  6 +--
 drivers/remoteproc/remoteproc_internal.h      | 15 +++---
 drivers/remoteproc/remoteproc_virtio.c        | 22 ++++-----
 drivers/rpmsg/virtio_rpmsg_bus.c              | 66 +++++++++++++--------------
 include/linux/platform_data/remoteproc-omap.h |  6 +--
 include/linux/remoteproc.h                    |  6 +--
 include/linux/rpmsg.h                         |  6 +--
 samples/rpmsg/rpmsg_client_sample.c           | 18 ++++++--
 12 files changed, 118 insertions(+), 105 deletions(-)

-- 
2.9.0

[toc] | [next] | [standalone]

#1461527 — [PATCH 01/13] remoteproc: use proper format-specifier for printing dma_addr_t

The dma_addr_t types can be printed properly using the %pad
printk format-specifier, there is no need to resort to the
unsigned long long type-casting to deal with different possible
type sizes.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 drivers/remoteproc/remoteproc_core.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 63fd365dec14..3a9982b8e8c2 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -236,8 +236,8 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
 	}
 	notifyid = ret;
 
-	dev_dbg(dev, "vring%d: va %p dma %llx size %x idr %d\n", i, va,
-				(unsigned long long)dma, size, notifyid);
+	dev_dbg(dev, "vring%d: va %p dma %pad size %x idr %d\n",
+		i, va, &dma, size, notifyid);
 
 	rvring->va = va;
 	rvring->dma = dma;
@@ -594,8 +594,8 @@ static int rproc_handle_carveout(struct rproc *rproc,
 		goto free_carv;
 	}
 
-	dev_dbg(dev, "carveout va %p, dma %llx, len 0x%x\n", va,
-					(unsigned long long)dma, rsc->len);
+	dev_dbg(dev, "carveout va %p, dma %pad, len 0x%x\n",
+		va, &dma, rsc->len);
 
 	/*
 	 * Ok, this is non-standard.
@@ -639,8 +639,8 @@ static int rproc_handle_carveout(struct rproc *rproc,
 		mapping->len = rsc->len;
 		list_add_tail(&mapping->node, &rproc->mappings);
 
-		dev_dbg(dev, "carveout mapped 0x%x to 0x%llx\n",
-					rsc->da, (unsigned long long)dma);
+		dev_dbg(dev, "carveout mapped 0x%x to %pad\n",
+			rsc->da, &dma);
 	}
 
 	/*
-- 
2.9.0

[toc] | [prev] | [next] | [standalone]

#1461528 — [PATCH 06/13] remoteproc: print hex numbers with a leading 0x format

There are couple of debug statements that are printing hexadecimal
numbers without the leading 0x. Fix these and use the standard 0x%x
format specifier so that there is no confusion when looking at the
traces.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 drivers/remoteproc/remoteproc_core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index fb92b8084a4e..0f85f7eb476d 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -236,7 +236,7 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
 	}
 	notifyid = ret;
 
-	dev_dbg(dev, "vring%d: va %p dma %pad size %x idr %d\n",
+	dev_dbg(dev, "vring%d: va %p dma %pad size 0x%x idr %d\n",
 		i, va, &dma, size, notifyid);
 
 	rvring->va = va;
@@ -263,7 +263,7 @@ rproc_parse_vring(struct rproc_vdev *rvdev, struct fw_rsc_vdev *rsc, int i)
 	struct fw_rsc_vdev_vring *vring = &rsc->vring[i];
 	struct rproc_vring *rvring = &rvdev->vring[i];
 
-	dev_dbg(dev, "vdev rsc: vring%d: da %x, qsz %d, align %d\n",
+	dev_dbg(dev, "vdev rsc: vring%d: da 0x%x, qsz %d, align %d\n",
 		i, vring->da, vring->num, vring->align);
 
 	/* make sure reserved bytes are zeroes */
@@ -349,7 +349,7 @@ static int rproc_handle_vdev(struct rproc *rproc, struct fw_rsc_vdev *rsc,
 		return -EINVAL;
 	}
 
-	dev_dbg(dev, "vdev rsc: id %d, dfeatures %x, cfg len %d, %d vrings\n",
+	dev_dbg(dev, "vdev rsc: id %d, dfeatures 0x%x, cfg len %d, %d vrings\n",
 		rsc->id, rsc->dfeatures, rsc->config_len, rsc->num_of_vrings);
 
 	/* we currently support only two vrings per rvdev */
@@ -578,7 +578,7 @@ static int rproc_handle_carveout(struct rproc *rproc,
 		return -EINVAL;
 	}
 
-	dev_dbg(dev, "carveout rsc: name: %s, da %x, pa %x, len 0x%x, flags %x\n",
+	dev_dbg(dev, "carveout rsc: name: %s, da 0x%x, pa 0x%x, len 0x%x, flags 0x%x\n",
 		rsc->name, rsc->da, rsc->pa, rsc->len, rsc->flags);
 
 	carveout = kzalloc(sizeof(*carveout), GFP_KERNEL);
-- 
2.9.0

[toc] | [prev] | [next] | [standalone]

#1461594

On Fri 12 Aug 16:42 PDT 2016, Suman Anna wrote:

> Hi Bjorn,
> 
> Following are a bunch of trivial cleanups in remoteproc core, rpmsg
> bus core and couple of cleanups in OMAP remoteproc driver. The patches
> are baselined on 4.8-rc1 + your rproc-next branch.
> 
> The only non-cleanup patches are the last two patches - the first of
> which switches a hex_dump to a dynamic hex dump, and the second one is
> a fix to rpmsg client sample to scale for multiple instances when you
> have more than one remoteproc publishing the same rpmsg channel.
> 
> regards
> Suman
> 

Thanks,

Related to the hexdump stuff; I've seen (and used) a few different
patches for getting dumps out and converted to pcap format for analysis
in Wireshark. I think this would be a really nice feature to have
available without 3rd party patches.

> Suman Anna (13):
>   remoteproc: use proper format-specifier for printing dma_addr_t
>   remoteproc: fix couple of minor typos
>   remoteproc: use variable names for sizeof() operator
>   remoteproc: fix bare unsigned type usage
>   remoteproc: align code with open parenthesis
>   remoteproc: print hex numbers with a leading 0x format
>   remoteproc/omap: fix various code formatting issues
>   remoteproc/omap: revise a minor error trace message

Applied to rproc-next

>   rpmsg: remove pointless OOM prints
>   rpmsg: use proper format-specifier for printing dma_addr_t
>   rpmsg: align code with open parenthesis
>   rpmsg: use dynamic_hex_dump for hex dump traces
>   samples/rpmsg: add support for multiple instances

Applied to rpmsg-next

Regards,
Bjorn

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web