Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1461031 > unrolled thread
| Started by | Axel Lin <axel.lin@ingics.com> |
|---|---|
| First post | 2016-08-12 11:30 +0200 |
| Last post | 2016-08-12 11:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH RESEND] phy: exynos5-usbdrd: Remove "static" from local variable Axel Lin <axel.lin@ingics.com> - 2016-08-12 11:30 +0200
Re: [PATCH RESEND] phy: exynos5-usbdrd: Remove "static" from local variable Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-12 11:40 +0200
| From | Axel Lin <axel.lin@ingics.com> |
|---|---|
| Date | 2016-08-12 11:30 +0200 |
| Subject | [PATCH RESEND] phy: exynos5-usbdrd: Remove "static" from local variable |
| Message-ID | <s5gWS-8h2-13@gated-at.bofh.it> |
The 'reg' local variable does not need to be static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
This patch was sent on http://www.spinics.net/lists/linux-samsung-soc/msg51405.html
drivers/phy/phy-exynos5-usbdrd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
index 20696f5..07ed608 100644
--- a/drivers/phy/phy-exynos5-usbdrd.c
+++ b/drivers/phy/phy-exynos5-usbdrd.c
@@ -249,7 +249,7 @@ static void exynos5_usbdrd_phy_isol(struct phy_usb_instance *inst,
static unsigned int
exynos5_usbdrd_pipe3_set_refclk(struct phy_usb_instance *inst)
{
- static u32 reg;
+ u32 reg;
struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst);
/* restore any previous reference clock settings */
@@ -295,7 +295,7 @@ exynos5_usbdrd_pipe3_set_refclk(struct phy_usb_instance *inst)
static unsigned int
exynos5_usbdrd_utmi_set_refclk(struct phy_usb_instance *inst)
{
- static u32 reg;
+ u32 reg;
struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst);
/* restore any previous reference clock settings */
--
2.1.4
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-08-12 11:40 +0200 |
| Subject | Re: [PATCH RESEND] phy: exynos5-usbdrd: Remove "static" from local variable |
| Message-ID | <s5h6x-8kl-7@gated-at.bofh.it> |
| In reply to | #1461031 |
On 08/12/2016 11:27 AM, Axel Lin wrote: > The 'reg' local variable does not need to be static. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > This patch was sent on http://www.spinics.net/lists/linux-samsung-soc/msg51405.html > > drivers/phy/phy-exynos5-usbdrd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks correct, good catch! Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web