Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1460997 > unrolled thread
| Started by | Wanpeng Li <kernellwp@gmail.com> |
|---|---|
| First post | 2016-08-12 10:20 +0200 |
| Last post | 2016-08-12 11:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] sched/deadline: Fix the intention to re-evalute tick dependency for offline cpu Wanpeng Li <kernellwp@gmail.com> - 2016-08-12 10:20 +0200
Re: [PATCH v2] sched/deadline: Fix the intention to re-evalute tick dependency for offline cpu kbuild test robot <lkp@intel.com> - 2016-08-12 11:00 +0200
| From | Wanpeng Li <kernellwp@gmail.com> |
|---|---|
| Date | 2016-08-12 10:20 +0200 |
| Subject | [PATCH v2] sched/deadline: Fix the intention to re-evalute tick dependency for offline cpu |
| Message-ID | <s5fR7-7BQ-11@gated-at.bofh.it> |
From: Wanpeng Li <wanpeng.li@hotmail.com>
The dl task will be replenished after dl task timer fire and start a
new period. It will be enqueued and to re-evaluate its dependency on
the tick in order to restart it. However, if cpu is hot-unplug,
irq_work_queue will splash since the target cpu is offline.
As a result:
WARNING: CPU: 2 PID: 0 at kernel/irq_work.c:69 irq_work_queue_on+0xad/0xe0
Call Trace:
dump_stack+0x99/0xd0
__warn+0xd1/0xf0
warn_slowpath_null+0x1d/0x20
irq_work_queue_on+0xad/0xe0
tick_nohz_full_kick_cpu+0x44/0x50
tick_nohz_dep_set_cpu+0x74/0xb0
enqueue_task_dl+0x226/0x480
activate_task+0x5c/0xa0
dl_task_timer+0x19b/0x2c0
? push_dl_task.part.31+0x190/0x190
This can be triggered by hot-unplug the full dynticks cpu which dl
task is running on.
We enqueue the dl task on the offline CPU, because we need to do
replenish for start_dl_timer(). So, as Juri pointed out, we would
need to do is calling replenish_dl_entity() directly, instead of
enqueue_task_dl(). pi_se shouldn't be a problem as the task shouldn't
be boosted if it was throttled.
This patch fix it by just replenish dl entity to avoid the intention
to re-evaluate tick dependency if the cpu is offline.
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@arm.com>
Cc: Luca Abeni <luca.abeni@unitn.it>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
---
v1 -> v2:
* replenish dl entity
kernel/sched/deadline.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index d091f4a..b141bd2 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -641,11 +641,15 @@ static enum hrtimer_restart dl_task_timer(struct hrtimer *timer)
goto unlock;
}
- enqueue_task_dl(rq, p, ENQUEUE_REPLENISH);
- if (dl_task(rq->curr))
- check_preempt_curr_dl(rq, p, 0);
- else
- resched_curr(rq);
+ if (unlikely(!rq->online))
+ replenish_dl_entity(dl_se, dl_se);
+ else {
+ enqueue_task_dl(rq, p, ENQUEUE_REPLENISH);
+ if (dl_task(rq->curr))
+ check_preempt_curr_dl(rq, p, 0);
+ else
+ resched_curr(rq);
+ }
#ifdef CONFIG_SMP
/*
--
1.9.1
[toc] | [next] | [standalone]
| From | kbuild test robot <lkp@intel.com> |
|---|---|
| Date | 2016-08-12 11:00 +0200 |
| Subject | Re: [PATCH v2] sched/deadline: Fix the intention to re-evalute tick dependency for offline cpu |
| Message-ID | <s5gtP-7QJ-5@gated-at.bofh.it> |
| In reply to | #1460997 |
[Multipart message — attachments visible in raw view] — view raw
Hi Wanpeng,
[auto build test ERROR on tip/sched/core]
[also build test ERROR on v4.8-rc1 next-20160811]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Wanpeng-Li/sched-deadline-Fix-the-intention-to-re-evalute-tick-dependency-for-offline-cpu/20160812-162528
config: x86_64-randconfig-x013-201632 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
In file included from include/uapi/linux/stddef.h:1:0,
from include/linux/stddef.h:4,
from include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/uapi/linux/capability.h:16,
from include/linux/capability.h:15,
from include/linux/sched.h:15,
from kernel/sched/sched.h:2,
from kernel/sched/deadline.c:17:
kernel/sched/deadline.c: In function 'dl_task_timer':
>> kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
if (unlikely(!rq->online))
^
include/linux/compiler.h:139:45: note: in definition of macro 'unlikely'
# define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0))
^
>> kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
if (unlikely(!rq->online))
^
include/linux/compiler.h:139:53: note: in definition of macro 'unlikely'
# define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0))
^
>> kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
if (unlikely(!rq->online))
^
include/linux/compiler.h:112:47: note: in definition of macro 'likely_notrace'
#define likely_notrace(x) __builtin_expect(!!(x), 1)
^
include/linux/compiler.h:139:58: note: in expansion of macro '__branch_check__'
# define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0))
^~~~~~~~~~~~~~~~
>> kernel/sched/deadline.c:644:6: note: in expansion of macro 'unlikely'
if (unlikely(!rq->online))
^~~~~~~~
vim +644 kernel/sched/deadline.c
638 */
639 if (!task_on_rq_queued(p)) {
640 replenish_dl_entity(dl_se, dl_se);
641 goto unlock;
642 }
643
> 644 if (unlikely(!rq->online))
645 replenish_dl_entity(dl_se, dl_se);
646 else {
647 enqueue_task_dl(rq, p, ENQUEUE_REPLENISH);
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web