Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460843 > unrolled thread

[PATCH] get_maintainer: Quiet noisy implicit -f vcs_file_exists checking

Back to article view | Back to linux.kernel

Contents

  [PATCH] get_maintainer: Quiet noisy implicit -f vcs_file_exists checking Joe Perches <joe@perches.com> - 2016-08-12 00:50 +0200
    Re: [PATCH] get_maintainer: Quiet noisy implicit -f vcs_file_exists  checking Wolfram Sang <wsa@the-dreams.de> - 2016-08-12 10:20 +0200

#1460843 — [PATCH] get_maintainer: Quiet noisy implicit -f vcs_file_exists checking

Checking command line filenames that are outside the git tree
can emit a noisy and confusing message.

Quiet that message by redirecting stderr.
Verify that the command was executed successfully.

Fixes: 4cad35a7ca69 ("get_maintainer.pl: reduce need for command-line option -f")
Reported-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Joe Perches <joe@perches.com>
---
 scripts/get_maintainer.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 49a00d5..aed4511 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -2136,9 +2136,11 @@ sub vcs_file_exists {
 
     my $cmd = $VCS_cmds{"file_exists_cmd"};
     $cmd =~ s/(\$\w+)/$1/eeg;		# interpolate $cmd
-
+    $cmd .= " 2>&1";
     $exists = &{$VCS_cmds{"execute_cmd"}}($cmd);
 
+    return 0 if ($? != 0);
+
     return $exists;
 }
 
-- 
2.8.0.rc4.16.g56331f8

[toc] | [next] | [standalone]

#1460996 — Re: [PATCH] get_maintainer: Quiet noisy implicit -f vcs_file_exists checking

[Multipart message — attachments visible in raw view] — view raw

On Thu, Aug 11, 2016 at 03:46:03PM -0700, Joe Perches wrote:
> Checking command line filenames that are outside the git tree
> can emit a noisy and confusing message.
> 
> Quiet that message by redirecting stderr.
> Verify that the command was executed successfully.
> 
> Fixes: 4cad35a7ca69 ("get_maintainer.pl: reduce need for command-line option -f")
> Reported-by: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Joe Perches <joe@perches.com>

Tested-by: Wolfram Sang <wsa@the-dreams.de>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web