Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1461748 > unrolled thread

[PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable

Back to article view | Back to linux.kernel

Contents

  [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-08-14 11:30 +0200
    Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused  "int ret" variable Wolfram Sang <wsa@the-dreams.de> - 2016-08-14 14:10 +0200

#1461748 — [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable

In commit 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't
print error when adding adapter fails") the users of the variable
were removed, resulting in:

drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function ‘mb862xx_i2c_init’:
drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning: unused variable ‘ret’ [-Wunused-variable]
  int ret;
      ^

...so here we remove the variable as well.

Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails)"
Cc: Wolfram Sang <wsa-dev@sang-engineering.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

[Feel free to squash this into the original if you happen to be rebasing]

 drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index 76d206857e3e..ba96c44f2761 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -157,8 +157,6 @@ static struct i2c_adapter mb862xx_i2c_adapter = {
 
 int mb862xx_i2c_init(struct mb862xxfb_par *par)
 {
-	int ret;
-
 	mb862xx_i2c_adapter.algo_data = par;
 	par->adap = &mb862xx_i2c_adapter;
 
-- 
2.8.4

[toc] | [next] | [standalone]

#1462093 — Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable

[Multipart message — attachments visible in raw view] — view raw

On Sat, Aug 13, 2016 at 02:39:13PM -0400, Paul Gortmaker wrote:
> In commit 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't
> print error when adding adapter fails") the users of the variable
> were removed, resulting in:
> 
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function ‘mb862xx_i2c_init’:
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning: unused variable ‘ret’ [-Wunused-variable]
>   int ret;
>       ^
> 
> ...so here we remove the variable as well.
> 
> Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails)"
> Cc: Wolfram Sang <wsa-dev@sang-engineering.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---

Acked-by: Wolfram Sang <wsa-dev@sang-engineering.com>

Thanks! I wonder how this slipped through my and the buildbot checks.
Will investigate...

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web