Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460223 > unrolled thread

Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear Lee Jones <lee.jones@linaro.org> - 2016-08-11 09:40 +0200
    Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-11 21:20 +0200
      Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear Suman Anna <s-anna@ti.com> - 2016-08-11 22:20 +0200

#1460223 — Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear

On Wed, 10 Aug 2016, Suman Anna wrote:

> On 08/09/2016 01:12 PM, Lee Jones wrote:
> > On Tue, 09 Aug 2016, Bjorn Andersson wrote:
> > 
> >> On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote:
> >>
> >>> Before this patch, the dma_alloc_coherent() failure path printed out:
> >>>
> >>>   "dma_alloc_coherent err: 16760832"
> >>>
> >>> ... alluding to the Linux error code being 16760832, but seeing as
> >>> Linux error codes are all negative, this looks like a signed/unsigned
> >>> issue.  In fact, the message is trying to print the length of the
> >>> requested memory region.  Let's clear that up.
> >>>
> >>> While we're at it, let's standardise the way 'len' is printed.  In
> >>> all other locations 'len' is in hex prefixed by a '0x' for clarity.
> >>>
> >>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> >>
> >> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > 
> > Again, this can just be applied.
> > 
> >>> ---
> >>>  drivers/remoteproc/remoteproc_core.c | 5 +++--
> >>>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> >>> index aea29a75c..3566dc9 100644
> >>> --- a/drivers/remoteproc/remoteproc_core.c
> >>> +++ b/drivers/remoteproc/remoteproc_core.c
> >>> @@ -581,7 +581,7 @@ static int rproc_handle_carveout(struct rproc *rproc,
> >>>  		return -EINVAL;
> >>>  	}
> >>>  
> >>> -	dev_dbg(dev, "carveout rsc: da %x, pa %x, len %x, flags %x\n",
> >>> +	dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n",
> >>>  			rsc->da, rsc->pa, rsc->len, rsc->flags);
> 
> If you are modifying this trace, it's better to following the leading 0x
> convention on all arguments rather than just the length.

I'd be concerned if anyone thought it a good idea to print out memory
addresses !0x.  The length is the only parameter there which could
(and has) cause confusion.

However, the fix-up is trivial, so I'm happy to oblige.  I'll leave
the final decision to Bjorn and fix-up if he sees it necessary.

> >>>  	carveout = kzalloc(sizeof(*carveout), GFP_KERNEL);
> >>> @@ -590,7 +590,8 @@ static int rproc_handle_carveout(struct rproc *rproc,
> >>>  
> >>>  	va = dma_alloc_coherent(dev->parent, rsc->len, &dma, GFP_KERNEL);
> >>>  	if (!va) {
> >>> -		dev_err(dev->parent, "dma_alloc_coherent err: %d\n", rsc->len);
> >>> +		dev_err(dev->parent,
> >>> +			"failed to allocate dma memory: len 0x%x\n", rsc->len);
> >>>  		ret = -ENOMEM;
> >>>  		goto free_carv;
> >>>  	}
> > 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [next] | [standalone]

#1460744

On Thu 11 Aug 00:36 PDT 2016, Lee Jones wrote:

> On Wed, 10 Aug 2016, Suman Anna wrote:
> 
> > On 08/09/2016 01:12 PM, Lee Jones wrote:
> > > On Tue, 09 Aug 2016, Bjorn Andersson wrote:
> > > 
> > >> On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote:
[..]
> > >>> -	dev_dbg(dev, "carveout rsc: da %x, pa %x, len %x, flags %x\n",
> > >>> +	dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n",
> > >>>  			rsc->da, rsc->pa, rsc->len, rsc->flags);
> > 
> > If you are modifying this trace, it's better to following the leading 0x
> > convention on all arguments rather than just the length.
> 
> I'd be concerned if anyone thought it a good idea to print out memory
> addresses !0x.  The length is the only parameter there which could
> (and has) cause confusion.
> 
> However, the fix-up is trivial, so I'm happy to oblige.  I'll leave
> the final decision to Bjorn and fix-up if he sees it necessary.
> 

I applied this patch yesterday, I see both changes here related to the
issue presented (confusing printing of len) so I'm fine with not
touching the other parts.

That said, there are a few other format strings in this driver that
would benefit from some love as well, several cases where we should use
%pK or %pad rather than using %llx and a cast to unsigned long long.

Regards,
Bjorn

[toc] | [prev] | [next] | [standalone]

#1460774

On 08/11/2016 02:19 PM, Bjorn Andersson wrote:
> On Thu 11 Aug 00:36 PDT 2016, Lee Jones wrote:
> 
>> On Wed, 10 Aug 2016, Suman Anna wrote:
>>
>>> On 08/09/2016 01:12 PM, Lee Jones wrote:
>>>> On Tue, 09 Aug 2016, Bjorn Andersson wrote:
>>>>
>>>>> On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote:
> [..]
>>>>>> -	dev_dbg(dev, "carveout rsc: da %x, pa %x, len %x, flags %x\n",
>>>>>> +	dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n",
>>>>>>  			rsc->da, rsc->pa, rsc->len, rsc->flags);
>>>
>>> If you are modifying this trace, it's better to following the leading 0x
>>> convention on all arguments rather than just the length.
>>
>> I'd be concerned if anyone thought it a good idea to print out memory
>> addresses !0x.  The length is the only parameter there which could
>> (and has) cause confusion.
>>
>> However, the fix-up is trivial, so I'm happy to oblige.  I'll leave
>> the final decision to Bjorn and fix-up if he sees it necessary.
>>
> 
> I applied this patch yesterday, I see both changes here related to the
> issue presented (confusing printing of len) so I'm fine with not
> touching the other parts.
> 
> That said, there are a few other format strings in this driver that
> would benefit from some love as well, several cases where we should use
> %pK or %pad rather than using %llx and a cast to unsigned long long.

OK, no issues. I have the patches for some of these handy, will post
them soon.

regards
Suman

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web