Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460696 > unrolled thread

[PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq

Started byJoshua Clayton <stillcompiling@gmail.com>
First post2016-08-11 19:00 +0200
Last post2016-08-15 16:40 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq Joshua Clayton <stillcompiling@gmail.com> - 2016-08-11 19:00 +0200
    Re: [PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq Stefan Wahren <stefan.wahren@i2se.com> - 2016-08-11 19:10 +0200
      Re: [PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq Joshua Clayton <stillcompiling@gmail.com> - 2016-08-11 19:30 +0200
        [PATCH V2 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq Joshua Clayton <stillcompiling@gmail.com> - 2016-08-11 19:40 +0200
          Re: [PATCH V2 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq Shawn Guo <shawnguo@kernel.org> - 2016-08-15 16:40 +0200

#1460696 — [PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq

FromJoshua Clayton <stillcompiling@gmail.com>
Date2016-08-11 19:00 +0200
Subject[PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq
Message-ID<s51uN-6pu-5@gated-at.bofh.it>
Apply hardware workaround for ethernet problem
See nxp erratum err006687

Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
 arch/arm/boot/dts/imx6q-evi.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts
index 49c6f61..33bd04b 100644
--- a/arch/arm/boot/dts/imx6q-evi.dts
+++ b/arch/arm/boot/dts/imx6q-evi.dts
@@ -127,6 +127,8 @@
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii";
 	phy-reset-gpios = <&gpio1 25 0>;
+	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
+			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
 	status = "okay";
 };
 
@@ -312,6 +314,7 @@
 			MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0
 			MX6QDL_PAD_ENET_TX_EN__ENET_TX_EN 0x4001b0a8
 			MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0
+			MX6QDL_PAD_GPIO_6__ENET_IRQ 0x000b1
 		>;
 	};
 
-- 
2.7.4

[toc] | [next] | [standalone]

#1460703

FromStefan Wahren <stefan.wahren@i2se.com>
Date2016-08-11 19:10 +0200
Message-ID<s51Et-6Jw-9@gated-at.bofh.it>
In reply to#1460696
Hi Joshua,

> Joshua Clayton <stillcompiling@gmail.com> hat am 11. August 2016 um 18:54
> geschrieben:
> 
> 
> Apply hardware workaround for ethernet problem
> See nxp erratum err006687

do you know this commit?

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a28eeb43ee57e0524c59e64760ed28088dd159cb

Maybe you want to add this property, too.

[toc] | [prev] | [next] | [standalone]

#1460709

FromJoshua Clayton <stillcompiling@gmail.com>
Date2016-08-11 19:30 +0200
Message-ID<s51XQ-6Q4-49@gated-at.bofh.it>
In reply to#1460703
Stefan,

On 08/11/2016 10:09 AM, Stefan Wahren wrote:
> Hi Joshua,
>
>> Joshua Clayton <stillcompiling@gmail.com> hat am 11. August 2016 um 18:54
>> geschrieben:
>>
>>
>> Apply hardware workaround for ethernet problem
>> See nxp erratum err006687
> do you know this commit?
>
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a28eeb43ee57e0524c59e64760ed28088dd159cb
>
> Maybe you want to add this property, too.
I missed that this change requiring (more) explicit enablement was merge to linux-next.
I'll add that.

[toc] | [prev] | [next] | [standalone]

#1460714 — [PATCH V2 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq

FromJoshua Clayton <stillcompiling@gmail.com>
Date2016-08-11 19:40 +0200
Subject[PATCH V2 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq
Message-ID<s527v-6Tl-21@gated-at.bofh.it>
In reply to#1460709
Apply hardware workaround for ethernet problem
See nxp erratum err006687

Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---

Changed since V1:
- added fsl,err006687-workaround-present; so that it will continue to work

 arch/arm/boot/dts/imx6q-evi.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts
index 49c6f61..33bd04b 100644
--- a/arch/arm/boot/dts/imx6q-evi.dts
+++ b/arch/arm/boot/dts/imx6q-evi.dts
@@ -127,6 +127,8 @@
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii";
 	phy-reset-gpios = <&gpio1 25 0>;
+	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
+			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
+	fsl,err006687-workaround-present;
 	status = "okay";
 };
 
@@ -312,6 +314,7 @@
 			MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0
 			MX6QDL_PAD_ENET_TX_EN__ENET_TX_EN 0x4001b0a8
 			MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0
+			MX6QDL_PAD_GPIO_6__ENET_IRQ 0x000b1
 		>;
 	};
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1462830 — Re: [PATCH V2 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq

FromShawn Guo <shawnguo@kernel.org>
Date2016-08-15 16:40 +0200
SubjectRe: [PATCH V2 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq
Message-ID<s6rdw-6L9-13@gated-at.bofh.it>
In reply to#1460714
On Thu, Aug 11, 2016 at 10:35:16AM -0700, Joshua Clayton wrote:
> Apply hardware workaround for ethernet problem
> See nxp erratum err006687
> 
> Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>

Applied, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web