Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460669 > unrolled thread

[PATCH] gpio: refactor gpiochip_find() slightly

Back to article view | Back to linux.kernel

Contents

  [PATCH] gpio: refactor gpiochip_find() slightly Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-11 18:30 +0200
    Re: [PATCH] gpio: refactor gpiochip_find() slightly Linus Walleij <linus.walleij@linaro.org> - 2016-08-19 11:00 +0200

#1460669 — [PATCH] gpio: refactor gpiochip_find() slightly

The if...else... block after the loop can be dropped with
a slight refactoring.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/gpio/gpiolib.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 53ff25a..deaf4d4 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1363,19 +1363,15 @@ struct gpio_chip *gpiochip_find(void *data,
 					     void *data))
 {
 	struct gpio_device *gdev;
-	struct gpio_chip *chip;
+	struct gpio_chip *chip = NULL;
 	unsigned long flags;
 
 	spin_lock_irqsave(&gpio_lock, flags);
 	list_for_each_entry(gdev, &gpio_devices, list)
-		if (gdev->chip && match(gdev->chip, data))
+		if (gdev->chip && match(gdev->chip, data)) {
+			chip = gdev->chip;
 			break;
-
-	/* No match? */
-	if (&gdev->list == &gpio_devices)
-		chip = NULL;
-	else
-		chip = gdev->chip;
+		}
 
 	spin_unlock_irqrestore(&gpio_lock, flags);
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1466235

On Thu, Aug 11, 2016 at 6:21 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> The if...else... block after the loop can be dropped with
> a slight refactoring.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web